public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alexandre Rostovtsev <tetromino@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [RFC] new vala.eclass
Date: Mon, 27 Aug 2012 00:45:45 -0400	[thread overview]
Message-ID: <1346042745.9829.112.camel@rook> (raw)
In-Reply-To: <20120826224553.700b29ca@gentoo.org>

On Sun, 2012-08-26 at 22:45 -0400, Alexis Ballier wrote:
> On Sun, 26 Aug 2012 19:43:32 -0400
> Alexandre Rostovtsev <tetromino@gentoo.org> wrote:
> > The variables that vala_pkg_setup sets are needed only at build time.
> 
> so it should be vala_src_prepare / unpack instead ?
> definitely not anything pkg_* imho

IMHO src_prepare or src_unpack would be misleading because the function
does not modify the package's source and has nothing to do with
unpacking. It's not an unusual idiom to set various environment
variables in pkg_setup even if those variables are relevant only at
build time; gnome-extra/zeitgeist and xfce4-vala/xfce4-vala are typical
examples that already export VALAC in their pkg_setup().



  reply	other threads:[~2012-08-27  4:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-25 16:09 [gentoo-dev] [RFC] new vala.eclass Alexandre Rostovtsev
2012-08-25 17:25 ` Tomáš Chvátal
2012-08-25 18:29   ` Diego Elio Pettenò
2012-08-25 21:04 ` Alexandre Rostovtsev
2012-08-25 21:45   ` Ulrich Mueller
2012-08-26  6:59     ` Alexandre Rostovtsev
2012-08-26  7:08       ` Alexandre Rostovtsev
2012-08-26  7:20       ` Alexandre Rostovtsev
2012-08-26 22:45       ` Zac Medico
2012-08-26 23:43         ` Alexandre Rostovtsev
2012-08-27  2:45           ` Alexis Ballier
2012-08-27  4:45             ` Alexandre Rostovtsev [this message]
2012-08-27 12:19               ` Alexis Ballier
2012-08-26 22:32   ` [gentoo-dev] " Duncan
2012-08-27  1:20 ` [gentoo-dev] " Alexandre Rostovtsev
2012-08-27 13:21 ` Alexandre Rostovtsev
2012-09-10  2:09 ` Alexandre Rostovtsev
2012-09-12 20:24   ` Alexandre Rostovtsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346042745.9829.112.camel@rook \
    --to=tetromino@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox