[gentoo-dev] prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete

[gentoo-dev] prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete

[Samuli Suominen]

The logic in prune_libtool_files is not perfect[1].

If you are updating ebuild for whatever reason and see `find` command to 
punt .la files, and replace it with prune_libtool_files then you also 
need to build the package (with "every" possible USE flag combination) 
to see if --all argument is also needed.

To clarify:

Use `prune_libtool_files --all` instead of plain `prune_libtool_files` 
if you don't test the package with the USE flags.

Not going to point anyone with a finger but the accident has already 
happened couple of times in tree :P

[1] http://bugs.gentoo.org/421197

Re: [gentoo-dev] prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

On Wed, 27 Jun 2012 22:12:34 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:

> The logic in prune_libtool_files is not perfect[1].

Define 'perfect'.

> To clarify:
> 
> Use `prune_libtool_files --all` instead of plain
> `prune_libtool_files` if you don't test the package with the USE
> flags.

Sounds like abuse of '--all' to me. It's like calling 'rm -r' for
single file...

> [1] http://bugs.gentoo.org/421197

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

Re: [gentoo-dev] prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

El jue, 28-06-2012 a las 10:26 +0200, Michał Górny escribió:
> On Wed, 27 Jun 2012 22:12:34 +0300
> Samuli Suominen <ssuominen@gentoo.org> wrote:
> 
> > The logic in prune_libtool_files is not perfect[1].
> 
> Define 'perfect'.
> 
> > To clarify:
> > 
> > Use `prune_libtool_files --all` instead of plain
> > `prune_libtool_files` if you don't test the package with the USE
> > flags.
> 
> Sounds like abuse of '--all' to me. It's like calling 'rm -r' for
> single file...
> 
> > [1] http://bugs.gentoo.org/421197
> 

But we will need to use "--all" in cases like pointed in that bug
report, no? :/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

On Thu, 28 Jun 2012 23:18:56 +0200
Pacho Ramos <pacho@gentoo.org> wrote:

> El jue, 28-06-2012 a las 10:26 +0200, Michał Górny escribió:
> > On Wed, 27 Jun 2012 22:12:34 +0300
> > Samuli Suominen <ssuominen@gentoo.org> wrote:
> > 
> > > The logic in prune_libtool_files is not perfect[1].
> > 
> > Define 'perfect'.
> > 
> > > To clarify:
> > > 
> > > Use `prune_libtool_files --all` instead of plain
> > > `prune_libtool_files` if you don't test the package with the USE
> > > flags.
> > 
> > Sounds like abuse of '--all' to me. It's like calling 'rm -r' for
> > single file...
> > 
> > > [1] http://bugs.gentoo.org/421197
> > 
> 
> But we will need to use "--all" in cases like pointed in that bug
> report, no? :/

You need to use it if the package passes '-module' to libtool,
and doesn't use plugin loader which uses .la files (ltdl, gmodule).

The main point is that installing _those_ .la files doesn't do any harm
to the system (they can't be linked against). Removing them may (for
example, in ImageMagick).

It's sad that people start running with pitchforks when they see
anything looking like .la without really understanding what it does.
And yes, I already had users removing all *.la files and then
complaining programs no longer work...

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]