[gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Pacho Ramos]

[-- Attachment #1.1: Type: text/plain, Size: 338 bytes --]

Attached patch tries to make it respect:
http://standards.freedesktop.org/menu-spec/latest/apa.html

for app-* categories. Currently, all categories are set as "Main
Category" and that causes them to be shown under "Others" in Gnome menu.
The way to go is to put "Additional Categories" insider their respective
main categories.


[-- Attachment #1.2: 1.patch --]
[-- Type: text/x-patch, Size: 1492 bytes --]

--- /home/pacho/gentoo-x86/eclass/eutils.eclass	2012-02-18 09:30:19.000000000 +0100
+++ /usr/portage/eclass/eutils.eclass	2012-02-23 10:27:04.000000000 +0100
@@ -653,22 +653,22 @@
 		case ${catmaj} in
 			app)
 				case ${catmin} in
-					accessibility) type=Accessibility;;
+					accessibility) type="Utility;Accessibility";;
 					admin)         type=System;;
 					antivirus)     type=System;;
-					arch)          type=Archiving;;
-					backup)        type=Archiving;;
-					cdr)           type=DiscBurning;;
-					dicts)         type=Dictionary;;
+					arch)          type="Utility;Archiving";;
+					backup)        type="Utility;Archiving";;
+					cdr)           type="AudioVideo;DiscBurning";;
+					dicts)         type="Office;Dictionary";;
 					doc)           type=Documentation;;
-					editors)       type=TextEditor;;
-					emacs)         type=TextEditor;;
-					emulation)     type=Emulator;;
-					laptop)        type=HardwareSettings;;
+					editors)       type="Utility;TextEditor";;
+					emacs)         type="Utility;TextEditor";;
+					emulation)     type="System;Emulator";;
+					laptop)        type="Settings;HardwareSettings";;
 					office)        type=Office;;
-					pda)           type=PDA;;
-					vim)           type=TextEditor;;
-					xemacs)        type=TextEditor;;
+					pda)           type="Office;PDA";;
+					vim)           type="Utility;TextEditor";;
+					xemacs)        type="Utility;TextEditor";;
 				esac
 				;;
 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Brian Dolbec]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Thu, 2012-02-23 at 10:29 +0100, Pacho Ramos wrote:
> Attached patch tries to make it respect:
> http://standards.freedesktop.org/menu-spec/latest/apa.html
> 
> for app-* categories. Currently, all categories are set as "Main
> Category" and that causes them to be shown under "Others" in Gnome menu.
> The way to go is to put "Additional Categories" insider their respective
> main categories.
> 

your missing portage in that catmin group.  There are several packages
in that group that are gtk guis, some QT/kde.

I have always had porthole's .desktop explicitly set the category to
System in order for it to be correct.
-- 
Brian Dolbec <dolsen@gentoo.org>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Ulrich Mueller]

>>>>> On Thu, 23 Feb 2012, Pacho Ramos wrote:

> Attached patch tries to make it respect:
> http://standards.freedesktop.org/menu-spec/latest/apa.html

> The way to go is to put "Additional Categories" insider their
> respective main categories.

> +                    emacs)         type="Utility;TextEditor";;

This should go into the same category as Emacs itself, namely
"Development;TextEditor".

(The description of the Utility category is "Small utility
application, 'Accessories'" which looks wrong for Emacs.)

> +                    vim)           type="Utility;TextEditor";;
> +                    xemacs)        type="Utility;TextEditor";;

The same for these, both desktop entries of XEmacs and gVim have
Development as their main category.

Ulrich

Re: [gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Samuli Suominen]

On 02/23/2012 05:27 PM, Ulrich Mueller wrote:
>>>>>> On Thu, 23 Feb 2012, Pacho Ramos wrote:
>
>> Attached patch tries to make it respect:
>> http://standards.freedesktop.org/menu-spec/latest/apa.html
>
>> The way to go is to put "Additional Categories" insider their
>> respective main categories.
>
>> +                    emacs)         type="Utility;TextEditor";;
>
> This should go into the same category as Emacs itself, namely
> "Development;TextEditor".
>
> (The description of the Utility category is "Small utility
> application, 'Accessories'" which looks wrong for Emacs.)
>
>> +                    vim)           type="Utility;TextEditor";;
>> +                    xemacs)        type="Utility;TextEditor";;
>
> The same for these, both desktop entries of XEmacs and gVim have
> Development as their main category.
>
> Ulrich
>

TextEditor is a subcategory of Utility[1], so what pacho suggested is 
correct

[1] http://standards.freedesktop.org/menu-spec/latest/apa.html

Re: [gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Ulrich Mueller]

>>>>> On Thu, 23 Feb 2012, Samuli Suominen wrote:

> TextEditor is a subcategory of Utility[1], so what pacho suggested
> is correct

The cited specification [1] says:
| The table below describes Additional Categories. The Related
| Categories column lists one or more categories that are suggested
| to be used in conjunction with the Additional Category.

As I read it, "Utility" is only a suggestion, but isn't mandatory as
main category for "TextEditor".

Ulrich

> [1] http://standards.freedesktop.org/menu-spec/latest/apa.html

Re: [gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

El jue, 23-02-2012 a las 17:03 +0100, Ulrich Mueller escribió:
> >>>>> On Thu, 23 Feb 2012, Samuli Suominen wrote:
> 
> > TextEditor is a subcategory of Utility[1], so what pacho suggested
> > is correct
> 
> The cited specification [1] says:
> | The table below describes Additional Categories. The Related
> | Categories column lists one or more categories that are suggested
> | to be used in conjunction with the Additional Category.
> 
> As I read it, "Utility" is only a suggestion, but isn't mandatory as
> main category for "TextEditor".
> 
> Ulrich
> 
> > [1] http://standards.freedesktop.org/menu-spec/latest/apa.html
> 
> 

I have no problem on moving them to "Development" if you think their fit
better there 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Ulrich Mueller]

>>>>> On Thu, 23 Feb 2012, Pacho Ramos wrote:

>> The cited specification [1] says:
>> | The table below describes Additional Categories. The Related
>> | Categories column lists one or more categories that are suggested
>> | to be used in conjunction with the Additional Category.
>> 
>> As I read it, "Utility" is only a suggestion, but isn't mandatory
>> as main category for "TextEditor".
>> 
>> > [1] http://standards.freedesktop.org/menu-spec/latest/apa.html

> I have no problem on moving them to "Development" if you think their
> fit better there

Please do.

Ulrich

Re: [gentoo-dev] eutils.eclass: make_desktop_entry doesn't follow freedesktop spec

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

El vie, 24-02-2012 a las 18:17 +0100, Ulrich Mueller escribió:
> >>>>> On Thu, 23 Feb 2012, Pacho Ramos wrote:
> 
> >> The cited specification [1] says:
> >> | The table below describes Additional Categories. The Related
> >> | Categories column lists one or more categories that are suggested
> >> | to be used in conjunction with the Additional Category.
> >> 
> >> As I read it, "Utility" is only a suggestion, but isn't mandatory
> >> as main category for "TextEditor".
> >> 
> >> > [1] http://standards.freedesktop.org/menu-spec/latest/apa.html
> 
> > I have no problem on moving them to "Development" if you think their
> > fit better there
> 
> Please do.
> 
> Ulrich
> 
> 

Committed with that changes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]