From: Gilles Dartiguelongue <eva@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
Date: Tue, 21 Feb 2012 23:14:12 +0100 [thread overview]
Message-ID: <1329862452.25132.0.camel@keitaro> (raw)
In-Reply-To: <4F40D7C3.1070906@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
> Hi,
>
> any objections against following patch for subversion.eclass?
> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
> reemerge of a package.
>
>
> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
> @@ -469,7 +469,9 @@
> local target="${1}"
> local key="${2}"
>
> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
> + env LC_ALL=C svn info \
> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
> + "${target}" | grep -i "^${key}" | cut -d" " -f2-
> }
>
> ## -- subversion__get_repository_uri()
> --------------------------------------- #
I'm not an expert of the subversion eclass, but the diff looks good.
--
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-21 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 11:06 [gentoo-dev] RFC patch for subversion.eclass (bug 401737) Justin
2012-02-21 22:14 ` Gilles Dartiguelongue [this message]
2012-02-22 17:33 ` Matthew Summers
2012-02-22 17:38 ` Fabian Groffen
2012-02-22 18:40 ` Mike Gilbert
2012-02-22 18:43 ` Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329862452.25132.0.camel@keitaro \
--to=eva@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox