[gentoo-dev] gdk-pixbuf-query-loaders usage in tree

[gentoo-dev] gdk-pixbuf-query-loaders usage in tree

[Fabio Erculiani]

gdk-pixbuf-query-loaders has a long history of segfaults.
Not to blame anybody here, but still segfaults there can happen quite easily.

A nice example is:
export __GL_NO_DSO_FINALIZER=1
$ gdk-pixbuf-query-loaders
When nvidia.ko is in use.

The __GL_NO_DSO_FINALIZER is a hack that made buggy nvidia-drivers (or
buggy gl threads usage?) work.
The problem with our ebuilds is that everybody did something like this
(in pkg_postinst):

gdk-pixbuf-query-loaders > "${ROOT}usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache"

1) exit status is not even considered
2) output redirection truncates the destination file as soon as the
executable is spawned

This is very bad, because in case of segfaults, loaders.cache is
totalled, resulting in gtk+ apps dying miserably.

Please don't do that, never ever. We don't live in a perfect world.

x11-libs/gdk-pixbuf got fixed already.

Others affected:
app-emulation/emul-linux-x86-gtklibs
gnome-base/librsvg
media-libs/libwmf
others?

-- 
Fabio Erculiani
http://lxnay.com

Re: [gentoo-dev] gdk-pixbuf-query-loaders usage in tree

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

El dom, 09-10-2011 a las 10:48 +0200, Fabio Erculiani escribió:
> gdk-pixbuf-query-loaders has a long history of segfaults.
> Not to blame anybody here, but still segfaults there can happen quite easily.
> 
> A nice example is:
> export __GL_NO_DSO_FINALIZER=1
> $ gdk-pixbuf-query-loaders
> When nvidia.ko is in use.
> 
> The __GL_NO_DSO_FINALIZER is a hack that made buggy nvidia-drivers (or
> buggy gl threads usage?) work.
> The problem with our ebuilds is that everybody did something like this
> (in pkg_postinst):
> 
> gdk-pixbuf-query-loaders > "${ROOT}usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache"
> 
> 1) exit status is not even considered
> 2) output redirection truncates the destination file as soon as the
> executable is spawned
> 
> This is very bad, because in case of segfaults, loaders.cache is
> totalled, resulting in gtk+ apps dying miserably.
> 
> Please don't do that, never ever. We don't live in a perfect world.
> 
> x11-libs/gdk-pixbuf got fixed already.
> 
> Others affected:
> app-emulation/emul-linux-x86-gtklibs
> gnome-base/librsvg
> media-libs/libwmf
> others?
> 

I would really appreciate if you could fix this three yourself :-)

Thanks a lot

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]