[gentoo-dev] On the use of bash-completion use flag (Was: [Bug 372031] dev-libs/glib-2.28.* add bash-completion use flag)

[gentoo-dev] On the use of bash-completion use flag (Was: [Bug 372031] dev-libs/glib-2.28.* add bash-completion use flag)

[Nguyen Thai Ngoc Duy]

On Tue, Jun 21, 2011 at 4:35 PM,  <bugzilla-daemon@gentoo.org> wrote:
> --- Comment #2 from Gilles Dartiguelongue <eva@gentoo.org> 2011-06-21 09:35:59 UTC ---
> Afaik, the bash-completion eclass adds the use flag only to make sure the user
> has bash-completion and eselect packages installed. This is imho overkill and
> it indeed meets the point that was made on the ml that installing one file that
> doesn't in itself depends on anything doesn't warrant a USE flag. Maybe the
> discussion should be brought to dev ML to make the situation clearer for
> bash-completion too.

OK let's hear from the ML. Another good thing from bash-completion
eclass is that it advertises bash-completion in pkg_postinst (though
some packages miss this). If we're OK for dev-libs/glib not to use
bash-completion use flag, what about the others, drop the use flag?

BTW while I looked over to see how bash-completion use flag is used, I
encountered some ebuilds that can use improvement. Will probably open
another QA bug for these.

 - bash-completion_pkg_postinst is not called: dev-lang/R,
dev-util/schroot, dev-vcs/git, dev-vcs/subversion,
sci-visualiztion/epix, sys-apps/paludis, sys-cluster/drbd,
sys-cluster/util-vserver, sys-power/nut

 - do not use dobashcompletion: app-misc/task, app-portage/udept,
app-shells/autojump

 - do not use bash-completion eclass: app-pda/osynctool,
x11-wm/awesome (automatically installed?)

 - die after dobashcompletion, or explicitly check for the use flag
before calling: app-portage/flaggie, dev-vcs/topgit, net-misc/aria2,
net-analyzer/linkchecker, www-apps/blazelogger
-- 
Duy

Re: [gentoo-dev] On the use of bash-completion use flag

[Ulrich Mueller]

>>>>> On Tue, 21 Jun 2011, Nguyen Thai Ngoc Duy wrote:

>> --- Comment #2 from Gilles Dartiguelongue <eva@gentoo.org> 2011-06-21 09:35:59 UTC ---
>> Afaik, the bash-completion eclass adds the use flag only to make
>> sure the user has bash-completion and eselect packages installed.
>> This is imho overkill and it indeed meets the point that was made
>> on the ml that installing one file that doesn't in itself depends
>> on anything doesn't warrant a USE flag. Maybe the discussion should
>> be brought to dev ML to make the situation clearer for
>> bash-completion too.

> OK let's hear from the ML. Another good thing from bash-completion
> eclass is that it advertises bash-completion in pkg_postinst (though
> some packages miss this). If we're OK for dev-libs/glib not to use
> bash-completion use flag, what about the others, drop the use flag?

With the flag, some additional files are installed _and_ additional
dependencies like app-shells/bash-completion (which will pull in
further dependencies) are required. Looks like a perfect case for a
USE flag to me. For example, users of embedded systems may not want to
install such additional packages.

Ulrich

Re: [gentoo-dev] On the use of bash-completion use flag

[Gilles Dartiguelongue]

Le mardi 21 juin 2011 à 16:05 +0200, Ulrich Mueller a écrit :
> >>>>> On Tue, 21 Jun 2011, Nguyen Thai Ngoc Duy wrote:
> 
> >> --- Comment #2 from Gilles Dartiguelongue <eva@gentoo.org> 2011-06-21 09:35:59 UTC ---
> >> Afaik, the bash-completion eclass adds the use flag only to make
> >> sure the user has bash-completion and eselect packages installed.
> >> This is imho overkill and it indeed meets the point that was made
> >> on the ml that installing one file that doesn't in itself depends
> >> on anything doesn't warrant a USE flag. Maybe the discussion should
> >> be brought to dev ML to make the situation clearer for
> >> bash-completion too.
> 
> > OK let's hear from the ML. Another good thing from bash-completion
> > eclass is that it advertises bash-completion in pkg_postinst (though
> > some packages miss this). If we're OK for dev-libs/glib not to use
> > bash-completion use flag, what about the others, drop the use flag?
> 
> With the flag, some additional files are installed _and_ additional
> dependencies like app-shells/bash-completion (which will pull in
> further dependencies) are required. Looks like a perfect case for a
> USE flag to me. For example, users of embedded systems may not want to
> install such additional packages.
> 
> Ulrich
> 

my point was the same that was made for systemd. The service files are
useless until you install systemd, yet the eclass doesn't pull systemd.

Hence my request for ml's opinion about why/how bash-completion is any
different ?

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo

Re: [gentoo-dev] On the use of bash-completion use flag

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

On Tue, 21 Jun 2011 16:05:59 +0200
Ulrich Mueller <ulm@gentoo.org> wrote:

> >>>>> On Tue, 21 Jun 2011, Nguyen Thai Ngoc Duy wrote:
> 
> >> --- Comment #2 from Gilles Dartiguelongue <eva@gentoo.org>
> >> 2011-06-21 09:35:59 UTC --- Afaik, the bash-completion eclass adds
> >> the use flag only to make sure the user has bash-completion and
> >> eselect packages installed. This is imho overkill and it indeed
> >> meets the point that was made on the ml that installing one file
> >> that doesn't in itself depends on anything doesn't warrant a USE
> >> flag. Maybe the discussion should be brought to dev ML to make the
> >> situation clearer for bash-completion too.
> 
> > OK let's hear from the ML. Another good thing from bash-completion
> > eclass is that it advertises bash-completion in pkg_postinst (though
> > some packages miss this). If we're OK for dev-libs/glib not to use
> > bash-completion use flag, what about the others, drop the use flag?
> 
> With the flag, some additional files are installed _and_ additional
> dependencies like app-shells/bash-completion (which will pull in
> further dependencies) are required. Looks like a perfect case for a
> USE flag to me. For example, users of embedded systems may not want to
> install such additional packages.

For the additional dependency, I'd put it in some common ebuild (like
bash, or something without compiled binaries -- even better) and I'd
put the flag there.

There's no reason that a dozen of packages PDEPENDs on bash-completion.
If one decides not to use bash-completion any longer, I don't see a
reason to rebuild all those packages just to get rid of one PDEPEND
(and a single file).

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

Re: [gentoo-dev] On the use of bash-completion use flag

["Paweł Hajdan, Jr."]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On 6/24/11 9:07 AM, Michał Górny wrote:
> For the additional dependency, I'd put it in some common ebuild (like
> bash, or something without compiled binaries -- even better) and I'd
> put the flag there.
> 
> There's no reason that a dozen of packages PDEPENDs on bash-completion.
> If one decides not to use bash-completion any longer, I don't see a
> reason to rebuild all those packages just to get rid of one PDEPEND
> (and a single file).

Seconded. I'm in favor of installing bash completion files
unconditionally, and telling the user what to emerge (bash-completion)
to use them.

This is really very very similar to logrotate I think.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: [gentoo-dev] On the use of bash-completion use flag

[Ulrich Mueller]

>>>>> On Fri, 24 Jun 2011, Michał Górny wrote:

> There's no reason that a dozen of packages PDEPENDs on
> bash-completion. If one decides not to use bash-completion any
> longer, I don't see a reason to rebuild all those packages just to
> get rid of one PDEPEND (and a single file).

The question is where to draw the line:

"There's no reason that a dozen of packages RDEPENDs on emacs. If one
decides not to use emacs any longer, I don't see a reason to rebuild
all those packages just to get rid of one RDEPEND (and a single
file)."

Same argument. ;) Should packages install their emacs support files
(it's only one or two small files in most cases) unconditionally?

But seriously: I believe that most people would agree that logrotate
config files should be installed unconditionally, whereas in the case
of emacs they would disagree. bash-completion is somewhere inbetween.

Ulrich

Re: [gentoo-dev] On the use of bash-completion use flag

[Gilles Dartiguelongue]

Le vendredi 24 juin 2011 à 12:37 +0200, Ulrich Mueller a écrit :
> >>>>> On Fri, 24 Jun 2011, Michał Górny wrote:
> 
> > There's no reason that a dozen of packages PDEPENDs on
> > bash-completion. If one decides not to use bash-completion any
> > longer, I don't see a reason to rebuild all those packages just to
> > get rid of one PDEPEND (and a single file).
> 
> The question is where to draw the line:
> 
> "There's no reason that a dozen of packages RDEPENDs on emacs. If one
> decides not to use emacs any longer, I don't see a reason to rebuild
> all those packages just to get rid of one RDEPEND (and a single
> file)."
> 
> Same argument. ;) Should packages install their emacs support files
> (it's only one or two small files in most cases) unconditionally?
> 
> But seriously: I believe that most people would agree that logrotate
> config files should be installed unconditionally, whereas in the case
> of emacs they would disagree. bash-completion is somewhere inbetween.
> 
> Ulrich
> 

Well I'd be in favor of installing emacs support files unconditionally
even though I don't use emacs and I'm not a fan of "wasted space". I
feel like we have enough means for people who care about space to get
rid of these.

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo