[gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

["Paweł Hajdan, Jr."]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Sometimes there are very simple things we can do to make arch
developers' life easier. For example, when stabilizing multiple packages
it's very helpful to post a snippet that can be copy-pasted to
package.keywords, like in those bugs:

http://bugs.gentoo.org/show_bug.cgi?id=322791
http://bugs.gentoo.org/show_bug.cgi?id=329703

I'd like to suggest that all multiple-package stabilization bugs follow
that convention. What do you think?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Gilles Dartiguelongue]

Le lundi 14 février 2011 à 13:30 +0100, "Paweł Hajdan, Jr." a écrit :
> Sometimes there are very simple things we can do to make arch
> developers' life easier. For example, when stabilizing multiple packages
> it's very helpful to post a snippet that can be copy-pasted to
> package.keywords, like in those bugs:
> 
> http://bugs.gentoo.org/show_bug.cgi?id=322791
> http://bugs.gentoo.org/show_bug.cgi?id=329703
> 
> I'd like to suggest that all multiple-package stabilization bugs follow
> that convention. What do you think?
> 

gnome herd does provide a similar list with arches list as well.
Arches can then do cat gnome.list |egrep "myarch" | cut -f1 -d' ' and
they only get the set they should work on.

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo

[gentoo-dev] Re: RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Diego Elio Pettenò]

Il giorno lun, 14/02/2011 alle 14.49 +0100, Gilles Dartiguelongue ha
scritto:
> Arches can then do cat gnome.list |egrep "myarch" | cut -f1 -d' ' and
> they only get the set they should work on. 

awk '/myarch/ { print $1 }' gnome.list

Just sayin' ;)

-- 
Diego Elio Pettenò — Flameeyes
http://blog.flameeyes.eu/

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Tomáš Chvátal]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 14.2.2011 14:49, Gilles Dartiguelongue napsal(a):
> Le lundi 14 février 2011 à 13:30 +0100, "Paweł Hajdan, Jr." a écrit :
>> Sometimes there are very simple things we can do to make arch
>> developers' life easier. For example, when stabilizing multiple packages
>> it's very helpful to post a snippet that can be copy-pasted to
>> package.keywords, like in those bugs:
>>
>> http://bugs.gentoo.org/show_bug.cgi?id=322791
>> http://bugs.gentoo.org/show_bug.cgi?id=329703
>>
>> I'd like to suggest that all multiple-package stabilization bugs follow
>> that convention. What do you think?
>>
> 
> gnome herd does provide a similar list with arches list as well.
> Arches can then do cat gnome.list |egrep "myarch" | cut -f1 -d' ' and
> they only get the set they should work on.
> 
Same does x11 team...
Example:
http://bugs.gentoo.org/show_bug.cgi?id=354237

I think this does not need any policy, most teams can use brains and
fill the bugs quite conveniently :)

Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1ZNy4ACgkQHB6c3gNBRYey8QCggjUauZ3BTJQ28k5aO5gQJqeS
0rQAn08R2d9GvkPxhBrQEz7ohajhCenN
=5k2C
-----END PGP SIGNATURE-----

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Nirbheek Chauhan]

2011/2/14 Tomáš Chvátal <scarabeus@gentoo.org>:
> Dne 14.2.2011 14:49, Gilles Dartiguelongue napsal(a):
> Same does x11 team...
> Example:
> http://bugs.gentoo.org/show_bug.cgi?id=354237
>
> I think this does not need any policy, most teams can use brains and
> fill the bugs quite conveniently :)
>

In related news, there's a nice script to generate such a list:

http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=blob;f=scripts/gen_archlist.py

It will assign a stable keyword for an arch if and only if an earlier
version was stable for that package.

Usage: ./gen_archlist.py <file_with_all_atoms>

to check the dependencies recursively and generate a list:

CHECK_DEPS=1 ./gen_archlist.py <file_with_atoms>

Examples of files with atoms:

http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=tree;f=scripts/test-data

Bugs:

* Only works for generating STABLEREQ lists. KEYWORDREQ is broken (and
I'm too lazy to fix it)

CHECK_DEPS bugs:

* If there's an || dep, selects both for stabilization
* Does not handle the case where use-flags are package.use.masked on
some arch other than the one you're running the script on
  - Script logic is fundamentally broken for this
* Can duplicate atoms sometimes (happens when more than one version
gets pulled in by a dependency)

Patches for fixing these bugs are welcome :p

PS: yes, I know the script's logic is extremely spaghetti. It works
for most cases, so I never rewrote it.

-- 
~Nirbheek Chauhan

Gentoo GNOME+Mozilla Team

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

["Paweł Hajdan, Jr."]

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

On 2/14/11 3:07 PM, Tomáš Chvátal wrote:
> Same does x11 team...
> Example:
> http://bugs.gentoo.org/show_bug.cgi?id=354237
> 
> I think this does not need any policy, most teams can use brains and
> fill the bugs quite conveniently :)

Well, that's the entire point. For the bug you cited, and - for another
example - http://bugs.gentoo.org/show_bug.cgi?id=353434 I can't just
copy-paste something to my package.keywords file.

The table is indeed pretty, and it has value, but I'm just asking for a
bit more convenience.

One more time, the good examples are:

http://bugs.gentoo.org/show_bug.cgi?id=322791
http://bugs.gentoo.org/show_bug.cgi?id=329703

Citing part of good example inline:

> Stabilization list for x86:
> ===========================
> 
> =media-libs/gstreamer-0.10.29
> 
> =media-libs/gst-plugins-base-0.10.29
> =media-plugins/gst-plugins-alsa-0.10.29
> =media-plugins/gst-plugins-cdparanoia-0.10.29

And citing part of *bad* example inline:

> app-admin/eselect-opengl-1.2.1 alpha amd64 arm ppc ppc64 s390 x86
> media-libs/mesa-7.9.1          alpha amd64 arm ppc ppc64      x86

The *good* example can be copy-pasted to package.keywords with no
editing. The *bad* examples requires some editing, and while it can be
automated, there are different formatting conventions, etc etc so IMHO
it's not really feasible.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Samuli Suominen]

On 02/14/2011 07:52 PM, "Paweł Hajdan, Jr." wrote:
> On 2/14/11 3:07 PM, Tomáš Chvátal wrote:
>> Same does x11 team...
>> Example:
>> http://bugs.gentoo.org/show_bug.cgi?id=354237
>>
>> I think this does not need any policy, most teams can use brains and
>> fill the bugs quite conveniently :)
> 
> Well, that's the entire point. For the bug you cited, and - for another
> example - http://bugs.gentoo.org/show_bug.cgi?id=353434 I can't just
> copy-paste something to my package.keywords file.
> 
> The table is indeed pretty, and it has value, but I'm just asking for a
> bit more convenience.
> 
> One more time, the good examples are:
> 
> http://bugs.gentoo.org/show_bug.cgi?id=322791
> http://bugs.gentoo.org/show_bug.cgi?id=329703
> 
> Citing part of good example inline:
> 
>> Stabilization list for x86:
>> ===========================
>>
>> =media-libs/gstreamer-0.10.29
>>
>> =media-libs/gst-plugins-base-0.10.29
>> =media-plugins/gst-plugins-alsa-0.10.29
>> =media-plugins/gst-plugins-cdparanoia-0.10.29
> 
> And citing part of *bad* example inline:
> 
>> app-admin/eselect-opengl-1.2.1 alpha amd64 arm ppc ppc64 s390 x86
>> media-libs/mesa-7.9.1          alpha amd64 arm ppc ppc64      x86
> 
> The *good* example can be copy-pasted to package.keywords with no
> editing. The *bad* examples requires some editing, and while it can be
> automated, there are different formatting conventions, etc etc so IMHO
> it's not really feasible.
> 

And http://bugs.gentoo.org/show_bug.cgi?id=349053#c1 ?   I tried to
provide a clue howto get usable p.keywords list easy.

- Samuli

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

["Paweł Hajdan, Jr."]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

On 2/14/11 9:13 PM, Samuli Suominen wrote:
> And http://bugs.gentoo.org/show_bug.cgi?id=349053#c1 ?   I tried to
> provide a clue howto get usable p.keywords list easy.

IMHO it's in the middle. I still have to do a manual step, but at least
it's pretty straightforward. Anyway, I think a list that can be blindly
copy-pasted makes things even easier.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Gilles Dartiguelongue]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Le lundi 14 février 2011 à 19:19 +0100, "Paweł Hajdan, Jr." a écrit :
> On 2/14/11 9:13 PM, Samuli Suominen wrote:
> > And http://bugs.gentoo.org/show_bug.cgi?id=349053#c1 ?   I tried to
> > provide a clue howto get usable p.keywords list easy.
> 
> IMHO it's in the middle. I still have to do a manual step, but at least
> it's pretty straightforward. Anyway, I think a list that can be blindly
> copy-pasted makes things even easier.
> 

I don't think making a list for each arch is going to make anything any
easier for maintainers requesting stabilization, which means those list
we need more time to generate before being released. You just move the
problem to another place.

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

On 09:10 Tue 15 Feb     , Gilles Dartiguelongue wrote:
> Le lundi 14 février 2011 à 19:19 +0100, "Paweł Hajdan, Jr." a écrit :
> > On 2/14/11 9:13 PM, Samuli Suominen wrote:
> > > And http://bugs.gentoo.org/show_bug.cgi?id=349053#c1 ?   I tried to
> > > provide a clue howto get usable p.keywords list easy.
> > 
> > IMHO it's in the middle. I still have to do a manual step, but at least
> > it's pretty straightforward. Anyway, I think a list that can be blindly
> > copy-pasted makes things even easier.
> > 
> 
> I don't think making a list for each arch is going to make anything any
> easier for maintainers requesting stabilization, which means those list
> we need more time to generate before being released. You just move the
> problem to another place.

Why would you need to do that? Can't you just make a single list that 
either has keywords for every arch or a ** ? Presumably every arch needs 
a certain set of packages stable, and it doesn't matter if you 
redundantly specify packages that are already stable.

-- 
Thanks,
Donnie

Donnie Berkholz
Sr. Developer, Gentoo Linux
Blog: http://dberkholz.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Tobias Klausmann]

Hi! 

On Tue, 15 Feb 2011, Donnie Berkholz wrote:
> On 09:10 Tue 15 Feb, Gilles Dartiguelongue wrote:
> > Le lundi 14 février 2011 à 19:19 +0100, "Paweł Hajdan, Jr." a écrit :
> > > On 2/14/11 9:13 PM, Samuli Suominen wrote:
> > > > And http://bugs.gentoo.org/show_bug.cgi?id=349053#c1 ?   I tried to
> > > > provide a clue howto get usable p.keywords list easy.
> > > 
> > > IMHO it's in the middle. I still have to do a manual step, but at least
> > > it's pretty straightforward. Anyway, I think a list that can be blindly
> > > copy-pasted makes things even easier.
> > 
> > I don't think making a list for each arch is going to make anything any
> > easier for maintainers requesting stabilization, which means those list
> > we need more time to generate before being released. You just move the
> > problem to another place.
> 
> Why would you need to do that? Can't you just make a single list that 
> either has keywords for every arch or a ** ? Presumably every arch needs 
> a certain set of packages stable, and it doesn't matter if you 
> redundantly specify packages that are already stable.

Yes it does. I for one just use the list, compile and test all
the packages. If an entry is already stable, that effort is
wasted.

I think automatically generating per-arch lists and dumping them
on the bug is a nice way to do it. Having a "tabled list" for use
by the maintainer and then generating one comment per
arch-specific list seems like a good idea to me. Yes it is more
verbose on the bug, but that is a little price to pay, I'd say.

Regards,
Tobias

-- 
printk(KERN_ERR "msp3400: chip reset failed, penguin on i2c bus?\n");
        linux-2.2.16/drivers/char/msp3400.c

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 1979 bytes --]

On 14:17 Wed 16 Feb     , Tobias Klausmann wrote:
> Hi! 
> 
> On Tue, 15 Feb 2011, Donnie Berkholz wrote:
> > On 09:10 Tue 15 Feb, Gilles Dartiguelongue wrote:
> > > Le lundi 14 février 2011 à 19:19 +0100, "Paweł Hajdan, Jr." a écrit :
> > > > On 2/14/11 9:13 PM, Samuli Suominen wrote:
> > > > > And http://bugs.gentoo.org/show_bug.cgi?id=349053#c1 ?   I tried to
> > > > > provide a clue howto get usable p.keywords list easy.
> > > > 
> > > > IMHO it's in the middle. I still have to do a manual step, but at least
> > > > it's pretty straightforward. Anyway, I think a list that can be blindly
> > > > copy-pasted makes things even easier.
> > > 
> > > I don't think making a list for each arch is going to make anything any
> > > easier for maintainers requesting stabilization, which means those list
> > > we need more time to generate before being released. You just move the
> > > problem to another place.
> > 
> > Why would you need to do that? Can't you just make a single list that 
> > either has keywords for every arch or a ** ? Presumably every arch needs 
> > a certain set of packages stable, and it doesn't matter if you 
> > redundantly specify packages that are already stable.
> 
> Yes it does. I for one just use the list, compile and test all
> the packages. If an entry is already stable, that effort is
> wasted.
> 
> I think automatically generating per-arch lists and dumping them
> on the bug is a nice way to do it. Having a "tabled list" for use
> by the maintainer and then generating one comment per
> arch-specific list seems like a good idea to me. Yes it is more
> verbose on the bug, but that is a little price to pay, I'd say.

Is using autounmask an option instead? That generates a nice little file 
with everything that was actually unmasked, assuming it's a single 
dependency tree of packages.

-- 
Thanks,
Donnie

Donnie Berkholz
Sr. Developer, Gentoo Linux
Blog: http://dberkholz.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Jeroen Roovers]

On Wed, 16 Feb 2011 09:14:59 -0600
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> On 14:17 Wed 16 Feb     , Tobias Klausmann wrote:
> > I think automatically generating per-arch lists and dumping them
> > on the bug is a nice way to do it. Having a "tabled list" for use
> > by the maintainer and then generating one comment per
> > arch-specific list seems like a good idea to me. Yes it is more
> > verbose on the bug, but that is a little price to pay, I'd say.

+1 :)

> Is using autounmask an option instead? That generates a nice little
> file with everything that was actually unmasked, assuming it's a
> single dependency tree of packages.

autounmask takes ages on slow systems.


     jer

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

["Paweł Hajdan, Jr."]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On 2/15/11 9:10 AM, Gilles Dartiguelongue wrote:
> I don't think making a list for each arch is going to make anything any
> easier for maintainers requesting stabilization, which means those list
> we need more time to generate before being released. You just move the
> problem to another place.

I was expecting such argument. It's a good point, but please consider
the following:

- if the stabilization list has been created automatically, we should
adjust the tool to print in a format more suitable for the intended
audience (arch developers)

- if the stabilization list has been created manually, what prevents you
from doing it in a slightly different way? I think it doesn't change the
amount of work, and might even decrease it (no need for pretty tables)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Gilles Dartiguelongue]

For gnome it's semi-automated but it's still a matter of hours of work
to adjust, not even talking about the fact that we miss some
dependencies sometimes which means we have to upload the list multiple
times. Uploading 9 lists each time there is a modification will not make
the work of anyone clearer in the end.

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Matt Turner]

On Tue, Feb 15, 2011 at 8:10 AM, Gilles Dartiguelongue <eva@gentoo.org> wrote:
> I don't think making a list for each arch is going to make anything any
> easier for maintainers requesting stabilization, which means those list
> we need more time to generate before being released. You just move the
> problem to another place.

From my perspective, it should be more about making it easier for arch
teams to test the packages.

Lots of talk about what to do about "slacking arches". Well, maybe
just give them an easy list they can grep to get the packages they
need to test would help.

Seems like a fairly straight forward thing to do. A tool to automate
this process for the maintainers might be nice.

Matt

Re: [gentoo-dev] RFC: package.keywords-compatible snippets when stabilizing multiple packages

[Kacper Kowalik]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

W dniu 14.02.2011 18:52, "Paweł Hajdan, Jr." pisze:
> On 2/14/11 3:07 PM, Tomáš Chvátal wrote:
>> Same does x11 team...
>> Example:
>> http://bugs.gentoo.org/show_bug.cgi?id=354237
>>
>> I think this does not need any policy, most teams can use brains and
>> fill the bugs quite conveniently :)
> 
> Well, that's the entire point. For the bug you cited, and - for another
> example - http://bugs.gentoo.org/show_bug.cgi?id=353434 I can't just
> copy-paste something to my package.keywords file.
> 
> The table is indeed pretty, and it has value, but I'm just asking for a
> bit more convenience.

bugz attachment 262031 -v | grep ' ppc ' | awk '{print "="$1}' - >>
/mnt/ppc32/etc/portage/package.keywords

bugz attachment 262031 -v | grep ' ppc64 ' | awk '{print "="$1}' - >>
/mnt/ppc64/etc/portage/package.keywords

Erhm, how more convinient it can be?
Cheers,
Kacper


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 380 bytes --]