public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-libs/libproxy: ChangeLog libproxy-0.4.6.ebuild
       [not found] <20100929204311.4D54A20051@flycatcher.gentoo.org>
@ 2010-10-01 13:15 ` Peter Volkov
  2010-10-01 17:05   ` Arfrever Frehtes Taifersar Arahesis
  2010-10-01 17:49   ` Pacho Ramos
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Volkov @ 2010-10-01 13:15 UTC (permalink / raw
  To: gentoo-dev, pacho

В Срд, 29/09/2010 в 20:43 +0000, Pacho Ramos (pacho) пишет:
> pkg_setup() {
> 	if use python; then
> 		python_set_active_version 2
> 	fi

It's much shorter and clearer to write

use python && python_set_active_version 2

-- 
Peter.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-libs/libproxy: ChangeLog libproxy-0.4.6.ebuild
  2010-10-01 13:15 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-libs/libproxy: ChangeLog libproxy-0.4.6.ebuild Peter Volkov
@ 2010-10-01 17:05   ` Arfrever Frehtes Taifersar Arahesis
  2010-10-01 17:49   ` Pacho Ramos
  1 sibling, 0 replies; 3+ messages in thread
From: Arfrever Frehtes Taifersar Arahesis @ 2010-10-01 17:05 UTC (permalink / raw
  To: Gentoo Development

[-- Attachment #1: Type: Text/Plain, Size: 533 bytes --]

2010-10-01 15:15:56 Peter Volkov napisał(a):
> В Срд, 29/09/2010 в 20:43 +0000, Pacho Ramos (pacho) пишет:
> > pkg_setup() {
> > 	if use python; then
> > 		python_set_active_version 2
> > 	fi
> 
> It's much shorter and clearer to write
> 
> use python && python_set_active_version 2

Calling python_pkg_setup() is required in EAPI >=4, so I suggest:

pkg_setup() {
    if use python; then
        python_set_active_version 2
        python_pkg_setup
    fi
}

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-libs/libproxy: ChangeLog libproxy-0.4.6.ebuild
  2010-10-01 13:15 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-libs/libproxy: ChangeLog libproxy-0.4.6.ebuild Peter Volkov
  2010-10-01 17:05   ` Arfrever Frehtes Taifersar Arahesis
@ 2010-10-01 17:49   ` Pacho Ramos
  1 sibling, 0 replies; 3+ messages in thread
From: Pacho Ramos @ 2010-10-01 17:49 UTC (permalink / raw
  To: Peter Volkov; +Cc: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

El vie, 01-10-2010 a las 17:15 +0400, Peter Volkov escribió:
> В Срд, 29/09/2010 в 20:43 +0000, Pacho Ramos (pacho) пишет:
> > pkg_setup() {
> > 	if use python; then
> > 		python_set_active_version 2
> > 	fi
> 
> It's much shorter and clearer to write
> 
> use python && python_set_active_version 2
> 

Well, I didn't make that change:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-libs/libproxy/libproxy-0.4.2.ebuild?r1=1.1&r2=1.2

but ok, I am sure it will be useful anyway for other similar cases :-)

Best regards

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-01 17:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20100929204311.4D54A20051@flycatcher.gentoo.org>
2010-10-01 13:15 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-libs/libproxy: ChangeLog libproxy-0.4.6.ebuild Peter Volkov
2010-10-01 17:05   ` Arfrever Frehtes Taifersar Arahesis
2010-10-01 17:49   ` Pacho Ramos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox