From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-42599-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1OwJph-0000Xc-Js
	for garchives@archives.gentoo.org; Thu, 16 Sep 2010 19:09:29 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 2F814E0882
	for <garchives@archives.gentoo.org>; Thu, 16 Sep 2010 19:09:11 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id 1FEC1E07B5
	for <gentoo-dev@lists.gentoo.org>; Thu, 16 Sep 2010 18:34:21 +0000 (UTC)
Received: from [192.168.1.35] (unknown [94.158.169.15])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 150251B4098
	for <gentoo-dev@lists.gentoo.org>; Thu, 16 Sep 2010 18:34:19 +0000 (UTC)
Subject: Re: [gentoo-dev] RFC: fox.eclass update
From: Peter Volkov <pva@gentoo.org>
To: gentoo-dev@lists.gentoo.org
In-Reply-To: <4C922892.6040500@gentoo.org>
References: <4C921C29.6010502@gentoo.org>  <4C922892.6040500@gentoo.org>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 16 Sep 2010 22:32:29 +0400
Message-ID: <1284661949.14378.289.camel@tablet>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 7204c480-e6ae-4b39-8c1c-cb62b1b3da83
X-Archives-Hash: 9e6aa986cfb661c84c772458c3c7cdae

=D0=92 =D0=A7=D1=82=D0=B2, 16/09/2010 =D0=B2 16:24 +0200, Matti Bickel =D0=
=BF=D0=B8=D1=88=D0=B5=D1=82:
> +FOXVER=3D`get_version_component_range 1-2 ${FOX_PV}`

It's better to prefer $() style over ``:
http://mywiki.wooledge.org/BashFAQ/082

>  if [ "${PN}" !=3D fox ] ; then
>         FOX_COMPONENT=3D"${FOX_COMPONENT:-${PN}}"
>  fi
> =20
> -if [ "${FOXVER}" !=3D "1.0" ] && [ -z "${FOX_COMPONENT}" ] ; then
> +if [ -z "${FOX_COMPONENT}" ] ; then
>         DOXYGEN_DEP=3D"doc? ( app-doc/doxygen )"
>  fi

It's better to use [[ ]] and avoid quotes since ebuilds are bash
scripts.

> -       elibtoolize
> +       eautoreconf

Hm, is this change necessary?

> +       if ( ! use doc ) && [ -d "${D}/usr/share/doc/${PF}/html" ] ;
> then

Subshell looks redundant here.

> +               epause

It's better to avoid epause as it makes build slower at the same time
it's most probable that nobody is looking on the screen at the moment[1]
and portage will print all elog messages at the end of the build in any
case.
=20
[1] while emerge output is one of those things one can observe for ages
(like water, fire and others working) still it's possible no one
thoughtfully staring at the screen...

--=20
Peter.