[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

[Jeremy Olexa]

On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
Arahesis (arfrever)" <arfrever@gentoo.org> wrote:
> <snip>
> SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/${MY_P}.tar.gz"
> <snip>

This is a perfect example of "over-complexification" - Why didn't you
just use "D" instead of "${MY_PN:0:1}" ?

While technically not /wrong/ - it is harder to read for no gain. I'm
confident that our fellow devs can read this but I think we should all
strive for being more user-friendly.

Thanks,
Jeremy

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

[Peter Volkov]

В Втр, 03/08/2010 в 17:12 -0500, Jeremy Olexa пишет:
> On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
> Arahesis (arfrever)" <arfrever@gentoo.org> wrote:
> > <snip>
> > SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/${MY_P}.tar.gz"
> > <snip>
> 
> This is a perfect example of "over-complexification" - Why didn't you
> just use "D" instead of "${MY_PN:0:1}" ?

Just take a look at pypi.python.org repository structure. This URL can
be copy&pasted from one package into another package from the same
repository without any changes... 

-- 
Peter.

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

[Jeremy Olexa]

On 08/04/2010 03:05 AM, Peter Volkov wrote:
> В Втр, 03/08/2010 в 17:12 -0500, Jeremy Olexa пишет:
>> On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
>> Arahesis (arfrever)"<arfrever@gentoo.org>  wrote:
>>> <snip>
>>> SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/${MY_P}.tar.gz"
>>> <snip>
>>
>> This is a perfect example of "over-complexification" - Why didn't you
>> just use "D" instead of "${MY_PN:0:1}" ?
>
> Just take a look at pypi.python.org repository structure. This URL can
> be copy&pasted from one package into another package from the same
> repository without any changes...
>

You can't copy/paste MY_PN, so while you are changing that, is it that 
hard to change *one* more character? Of the 290 ebuilds that use pypi, 
172 of them use MY_PN. 83 use ${PN:0:1} for which your argument holds 
some water. As I said in the original message, I think we should strive 
for user friendly-ness but I guess I might be alone in that opinion. =/

-Jeremy

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 1386 bytes --]

On Wednesday, August 04, 2010 08:22:23 Jeremy Olexa wrote:
> On 08/04/2010 03:05 AM, Peter Volkov wrote:
> > В Втр, 03/08/2010 в 17:12 -0500, Jeremy Olexa пишет:
> >> On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
> >> 
> >> Arahesis (arfrever)"<arfrever@gentoo.org>  wrote:
> >>> <snip>
> >>> SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/$
> >>> {MY_P}.tar.gz" <snip>
> >> 
> >> This is a perfect example of "over-complexification" - Why didn't you
> >> just use "D" instead of "${MY_PN:0:1}" ?
> > 
> > Just take a look at pypi.python.org repository structure. This URL can
> > be copy&pasted from one package into another package from the same
> > repository without any changes...
> 
> You can't copy/paste MY_PN, so while you are changing that, is it that
> hard to change *one* more character? Of the 290 ebuilds that use pypi,
> 172 of them use MY_PN. 83 use ${PN:0:1} for which your argument holds
> some water. As I said in the original message, I think we should strive
> for user friendly-ness but I guess I might be alone in that opinion. =/

i'm inclined to agree with you in general, but not in this particular case.  
as the upstream repo is pretty well structured, and hosts many ebuild sources 
for us, i'd go with Peter as i'm a fan of ebuilds that work when simply 
renamed.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]