[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild

[Jeremy Olexa]

On Mon, 19 Jul 2010 20:24:40 +0000 (UTC), "Miroslav Sulc (fordfrog)"
<fordfrog@gentoo.org> wrote:
> fordfrog    10/07/19 20:24:40
> 
>   Modified:             ChangeLog netbeans-6.9-r3.ebuild
>   Log:
>   netbeans-6.9-r3: added support for including custom patches when
> building netbeans

> +	# Support for custom patches
> +	if [ -n "{NETBEANS_PATCHES_DIR}" -a -d "${NETBEANS_PATCHES_DIR}" ] ; then
> +		local files=`find "${NETBEANS_PATCHES_DIR}" -type f`
> +
> +		if [ -n "${files}" ] ; then
> +			einfo "Applying custom patches:"
> +
> +			for file in ${files} ; do
> +				epatch "${file}"
> +			done
> +		fi
> +	fi
> +

Miroslav, You just reinvented the wheel :) Any reason why epatch_user()
from euitls.eclass doesn't work here?
-Jeremy

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild

["Miroslav Šulc (fordfrog)"]

 Dne 21.7.2010 16:35, Jeremy Olexa napsal(a):
> On Mon, 19 Jul 2010 20:24:40 +0000 (UTC), "Miroslav Sulc (fordfrog)"
> <fordfrog@gentoo.org> wrote:
>> fordfrog    10/07/19 20:24:40
>>
>>   Modified:             ChangeLog netbeans-6.9-r3.ebuild
>>   Log:
>>   netbeans-6.9-r3: added support for including custom patches when
>> building netbeans
>> +	# Support for custom patches
>> +	if [ -n "{NETBEANS_PATCHES_DIR}" -a -d "${NETBEANS_PATCHES_DIR}" ] ; then
>> +		local files=`find "${NETBEANS_PATCHES_DIR}" -type f`
>> +
>> +		if [ -n "${files}" ] ; then
>> +			einfo "Applying custom patches:"
>> +
>> +			for file in ${files} ; do
>> +				epatch "${file}"
>> +			done
>> +		fi
>> +	fi
>> +
> Miroslav, You just reinvented the wheel :) Any reason why epatch_user()
> from euitls.eclass doesn't work here?
> -Jeremy
y, i did not expect this function to exist, i only recall that i saw
some custom code for applying patches in some other ebuild few years
back when i needed to tweak some package, so did it the same way.

so this is called automatically for
/etc/portage/patches/<category>/(PF|P|PN) if i read the code right? i
also tried to search man pages for portage and emerge but there is
nothing about it (or i am blind) ... so this is undocumented feature? i
did not know about this cool feature till now.

m.

Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild

[Peter Volkov]

В Срд, 21/07/2010 в 17:18 +0200, "Miroslav Šulc (fordfrog)" пишет:

> > epatch_user() from euitls.eclass

> so this is undocumented feature? i did not know about this cool
> feature till now.

It's undocumented since it's better to avoid this feature in ebuilds
because this hack makes impossible to know what patches user have and
why package fails the way it fails. So better drop this code. If user
wants some useful patch {s}he should open the bug or use overlay.

epatch_user() was created for rare cases where package requires random
third-party patches for additional functionality that is impossible to
maintain in the tree. Good example is iptables: it has tons of
third-party patches. This patches are released days/months after
iptables release and even skip some iptables releases, don't have
upstream and thus making impossible to maintain them in the tree.

In general I think this is problem with our tools - we need some way to
apply custom patches and make emerge --info pkg could give us all
information about that custom patches... But until such or similar
solution implemented, please, avoid epatch_user() in the tree.

CC'ing QA: guys, I think this is your domain so in case you have any
comments here, please, do :)

-- 
Peter.

Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild

["Miroslav Šulc (fordfrog)"]

 Dne 22.7.2010 10:44, Peter Volkov napsal(a):
> В Срд, 21/07/2010 в 17:18 +0200, "Miroslav Šulc (fordfrog)" пишет:
>
>>> epatch_user() from euitls.eclass
>> so this is undocumented feature? i did not know about this cool
>> feature till now.
> It's undocumented since it's better to avoid this feature in ebuilds
> because this hack makes impossible to know what patches user have and
> why package fails the way it fails. So better drop this code. If user
> wants some useful patch {s}he should open the bug or use overlay.
well, problem is that some patches simply cannot make it to offficial
sources nor our ebuilds. i have patch for netbeans that automatically
adds custom javadocs to getters and setters, final keywords to method
arguments etc. this really improves my efficiency when coding in
netbeans as it saves me a lot of keystrokes, but the scope of usability
of the patches is really small as i do not have time nor knowledge to
make this configurable through netbeans options and thus appliable at
the ebuild level or at the upstream source level. so from my point of
view epatch_user is a must unless i want to each time interfere emerge
of netbeans which i definitely do not want to.
> ...

Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild

[Peter Volkov]

В Чтв, 22/07/2010 в 14:32 +0200, "Miroslav Šulc (fordfrog)" пишет:
> Dne 22.7.2010 10:44, Peter Volkov napsal(a):
> > В Срд, 21/07/2010 в 17:18 +0200, "Miroslav Šulc (fordfrog)" пишет:

> >>> epatch_user() from euitls.eclass

> >> so this is undocumented feature? i did not know about this cool
> >> feature till now.

> > It's undocumented since it's better to avoid this feature in ebuilds

> well, problem is that some patches simply cannot make it to offficial
> sources nor our ebuilds. 

Then either use overlay or, for personal needs, it's not hard to patch
sources using bashrc. Completely no need for epatch_user().

-- 
Peter.

Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 884 bytes --]

On Thursday, July 22, 2010 09:19:35 Peter Volkov wrote:
> В Чтв, 22/07/2010 в 14:32 +0200, "Miroslav Šulc (fordfrog)" пишет:
> > Dne 22.7.2010 10:44, Peter Volkov napsal(a):
> > > В Срд, 21/07/2010 в 17:18 +0200, "Miroslav Šulc (fordfrog)" пишет:
> > >>> epatch_user() from euitls.eclass
> > >> 
> > >> so this is undocumented feature? i did not know about this cool
> > >> feature till now.
> > > 
> > > It's undocumented since it's better to avoid this feature in ebuilds
> > 
> > well, problem is that some patches simply cannot make it to offficial
> > sources nor our ebuilds.
> 
> Then either use overlay or, for personal needs, it's not hard to patch
> sources using bashrc. Completely no need for epatch_user().

it's at the maintainer's discretion, so if Miroslav wants it and he's the 
maintainer, then he's free to do so ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]