From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1ObrQ0-0006mE-0k for garchives@archives.gentoo.org; Thu, 22 Jul 2010 08:46:16 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9F166E08C4; Thu, 22 Jul 2010 08:46:10 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 01964E08F5 for ; Thu, 22 Jul 2010 08:45:49 +0000 (UTC) Received: from [192.168.1.35] (unknown [94.158.169.15]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPSA id 717D91B412A; Thu, 22 Jul 2010 08:45:42 +0000 (UTC) Subject: Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild From: Peter Volkov To: gentoo-dev@lists.gentoo.org Cc: qa@gentoo.org In-Reply-To: <4C470FC1.1060503@gentoo.org> References: <20100719202440.76AB22CF39@corvid.gentoo.org> <4C470FC1.1060503@gentoo.org> Content-Type: text/plain; charset="UTF-8" Date: Thu, 22 Jul 2010 12:44:21 +0400 Message-ID: <1279788261.6915.45.camel@tablet> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: fe5e68fb-f7ad-4ad8-9d30-3cdfe5dcf01a X-Archives-Hash: f9b3ef8d78549ef13f73f2a8600f080d =D0=92 =D0=A1=D1=80=D0=B4, 21/07/2010 =D0=B2 17:18 +0200, "Miroslav =C5=A0= ulc (fordfrog)" =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > epatch_user() from euitls.eclass > so this is undocumented feature? i did not know about this cool > feature till now. It's undocumented since it's better to avoid this feature in ebuilds because this hack makes impossible to know what patches user have and why package fails the way it fails. So better drop this code. If user wants some useful patch {s}he should open the bug or use overlay. epatch_user() was created for rare cases where package requires random third-party patches for additional functionality that is impossible to maintain in the tree. Good example is iptables: it has tons of third-party patches. This patches are released days/months after iptables release and even skip some iptables releases, don't have upstream and thus making impossible to maintain them in the tree. In general I think this is problem with our tools - we need some way to apply custom patches and make emerge --info pkg could give us all information about that custom patches... But until such or similar solution implemented, please, avoid epatch_user() in the tree. CC'ing QA: guys, I think this is your domain so in case you have any comments here, please, do :) --=20 Peter.