From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OF1CR-0000M3-V5 for garchives@archives.gentoo.org; Thu, 20 May 2010 08:33:52 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7AE18E0C09; Thu, 20 May 2010 13:33:45 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id C8FBFE0BF7; Thu, 20 May 2010 13:33:27 +0000 (UTC) Received: from [192.168.1.35] (unknown [94.158.169.0]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id DBE721B405F; Thu, 20 May 2010 13:33:25 +0000 (UTC) Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-admin/tripwire: ChangeLog tripwire-2.4.2.ebuild tripwire-2.4.1.2.ebuild From: Peter Volkov To: gentoo-dev@lists.gentoo.org, patrick@gentoo.org Cc: gentoo-commits@lists.gentoo.org In-Reply-To: <20100517184156.42F952C5F5@corvid.gentoo.org> References: <20100517184156.42F952C5F5@corvid.gentoo.org> Content-Type: text/plain; charset="UTF-8" Date: Thu, 20 May 2010 17:32:14 +0400 Message-ID: <1274362335.2688.22.camel@tablet> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.28.3.1 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 12c04400-8301-4e74-abb8-cbc7d2ce6741 X-Archives-Hash: 93c9de3f6ed6d184ea906a01755b71be Hi. Guys, please, cleanup ebuids with version bumps! Also Patrick, if you use this software or at least investigated it during version bump, why it is still maintainer-wanted? Although everything below makes me think that this was blind bump. =D0=92 =D0=9F=D0=BD=D0=B4, 17/05/2010 =D0=B2 18:41 +0000, Patrick Lauer (= patrick) =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > inherit eutils flag-o-matic autotools >=20 > TW_VER=3D${PV} This substitution is unnecessary and tripwire-${TW_VER} everywhere below is just ${P}. > DESCRIPTION=3D"Open Source File Integrity Checker and IDS" > HOMEPAGE=3D"http://www.tripwire.org/" > SRC_URI=3D"mirror://sourceforge/tripwire/tripwire-${TW_VER}-src.tar.bz2 > mirror://gentoo/twpol.txt.gz > mirror://gentoo/tripwire.gif" >=20 > LICENSE=3D"GPL-2" > SLOT=3D"0" > KEYWORDS=3D"~amd64 ~ppc ~x86 ~x86-fbsd" > IUSE=3D"ssl static" >=20 > DEPEND=3D"sys-devel/automake > sys-devel/autoconf This depends ^^ should be handled by autotools eclass. > dev-util/patchutils > ssl? ( dev-libs/openssl )" > RDEPEND=3D"virtual/cron > virtual/mta > ssl? ( dev-libs/openssl )" >=20 > S=3D"${WORKDIR}"/tripwire-${TW_VER}-src >=20 > src_prepare() { > eautoreconf || die "eautoreconf failed" || die is not necessary here. Is autoreconf really required (nothing changed configure.ac/Makefile.am here). > } >=20 > src_configure() { > # tripwire can be sensitive to compiler optimisation. > # see #32613, #45823, and others. > # -taviso@gentoo.org This developer was retired 2.5 years ago. Why do we need this comment? > strip-flags > append-flags -DCONFIG_DIR=3D'"\"/etc/tripwire\""' -fno-strict-aliasing > einfo "Done." What is "Done." here? > chmod +x configure > econf $(use_enable ssl openssl) $(use_enable static) > } >=20 > src_install() { > dosbin "${S}"/bin/{siggen,tripwire,twadmin,twprint} Again || die should be here and in many other places ... > doman "${S}"/man/man{4/*.4,5/*.5,8/*.8} > dodir /etc/tripwire /var/lib/tripwire{,/report} > keepdir /var/lib/tripwire{,/report} >=20 > exeinto /etc/cron.daily > doexe "${FILESDIR}"/tripwire.cron >=20 > dodoc ChangeLog policy/policyguide.txt TRADEMARK \ > "${FILESDIR}"/tripwire.txt >=20 > insinto /etc/tripwire > doins "${WORKDIR}"/twpol.txt "${FILESDIR}"/twcfg.txt >=20 > exeinto /etc/tripwire > doexe "${FILESDIR}"/twinstall.sh >=20 > fperms 755 /etc/tripwire/twinstall.sh /etc/cron.daily/tripwire.cron > } >=20 > pkg_postinst() { > elog "After installing this package, you should run \"/etc/tripwire/tw= install.sh\"" > elog "to generate cryptographic keys, and \"tripwire --init\" to initi= alize the" > elog "database Tripwire uses." > elog > elog "A quickstart guide is included with the documentation." > elog > } --=20 Peter.