From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 448F7158020 for ; Fri, 9 Dec 2022 11:13:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0FD59E08BB; Fri, 9 Dec 2022 11:13:34 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C40A5E088C for ; Fri, 9 Dec 2022 11:13:33 +0000 (UTC) Message-ID: <12711c85be3ccdee3d8b243b32a4238d13591508.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/2] acct-group.eclass: Don't modify groups when EPREFIX is non-empty From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Date: Fri, 09 Dec 2022 11:13:12 +0000 In-Reply-To: References: <20221208212854.3825-1-chewi@gentoo.org> <20221208212854.3825-2-chewi@gentoo.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-1GDUYW7e9bC0MiC+WWTn" User-Agent: Evolution 3.44.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 05877f56-89b2-4095-bceb-3a9ebd3b668c X-Archives-Hash: 00ec21a9cd0f5d652c88468b770dd8da --=-1GDUYW7e9bC0MiC+WWTn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2022-12-09 at 05:23 +0100, Micha=C5=82 G=C3=B3rny wrote: > On Thu, 2022-12-08 at 21:28 +0000, James Le Cuirot wrote: > > This was happening when running a prefix as root, which we don't really > > support, but also when building a prefixed system under ROOT. > >=20 > > Closes: https://bugs.gentoo.org/779181 > > Signed-off-by: James Le Cuirot > > --- > > eclass/acct-group.eclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/eclass/acct-group.eclass b/eclass/acct-group.eclass > > index 590a2f20ed8e..f55c9f4c9587 100644 > > --- a/eclass/acct-group.eclass > > +++ b/eclass/acct-group.eclass > > @@ -157,7 +157,7 @@ acct-group_src_install() { > > acct-group_pkg_preinst() { > > debug-print-function ${FUNCNAME} "${@}" > > =20 > > - if [[ ${EUID} -ne 0 ]]; then > > + if [[ ${EUID} -ne 0 || -n ${EPREFIX} ]]; then > > einfo "Insufficient privileges to execute ${FUNCNAME[0]}" > > return > > fi >=20 > I dare say the message is not necessarily correct here but I suppose it > doesn't matter that much. Yeah, I thought that too, but not enough for such a corner case. --=-1GDUYW7e9bC0MiC+WWTn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJFBAABCAAvFiEEPxcZ3tkwcedKm2a8EiZBXQDdMTcFAmOTGEgRHGNoZXdpQGdl bnRvby5vcmcACgkQEiZBXQDdMTfv3g/8Dfe4hHBpKk/8oQ7/Vr3uFKva4JHA6bUy h4Kdf31KdPM2Thwd0N4JqnZ6OFwTcTq0viqS00nzGR5BoJG9QWBFk1ZbXqkrfdup gRpg8Wu7xDfAlC8w/R96Rp80y4q5oJx9z+ZZEQMy5jCJ9DRJBHEES086fiyQiQgq OYESjVa5YQQk7peDCWRoFUZ4Xu14zpMeYnlA4XnufuoBG0evq+hDIswnBHX0mcJP CXoE4KvCCEPzK25UfUi0wSQYTlB68not9JMcQU9iUR7I/51WUi5mrW9zN5Vtu+b6 +86KMMGmZt7nsOi6deF0hnmAKOn43AVdA7i7pgH5ei7BufH2pmFpjiKVCTJHVmZj Rj5Epxfe5xijn0Bl1UYGjFXO2dUXI1xTWK21FMqRVWe2L83Y1LXCn0ouG0Yxk1js owUVUjVlmJV+fNX3wwHOGIDnI5K4eMAeOLo8QdLfliRpJRVfrI1LMthcVCm/mZuN c1O7uUxGXIU1TQzHs0iox/hnK76c1pW0pqWtoY000uPDASzXP/EUJaeDVD+qFGwq 6Jqma+f1FlBGpRuU9NPbhpbUS05EzlDu9Eo2LaefxwIxWPMkpB9WNmpHekL0lTuI p36CLNy8a0h3LWnbboHeLKPWsJbC903GAYYiSJSvE+sVXgeXOWUbpj58Pj2cmUpO 70JQa6+wwkI= =2mh9 -----END PGP SIGNATURE----- --=-1GDUYW7e9bC0MiC+WWTn--