public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Peter Volkov <pva@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: fonts@gentoo.org, scarabeus@gentoo.org
Subject: Re: [gentoo-dev] Re: [RFC] Font eclass EAPI update and design
Date: Mon, 01 Feb 2010 21:53:20 +0300	[thread overview]
Message-ID: <1265050400.10636.64.camel@tablet> (raw)
In-Reply-To: <4B66D72F.3060303@gentoo.org>

В Пнд, 01/02/2010 в 14:29 +0100, Tomáš Chvátal пишет:
> > 2.
> > if has X ${IUSE//+} && use X ; then
> > 
> > I'm not sure. With this change should we update all packages depending
> > on font.eclass to have X in IUSE?
> Nak this specialy allows that you dont have to keep X in iuse.
> But it does not matter anyway because it is and was always defined by
> eclass. But with this syntax it allows us to remove that IUSE="X" from
> eclass global scope at some point.

Do we have such goal? Where this is useful?

> > 4.
> > +       [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation
> > failed" ; }
> > 
> > This should be non fatal, until somebody installs all packages that
> > inherit font.eclass and assures us that nothing broke with this change.

> Actualy former behaviour was violating QA rules for dodoc, so it should
> be fixed anyway.

And yet we have more strong policy that states "not to break the tree".
Since previous version of eclass issued no warning about missed
documentation, it's highly probable that lot's of font packages will
fail to emerge after this change (we already had one report, while
eclass is in x11 overlay only)... So this is no go, until somebody
checks that no package (at least in stable tree) became broken by this
change.

-- 
Peter.




  reply	other threads:[~2010-02-01 18:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 10:35 [gentoo-dev] [RFC] Font eclass EAPI update and design Tomáš Chvátal
2010-02-01 13:14 ` [gentoo-dev] " Peter Volkov
2010-02-01 13:29   ` Tomáš Chvátal
2010-02-01 18:53     ` Peter Volkov [this message]
2010-02-01 22:26     ` Ryan Hill
2010-02-02 10:18 ` Torsten Veller
2010-02-02 10:30   ` Tomáš Chvátal
2010-02-02 10:50   ` Fabian Groffen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265050400.10636.64.camel@tablet \
    --to=pva@gentoo.org \
    --cc=fonts@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=scarabeus@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox