From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Nbw7d-00066o-HM for garchives@archives.gentoo.org; Mon, 01 Feb 2010 13:15:21 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C59BDE0897; Mon, 1 Feb 2010 13:15:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 74231E0882 for ; Mon, 1 Feb 2010 13:14:52 +0000 (UTC) Received: from [192.168.1.35] (unknown [77.246.104.171]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id BAC9C1B4079; Mon, 1 Feb 2010 13:14:49 +0000 (UTC) Subject: [gentoo-dev] Re: [RFC] Font eclass EAPI update and design From: Peter Volkov To: =?UTF-8?Q?Tom=C3=A1=C5=A1_Chv=C3=A1tal?= Cc: gentoo-dev@lists.gentoo.org, fonts@gentoo.org In-Reply-To: <4B66AE86.9090006@gentoo.org> References: <4B66AE86.9090006@gentoo.org> Content-Type: text/plain; charset="UTF-8" Date: Mon, 01 Feb 2010 16:14:41 +0300 Message-ID: <1265030081.10636.23.camel@tablet> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: dd31f528-b813-4cdf-a8c7-93901efb8b2c X-Archives-Hash: 8e7c573fd5fc71990ccf69feee49332a =D0=92 =D0=9F=D0=BD=D0=B4, 01/02/2010 =D0=B2 11:35 +0100, Tom=C3=A1=C5=A1= Chv=C3=A1tal =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > As I was reworking the x-modular-r2 eclass I found out that most of the > slowdowns for fonts were produced in fonts eclass. Exactly what slowdowns are you talking about? I've reviewed all changes and I don't see any noticeable performance improvements anywhere. Or what do you mean? > I would like to ask you to review the changes and spot anything that > might slipped my sight. 1. -FONT_SUFFIX=3D${FONT_SUFFIX:-} +: ${FONT_SUFFIX:=3D} What are the benefits of this change? Personally I prefer first syntax more since it's more evident and does not need to run empty command : 2. if has X ${IUSE//+} && use X ; then I'm not sure. With this change should we update all packages depending on font.eclass to have X in IUSE? 3. If you dropped if has_version '>=3Dmedia-libs/fontconfig-2.4'; then then >=3Dmedia-libs/fontconfig-2.4 should be in DEPEND. 4. + [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation failed" ; } This should be non fatal, until somebody installs all packages that inherit font.eclass and assures us that nothing broke with this change. --=20 Peter. h