From: Alex Legler <a3li@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: gems.eclass review
Date: Thu, 12 Mar 2009 21:02:22 +0100 [thread overview]
Message-ID: <1236888142.13104.6.camel@localhost> (raw)
In-Reply-To: <20090306210351.5d724c2f@halo.dirtyepic.sk.ca>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Fr, 2009-03-06 at 21:03 -0600, Ryan Hill wrote:
> In the case that USE_RUBY is set to something funky, it never gets handled. The eclass
> basically just does nothing. This might be what you want, but if not, how about something
> like:
>
Actually, this is what we want. ;)
I noticed after I sent the eclass for review, that USE_RUBY="any" should
not be used anymore. So I added a deprecation notice and will get rid of
it in a month or so.
> > + dodir ${GEMSDIR}
>
> || die
>
Added the two die's, thanks.
I also added eclass-manpages-style documentation and empty EAPI-2
functions to make pva happy. :p
I am going to wait another couple of days before comitting if anyone
should have more comments. Updated the old URLs with the new changes:
http://dev.gentoo.org/~a3li/ruby/gems.eclass.txt
http://dev.gentoo.org/~a3li/ruby/gems.eclass.diff
Thanks,
Alex
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-03-12 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 16:47 [gentoo-dev] gems.eclass review Alex Legler
2009-03-07 3:03 ` [gentoo-dev] " Ryan Hill
2009-03-12 20:02 ` Alex Legler [this message]
2009-03-14 18:02 ` Peter Volkov
2009-03-14 18:53 ` Ciaran McCreesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236888142.13104.6.camel@localhost \
--to=a3li@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox