From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
by finch.gentoo.org with esmtp (Exim 4.60)
(envelope-from <gentoo-dev+bounces-34380-garchives=archives.gentoo.org@lists.gentoo.org>)
id 1La4wR-000305-Q6
for garchives@archives.gentoo.org; Thu, 19 Feb 2009 09:11:36 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id BFE93E02E3;
Thu, 19 Feb 2009 09:11:34 +0000 (UTC)
Received: from smtp.tmcs.ch (unknown [213.131.245.113])
by pigeon.gentoo.org (Postfix) with ESMTP id 7BAEFE02E3
for <gentoo-dev@lists.gentoo.org>; Thu, 19 Feb 2009 09:11:34 +0000 (UTC)
Received: from [192.168.168.149] (unknown [212.126.163.234])
(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
(No client certificate requested)
by smtp.tmcs.ch (Postfix) with ESMTPSA id 55777165B38D
for <gentoo-dev@lists.gentoo.org>; Thu, 19 Feb 2009 10:11:33 +0100 (CET)
Subject: Re: [gentoo-dev] prepalldocs implementation in eutils.eclass (was:
prepalldocs is now banned)
From: Tiziano =?ISO-8859-1?Q?M=FCller?= <dev-zero@gentoo.org>
To: gentoo-dev@lists.gentoo.org
In-Reply-To: <9d2010770902180022yaf1d202xa75541eec7299b81@mail.gmail.com>
References: <20090213213017.GA3452@dodo.hsd1.nj.comcast.net>
<9d2010770902180007w4b2e8742y25af752e042abdd0@mail.gmail.com>
<20090218090803.TAf7b2c.tv@veller.net>
<9d2010770902180022yaf1d202xa75541eec7299b81@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-AmHLzrrO16UhO8O3Wc5g"
Organization: Gentoo
Date: Thu, 19 Feb 2009 10:11:32 +0100
Message-Id: <1235034692.23302.14.camel@localhost>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
X-Mailer: Evolution 2.24.4
X-Archives-Salt: 90fdb1b8-dc59-43c0-bfc7-11b545e59f69
X-Archives-Hash: 54947b8e43f64416d4bb6e4443f6171c
--=-AmHLzrrO16UhO8O3Wc5g
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Am Mittwoch, den 18.02.2009, 03:22 -0500 schrieb Michael Sterrett:
> Patches welcome.
>=20
> On Wed, Feb 18, 2009 at 3:13 AM, Torsten Veller <ml-en@veller.net> wrote:
> > * Michael Sterrett <mr_bones_@gentoo.org>:
> >> I added a prepalldocs function to eutils.eclass to provide the
> >> functionality. It implements the
> >> behavior of the current stable sys-apps/portage-2.1.6.4.
> >
> > ecompressdir is more portage internal than prepalldocs ever was.
> > This must be fixed.
> >
> >
Instead of breaking things you could have tried to come up with a real
solution.
Even though I share the opinion that compressing docs is unnecessary I
started looking through the use cases.
I'm not done yet, but I think I already identified a couple of common
cases:
[1]
src_install() {
emake DESTDIR=3D"${D}" docdir=3D"/usr/share/doc/${PF}"
prepalldocs
}
(or similar)
will change to:
src_install() {
emake DESTDIR=3D"${D}" docdir=3D"${T}/doc"
dodoc "${T}/doc"
}
[2]
Not needed at all since every doc gets installed using dodoc or newdoc
[3]
Package installs doc to wrong location.
Solution: dodoc <OLDLOCATION>/* ; rm -rf <OLDLOCATION>
[4]
Assuming that "make install" installs something in /usr/share/doc/${PF}.
Assumption is wrong since "make install" will install
to /usr/share/doc/${P} if at all (since the package doesn't know
anything about -rX). So it should be changed anyway and then case [1] or
[3] applies.
Example packages for case [1]: app-arch/gtk-splitter, app-cdr/cdcover,
app-crypt/steghide, app-editors/lpe, app-emacs/ess
Example packages for case [2]: app-arch/rar, app-backup/amanda
Example packages for case [3]: app-crypt/gnupg
Example packages for case [4]: app-arch/xdms, app-crypt/gnupg-pkcs11-scd
The only problem I see here is that either <OLDLOCATION> or ${T}/doc
contains subdirs. So my proposal for the next EAPI is to allow dodoc and
newdoc to operate on dirs. Which also gives the benefit to reduce this
idiom:
insinto /usr/share/doc/${PF}
doins -r examples
to:
dodoc examples
Your comments?
Cheers,
Tiziano=20
--=20
=EF=BB=BF-------------------------------------------------------
Tiziano M=C3=BCller
Gentoo Linux Developer, Council Member
Areas of responsibility:
Samba, PostgreSQL, CPP, Python, sysadmin
E-Mail : dev-zero@gentoo.org
GnuPG FP : F327 283A E769 2E36 18D5 4DE2 1B05 6A63 AE9C 1E30
--=-AmHLzrrO16UhO8O3Wc5g
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Dies ist ein digital signierter Nachrichtenteil
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
iEYEABECAAYFAkmdIkQACgkQGwVqY66cHjCZFgCggG6sGo1jAmHN3NAVHE1a1xnC
vgoAn3FvxBK7iVMd0PRTv+gWw8mT04ui
=7OCn
-----END PGP SIGNATURE-----
--=-AmHLzrrO16UhO8O3Wc5g--