From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LUsFW-0006yF-E1 for garchives@archives.gentoo.org; Thu, 05 Feb 2009 00:37:46 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 496C0E06AF; Thu, 5 Feb 2009 00:37:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 0912FE06AF for ; Thu, 5 Feb 2009 00:37:11 +0000 (UTC) Received: from [10.0.0.8] (bl9-97-140.dsl.telepac.pt [85.242.97.140]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id B7F336439E; Thu, 5 Feb 2009 00:37:09 +0000 (UTC) Subject: Re: [gentoo-dev] Announcement of The G Palmtop Environment ebuilds From: Angelo Arrifano To: gentoo-dev@lists.gentoo.org Cc: betelgeuse@gentoo.org In-Reply-To: <4989C3FF.2040801@gentoo.org> References: <1233675279.6250.95.camel@localhost> <4989827F.3000907@gentoo.org> <1233756207.22368.29.camel@localhost> <4989C3FF.2040801@gentoo.org> Content-Type: text/plain; charset=utf-8 Organization: Gentoo Linux ARM/OMAP850 Developer Date: Thu, 05 Feb 2009 00:37:57 +0000 Message-Id: <1233794277.22368.57.camel@localhost> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 70bfb043-fbc4-4ad0-8b0b-347e96d11f7f X-Archives-Hash: d50eef2e40f0dfbb2054703d2376c77a On Qua, 2009-02-04 at 18:36 +0200, Petteri R=C3=A4ty wrote: > Angelo Arrifano wrote: > >=20 > > # Copyright 2008 Gentoo Foundation > > # Distributed under the terms of the GNU General Public License v2 > > # $Header: $ > > # > > # Authors: > > # Rene Wagner > > # Ned Ludd > > # Angelo Arrifano > >=20 >=20 > Should use eclass-manpages syntax. Thanks, fixed on next revision >=20 > >=20 > > # GPE ECLASS > > #GPECONF=3D"" # extra configure opts passed to econf > > ELTCONF=3D"" # extra options passed to elibtoolize > > DOCS=3D"" # documentation files to be installed with = dodoc > >=20 >=20 > If other eclass that comes before in the inherit hierarchy and sets > DOCS, do we want to override it? Yes, we want. If we will make dodoc die by default like you proposed below, DOCS must be explicitly set by each ebuild sourcing any common DOC provided by the eclass. >=20 > > [ -z "${GPE_MIRROR}" ] && export GPE_MIRROR=3D"http://gpe.linuxtogo.o= rg/download/source" > >=20 > > [ -z "${GPE_TARBALL_SUFFIX}" ] && export GPE_TARBALL_SUFFIX=3D"gz" > >=20 >=20 > Is there a binary called that makes use of those two? Yes, some packages uses bz2 but most of them gz. Ebuilds fetching bz2 from the default URI will use both. >=20 > >=20 > > IUSE=3D"${IUSE} nls" > > >=20 > This is the first use of IUSE in the eclass so there is nothing to > append to. True, fixed on next revision. >=20 > >=20 > > gpe_src_configure() { > > tc-export CC > > if [ -f configure ]; then > > elibtoolize ${ELTCONF} > > econf "$@" ${GPECONF} || die "./configure failure" > > fi > > } > >=20 >=20 > Ebuilds/Eclasses should use [[ instead of [ and econf dies on it's own > any way. Fixed on next revision. >=20 >=20 > > gpe_src_install() { > > USE_NLS=3Dyes > > use nls || USE_NLS=3Dno > >=20 >=20 > I don't see USE_NLS used outside install so it should be local and > written in lower case. This is an ancient issue where almost (but not all) packages provides an --enable-nls flag. I'll discuss with solar about the usefulness of this code. Thanks. >=20 > > if [ -f configure ]; then > > einstall "$@" > > else >=20 > If you really need to use einstall, it would be best to add a comment > about why it's needed. Some packages are not automake driven. We have to detect those. >=20 > > make DESTDIR=3D${D} PREFIX=3D/usr \ > > STRIP=3Dtrue ENABLE_NLS=3D${USE_NLS} \ > > "$@" install > > fi > >=20 >=20 > Should use emake. Stripping should be left to the package manager. Stripping is problematic when cross-compiling. I'll do some more tests to figure out the best way. Although, we are doing this for a long time now and it works. IMHO, changing things in the last "hour" usually leads to breakage. >=20 > > # manual document installation > > [ -n "${DOCS}" ] && dodoc ${DOCS} > >=20 > > } > >=20 >=20 > dodoc should have || die with it There are some ebuilds that don't provide all the DOCS, I'll try to fix the ebuilds first and then we'll see.. >=20 > > > > EXPORT_FUNCTIONS src_compile src_install src_unpack > >=20 >=20 > Never exports configure for EAPI 2. Already fixed, thanks to loki_val for his patch. >=20 > Regards, > Petteri >=20 >=20 >=20 Thank you, --=20 Angelo Arrifano Gentoo Linux ARM/OMAP850 Developer