From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-33948-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1LK7vW-0003A8-9d
	for garchives@archives.gentoo.org; Tue, 06 Jan 2009 09:08:43 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 38387E0667;
	Tue,  6 Jan 2009 09:08:39 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id AB8DDE0667
	for <gentoo-dev@lists.gentoo.org>; Tue,  6 Jan 2009 09:08:38 +0000 (UTC)
Received: from [192.168.1.33] (unknown [77.246.104.171])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTP id 53FD36570C
	for <gentoo-dev@lists.gentoo.org>; Tue,  6 Jan 2009 09:08:35 +0000 (UTC)
Subject: Re: [gentoo-dev] Re: gentoo-x86 commit in app-forensics/memdump:
 memdump-1.0.1.ebuild ChangeLog
From: Peter Volkov <pva@gentoo.org>
To: gentoo-dev@lists.gentoo.org
In-Reply-To: <8b4c83ad0901050025k2356e1e4nbf40ea3fe86b7a57@mail.gmail.com>
References: <E1LJcf9-00025P-UZ@stork.gentoo.org>
	 <20090105010331.TA8dca0.tv@veller.net>
	 <8b4c83ad0901050025k2356e1e4nbf40ea3fe86b7a57@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 06 Jan 2009 12:08:25 +0300
Message-Id: <1231232905.5292.74.camel@localhost>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
X-Mailer: Evolution 2.24.2 
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: b189145b-3256-4ea4-8e36-fd9d0fcfd417
X-Archives-Hash: b7e6b53052fbe82ef65cb61c8dfa1f84


Daniel, answering you in this mail... Yes, probably sometimes we have to
discuss basic things in this mailing list but since developers do this
basic errors we have to. Technical problems in our portage tree are
perfectly valid for this mailing list.

=D0=92 =D0=9F=D0=BD=D0=B4, 05/01/2009 =D0=B2 13:55 +0530, Nirbheek Chauha=
n =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >> SRC_URI=3D"http://www.porcupine.org/forensics/${PN}-1.01.tar.gz"    =
                                                ~~~~
>=20
> Missing MY_PV I presume?

Hardcoded version makes version bumps harder. I'm not sure why ebuild
was versioned differently from tarbal but yes, in this case it's better
to use versionator eclass define PV.

> >> RDEPEND=3D"virtual/libc"
> >  ^^^^^^^^^^^^^^^^^^^^^^
>=20
> Useless deps which are already in @system?

Dependency on libc is completely useless since every usable system have
C library.

> >> S=3D${WORKDIR}/${PN}-1.01
> >                     ~~~~
>=20
> Quotes and ${MY_PV} missing?

You don't need quotes in assignments. It hardcoded version again.

> >> src_compile() {
> >>       cd ${S}/memdump-1.01
> >          "    "        ~~~~
>=20
> Quotes, and ${PN}-${MY_PV} ?
> Although, should this even be required since ${S} is already set correc=
tly?

src_compile initial working directory is S so this line could (and
should) be just dropped.

> >>               einfo "testing"
> >>               if [ "`./memdump -s 344 | wc -c`" =3D "344" ];
> >>               then
> >>                       einfo "passed test"
> >>               else
> >>                       die "failed test"
> >>               fi
>=20
> Here, why not use
>=20
> einfo "testing"
> [ "`./memdump -s 344 | wc -c`" =3D "344" ] || die "failed test"
> einfo "passed test"

Yup. It's shorter and does same thing.

--=20
Peter.