[gentoo-dev] Re: gentoo-x86 commit in app-mobilephone/smstools: ChangeLog smstools-2.2.20.ebuild

[gentoo-dev] Re: gentoo-x86 commit in app-mobilephone/smstools: ChangeLog smstools-2.2.20.ebuild

[Torsten Veller]

* "Tony Vroon (chainsaw)" <chainsaw@gentoo.org>:
> diff -u -r1.1 -r1.2
> --- smstools-2.2.20.ebuild	14 Jan 2008 16:13:37 -0000	1.1
> +++ smstools-2.2.20.ebuild	31 Oct 2008 15:49:29 -0000	1.2
>  
> -pkg_setup() {
> -	enewgroup sms
> -	enewuser smsd -1 -1 /var/spool/sms sms
> -}
> -
>  src_unpack() {
>  	unpack ${A}
>  	cd "${S}"
> @@ -35,7 +30,12 @@
>  
>  src_compile() {
>  	cd src
> -	emake || die "emake failed"
> +	emake CC="$(tc-getCC)" || die "emake failed"
> +}
> +
> +pkg_preinst() {
> +	enewgroup sms
> +	enewuser smsd -1 -1 /var/spool/sms sms
>  }
>  
>  src_install() {
        chown -R smsd:sms "${D}"/var/spool/sms
        chmod g+s "${D}"/var/spool/sms/incoming

        newinitd "${FILESDIR}"/smsd.initd smsd
        insopts -o smsd -g sms -m0644
> @@ -60,5 +60,6 @@
>  }
>  
>  pkg_postinst() {
> +	touch /var/log/smsd.log
>  	chown -f smsd:sms /var/log/smsd.log
>  }

Remember pkg_preinst is called after src_install.
So the user and group probably don't exist during src_install.

BTW: ROOT should be respected in pkg_postinst too.

Re: [gentoo-dev] Re: gentoo-x86 commit in app-mobilephone/smstools: ChangeLog smstools-2.2.20.ebuild

[Tony "Chainsaw" Vroon]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

On Fri, 2008-10-31 at 17:18 +0100, Torsten Veller wrote:
> Remember pkg_preinst is called after src_install.

Right, I'll change that back. It got in my way during unpack cycles.

> BTW: ROOT should be respected in pkg_postinst too.

I'll add that.

Regards,
Tony V.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]