From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Kmcxn-0002Ee-LC for garchives@archives.gentoo.org; Sun, 05 Oct 2008 23:24:35 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D6845E050F; Sun, 5 Oct 2008 23:24:34 +0000 (UTC) Received: from smtp-out.neti.ee (smtp-out.neti.ee [194.126.126.37]) by pigeon.gentoo.org (Postfix) with ESMTP id 850ABE050F for ; Sun, 5 Oct 2008 23:24:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by MXR-5.estpak.ee (Postfix) with ESMTP id 0B2501DFAA4 for ; Mon, 6 Oct 2008 02:24:33 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at estpak.ee Received: from smtp-out.neti.ee ([127.0.0.1]) by localhost (MXR-5.estpak.ee [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gqabxhl-kcOU for ; Mon, 6 Oct 2008 02:24:31 +0300 (EEST) Received: from Relayhost1.neti.ee (Relayhost1 [88.196.174.141]) by MXR-5.estpak.ee (Postfix) with ESMTP id 625011DF99D for ; Mon, 6 Oct 2008 02:24:31 +0300 (EEST) Subject: Re: [gentoo-dev] Changing doc use flag on gtk-doc packages to gtk-doc-rebuild or something else From: Mart Raudsepp To: gentoo-dev@lists.gentoo.org In-Reply-To: <48E908D0.40209@gentoo.org> References: <48E8BB83.1010100@gentoo.org> <48E8C140.2050209@gentoo.org> <48E8EADD.1060504@gentoo.org> <48E908D0.40209@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-JTTk/BHACX/YuPBPStzz" Date: Mon, 06 Oct 2008 02:24:30 +0300 Message-Id: <1223249070.3203.8.camel@localhost> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.22.0 X-Archives-Salt: 71ba74e7-8771-438d-9484-61bdeaa42659 X-Archives-Hash: 7e6c633d6fece426a78f13ca0b896463 --=-JTTk/BHACX/YuPBPStzz Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On P, 2008-10-05 at 20:34 +0200, Thomas Sachau wrote: > R=E9mi Cardona schrieb: > > Thomas Sachau a =E9crit : > >> Why not do both (rebuild and install) with the doc useflag and none of > >> both, if it is not set? Imho > >> the doc flag is for control of installation for (additional) docs, the > >> way it is used for gtk-doc is > >> surely confusing. > >> > >=20 > > Building gtk-doc documentation pulls in a lot of deps. Installing it > > requires only some disk-space. For a full Gnome system, I only have 96M > > of docs. > >=20 > > As for rebuilding docs, one of the advantage is to correctly crosslink > > docs for tools such as dev-util/devhelp. > >=20 > > If anyone is _that_ short on diskspace, we'll gladly take patches :) > >=20 > > Cheers > >=20 > > R=E9mi > >=20 > >=20 >=20 > Did i say something about disk space? I say, you are using the doc use fl= ag in a way that is not > expected. The doc USE flag is typically used when it means additional dependencies, noticeable build time increase or extra downloads. For all the GNOME packages the former two apply for USE=3Ddoc because it requires a hefty dependency list for doc generation and a long documentation regeneration time. The tradition is to always install documentation that is already available. That is what we do. Those that want extra benefits of waiting on the doc building to get better doc hyperlinking and such, can do so with USE=3Ddoc, which is expected to take a longer time to build. > The global use flag says, it installs additional documentation. But your = doc use flag does > not install anything additional, but instead rebuilds those docs. There i= s nothing wrong with > rebuilding them on use=3Ddoc, but imho you should also only install those= docs with use=3Ddoc. Docs are installed always when they do not mean extra downloads, build time or dependencies. They don't if they are kept in the form they are in the tarballs already, so we already install them, just like many other packages do (including all the dodoc's) > The patch could be as simple as adding >use doc || rm -rf "${D}"usr/share= /gtk-doc< at the end of > src_install()-function in gnome2.eclass, that should be simple enough to = apply without a patch. :) Sorry, I'm not convinced there is anything to patch or change here. > Btw: e.g. x11-libs/gtk+ has no doc use flag, does not rebuild those docs,= but does also install > those docs as reported in bug 239524. It does have a doc USE flag, and it controls the same thing it does for everything else gtk-doc - passing --disable-gtk-doc or --enable-gtk-doc which acts like described above for regeneration. Making USE=3Ddoc control both installation and regeneration is out of the question. The benefits of rebuilding are not that big that everyone would want to do that, especially with recent versions of gtk-doc, but some do want it. Use INSTALL_MASK if you don't want developer API docs is the current stance. --=20 Mart Raudsepp Gentoo Developer Mail: leio@gentoo.org Weblog: http://planet.gentoo.org/developers/leio --=-JTTk/BHACX/YuPBPStzz Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (GNU/Linux) iEYEABECAAYFAkjpTK4ACgkQkeYb6olFHJfqZQCeKLFa3KfSGXA7j6Zms67wLtXY 9u8Anj/3mDr8ZzBDn1Fe2KUqbSctxOPp =rlSu -----END PGP SIGNATURE----- --=-JTTk/BHACX/YuPBPStzz--