From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KiPhd-0007SG-Ad for garchives@archives.gentoo.org; Wed, 24 Sep 2008 08:26:29 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5E12AE06A6; Wed, 24 Sep 2008 08:26:28 +0000 (UTC) Received: from ik-out-1112.google.com (ik-out-1112.google.com [66.249.90.181]) by pigeon.gentoo.org (Postfix) with ESMTP id 21569E06A6 for ; Wed, 24 Sep 2008 08:26:28 +0000 (UTC) Received: by ik-out-1112.google.com with SMTP id c21so1569716ika.2 for ; Wed, 24 Sep 2008 01:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer :sender; bh=VUDmDHFw4v7sd0VmVY8YKYZhavQ62+irQku7TOjXjao=; b=nxyJM0WB0ly2a3AxcQx1V4pFGl3ihyotSuudqWqygqhGAZ9ZVwswNgqTdzx/sR8LBH gWqAvZGFlB/unUpckZ4WxFnxVyBvhH3ZILjkb75wEBJ2ZxZOtNkCeCxCmkNJgNC/6i6k vRvO+sItd9G/wPZFtU4tDpESQbG0GmvH2TobY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer:sender; b=Sk6BP3xnhhwY0P3jQLlBDTd34SC2GwHVyeN0Y9o6EgjtyywoCcbALaecyxApGxamwx v1Z2Ok2aB5EvYB4/+aup+fBQvWHPp1YBwYLUZ9GrGvPrac117U7eNK0losUD2GOa893w s2j8OqktbrmhtWSBCFuxbCHKhz0S2ZyEi2uzw= Received: by 10.210.46.4 with SMTP id t4mr8076355ebt.53.1222244786871; Wed, 24 Sep 2008 01:26:26 -0700 (PDT) Received: from ?192.168.2.4? (81.202.42.238.dyn.user.ono.com [81.202.42.238]) by mx.google.com with ESMTPS id g9sm5634553gvc.0.2008.09.24.01.26.25 (version=SSLv3 cipher=RC4-MD5); Wed, 24 Sep 2008 01:26:25 -0700 (PDT) Subject: Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI From: "Santiago M. Mola" To: gentoo-dev@lists.gentoo.org In-Reply-To: <200809240235.22859.rbu@gentoo.org> References: <18646.45711.173931.589892@a1ihome1.kph.uni-mainz.de> <48D94608.7060805@gentoo.org> <200809240235.22859.rbu@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4Z6r8Gmkf95C8CPxOVkU" Date: Wed, 24 Sep 2008 10:26:26 +0200 Message-Id: <1222244786.2655.2.camel@mangurrian> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Sender: "Santiago M. Mola" X-Archives-Salt: c2805549-1c12-412e-9107-a2876344d369 X-Archives-Hash: 748cdd8710fbde8248fae474f84864f3 --=-4Z6r8Gmkf95C8CPxOVkU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El mi=C3=A9, 24-09-2008 a las 02:35 +0200, Robert Buchholz escribi=C3=B3: >=20 > Let's go with an even simpler default implementation: >=20 > default_src_install() { > if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then > emake DESTDIR=3D"${D}" install || die "emake install failed" > fi > if [ -n "${DOCS}" ]; then > dodoc ${DOCS} || die "dodoc failed" > fi > } >=20 > It addresses the following issues: > * Do not run einstall if emake fails > * Run dodoc even if no Makefile is present, this might come in handy for > ebuilds calling default() > * die dodoc failure case > * hopefully fix the flaws (not really) pointed out by zlin >=20 Looks far better. In my opinion, that would be an acceptable implementation of default_src_install. Regards, --=20 Santiago Mois=C3=A9s Mola Jabber: cooldwind@gmail.com | GPG: AAD203B5 --=-4Z6r8Gmkf95C8CPxOVkU Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkjZ+bIACgkQNC+1OarSA7UE3ACfWUrm9WxCVdg9D8ioPAuW8W5c y+0AnjPSDUJoCjKq94xU+nlKiUg1pPct =W378 -----END PGP SIGNATURE----- --=-4Z6r8Gmkf95C8CPxOVkU--