Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

["Santiago M. Mola" <coldwind@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

El mié, 24-09-2008 a las 02:35 +0200, Robert Buchholz escribió:
> 
> Let's go with an even simpler default implementation:
> 
> default_src_install() {
> 	if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then
> 		emake DESTDIR="${D}" install || die "emake install failed"
>         fi
> 	if [ -n "${DOCS}" ]; then
> 		dodoc ${DOCS} || die "dodoc failed"
> 	fi
> }
> 
> It addresses the following issues:
> * Do not run einstall if emake fails
> * Run dodoc even if no Makefile is present, this might come in handy for
>   ebuilds calling default()
> * die dodoc failure case
> * hopefully fix the flaws (not really) pointed out by zlin
> 

Looks far better. In my opinion, that would be an acceptable
implementation of default_src_install.

Regards,
-- 
Santiago Moisés Mola
Jabber: cooldwind@gmail.com | GPG: AAD203B5

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 197 bytes --]