[gentoo-dev] missing quotes in eclasses

[gentoo-dev] missing quotes in eclasses

[Markus Meier]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

Hi

There are several eclasses missing quotes:
http://dev.gentoo.org/~maekke/eclass-quoting.txt

This is the same check as repoman does, so there might be more quotes
needed or false-positives.


Markus

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] missing quotes in eclasses

[Doug Klima]

Markus Meier wrote:
> Hi
>
> There are several eclasses missing quotes:
> http://dev.gentoo.org/~maekke/eclass-quoting.txt
>
> This is the same check as repoman does, so there might be more quotes
> needed or false-positives.
>
>
> Markus
>   
Might want to cull that list of deprecated eclasses.
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] missing quotes in eclasses

[Markus Meier]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

On Wed, 13 Feb 2008 14:42:32 -0500
Doug Klima <cardoe@gentoo.org> wrote:

> Markus Meier wrote:
> > Hi
> >
> > There are several eclasses missing quotes:
> > http://dev.gentoo.org/~maekke/eclass-quoting.txt
> Might want to cull that list of deprecated eclasses.

That sounds like an idea. I blacklisted some obvious deprecated
eclasses. You may refetch the list.
Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] missing quotes in eclasses

[Doug Klima]

Markus Meier wrote:
> On Wed, 13 Feb 2008 14:42:32 -0500
> Doug Klima <cardoe@gentoo.org> wrote:
>
>   
>> Markus Meier wrote:
>>     
>>> Hi
>>>
>>> There are several eclasses missing quotes:
>>> http://dev.gentoo.org/~maekke/eclass-quoting.txt
>>>       
>> Might want to cull that list of deprecated eclasses.
>>     
>
> That sounds like an idea. I blacklisted some obvious deprecated
> eclasses. You may refetch the list.
> Thanks
>   

    deprecated eclasses:64-bit, darcs, db4-fix, debian, embassy-2.10,
    embassy-2.9, gcc, gnustep-old, gtk-engines, gtk-engines2, inherit,
    jakarta-commons, java-pkg, java-utils, kde-base, kde-i18n, kde-source,
    kmod, koffice-i18n, motif, mozilla, myth, pcmcia, perl-post, php, php-2,
    php-ext, php-ext-base, php-ext-pecl, php-ext-source, php-lib, php-pear,
    php-sapi, php5-sapi, php5-sapi-r1, php5-sapi-r2, php5-sapi-r3, tla,
    webapp-apache, xfree

Missing from that list is kernel and gst-plugins.
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] missing quotes in eclasses

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]


On K, 2008-02-13 at 15:49 -0500, Doug Klima wrote:
> Markus Meier wrote:
> > On Wed, 13 Feb 2008 14:42:32 -0500
> > Doug Klima <cardoe@gentoo.org> wrote:
> >
> >   
> >> Markus Meier wrote:
> >>     
> >>> Hi
> >>>
> >>> There are several eclasses missing quotes:
> >>> http://dev.gentoo.org/~maekke/eclass-quoting.txt
> >>>       
> >> Might want to cull that list of deprecated eclasses.
> >>     
> >
> > That sounds like an idea. I blacklisted some obvious deprecated
> > eclasses. You may refetch the list.
> > Thanks
> >   
> 
>     deprecated eclasses:64-bit, darcs, db4-fix, debian, embassy-2.10,
>     embassy-2.9, gcc, gnustep-old, gtk-engines, gtk-engines2, inherit,
>     jakarta-commons, java-pkg, java-utils, kde-base, kde-i18n, kde-source,
>     kmod, koffice-i18n, motif, mozilla, myth, pcmcia, perl-post, php, php-2,
>     php-ext, php-ext-base, php-ext-pecl, php-ext-source, php-lib, php-pear,
>     php-sapi, php5-sapi, php5-sapi-r1, php5-sapi-r2, php5-sapi-r3, tla,
>     webapp-apache, xfree
> 
> Missing from that list is kernel and gst-plugins.

wxlib also.
Do I need to be adding deprecation notice somewhere? I didn't see
anything in some of the listed above eclasses

-- 
Mart Raudsepp
Gentoo Developer
Mail: leio@gentoo.org
Weblog: http://planet.gentoo.org/developers/leio

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [gentoo-dev] clean deprecated eclasses(?) (was: missing quotes in eclasses)

[Peter Volkov]

[-- Attachment #1: Type: text/plain, Size: 2443 bytes --]

В Чтв, 14/02/2008 в 02:10 +0200, Mart Raudsepp пишет:
> On K, 2008-02-13 at 15:49 -0500, Doug Klima wrote:
> > 
> >     deprecated eclasses:64-bit, darcs, db4-fix, debian, embassy-2.10,
> >     embassy-2.9, gcc, gnustep-old, gtk-engines, gtk-engines2, inherit,
> >     jakarta-commons, java-pkg, java-utils, kde-base, kde-i18n, kde-source,
> >     kmod, koffice-i18n, motif, mozilla, myth, pcmcia, perl-post, php, php-2,
> >     php-ext, php-ext-base, php-ext-pecl, php-ext-source, php-lib, php-pear,
> >     php-sapi, php5-sapi, php5-sapi-r1, php5-sapi-r2, php5-sapi-r3, tla,
> >     webapp-apache, xfree
> > 
> > Missing from that list is kernel and gst-plugins.
> 
> wxlib also.
> Do I need to be adding deprecation notice somewhere? I didn't see
> anything in some of the listed above eclasses

Some of them are not used in the tree any more:

64-bit db4-fix debian embassy-2.10 embassy-2.9 gcc gnustep-old
gtk-engines gtk-engines2 jakarta-commons java-utils kde-base kde-i18n
kde-source kmod koffice-i18n motif mozilla myth pcmcia perl-post php
php-2 php-ext php-ext-base php-ext-pecl php-ext-source php-lib
php-pearphp-sapi php5-sapi php5-sapi-r1 php5-sapi-r2 php5-sapi-r3 tla
webapp-apache xfree gst-plugins wxlib

May be we should punt them from the tree?

And some are used by small number of packages:

darcs
dev-lisp/cl-fiveam-darcs/cl-fiveam-darcs-20060825.ebuild
dev-lisp/cl-arnesi-darcs/cl-arnesi-darcs-20060825.ebuild
dev-lisp/cl-rfc2388-darcs/cl-rfc2388-darcs-20060825.ebuild
dev-lisp/cl-rfc2109-darcs/cl-rfc2109-darcs-20060825.ebuild
dev-lisp/cl-parenscript-darcs/cl-parenscript-darcs-20060825.ebuild
dev-lisp/cl-yaclml-darcs/cl-yaclml-darcs-20060825.ebuild

kernel
sys-kernel/mips-sources/mips-sources-2.6.23.14.ebuild
sys-kernel/mips-sources/mips-sources-2.6.20.18.ebuild
sys-kernel/mips-sources/mips-sources-2.6.22.6.ebuild
sys-kernel/mips-headers/mips-headers-2.4.28-r1.ebuild

java-pkg - is it deprecated? Reading comments inside java eclass it's
hard to say that.

inherit - I did not found ebuilds where it is used, but actually I do
not know how it was used, so may be I overlooked something.

The check was done with the following script:

find /usr/portage \( -name '*.ebuild' -o -name '*.eclass' \) \
-exec awk "/inherit.*[[:blank:]]+${eclass}([[:blank:]]+.*|$+)/{print FILENAME }" \{\} \;

For inherit eclass I've searched manually.

-- 
Peter.

[-- Attachment #2: Эта часть сообщения подписана цифровой подписью --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] clean deprecated eclasses(?)

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Peter Volkov kirjoitti:
> 
> May be we should punt them from the tree?
> 

Eclasses can't be removed...
Maybe we should have a deprecated eclass for showing a common messaged 
that certain eclasses should not be used. Then deprecated eclasses could 
be detected by looking if they inherit deprecated.

> java-pkg - is it deprecated? Reading comments inside java eclass it's
> hard to say that.

It's deprecated.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [gentoo-dev] clean deprecated eclasses(?)

[Rémi Cardona]

Petteri Räty a écrit :
> Peter Volkov kirjoitti:
>>
>> May be we should punt them from the tree?
>>
> 
> Eclasses can't be removed...

Arguably we could specify a time period before they can be removed? This 
is probably GLEP material though :)

> Maybe we should have a deprecated eclass for showing a common messaged 
> that certain eclasses should not be used. Then deprecated eclasses could 
> be detected by looking if they inherit deprecated.

Maybe we could just extend the eclass API to have a 
DEPRECATED="yyyy-mm-dd" variable at the top of the eclass - which would 
move the burden to the PM - instead of adding yet another eclass (which 
we wouldn't be able to remove :p)

Cheers

-- 
Rémi Cardona
LRI, INRIA
remi.cardona@lri.fr
remi@gentoo.org
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] clean deprecated eclasses(?) (was: missing quotes in eclasses)

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Thu, 14 Feb 2008 16:52:57 +0300
Peter Volkov <pva@gentoo.org> wrote:
> May be we should punt them from the tree?

Can't until everyone's using a package manager with working env saving.

> inherit - I did not found ebuilds where it is used, but actually I do
> not know how it was used, so may be I overlooked something.

That's there for historical reasons.

> The check was done with the following script:
> 
> find /usr/portage \( -name '*.ebuild' -o -name '*.eclass' \) \
> -exec awk "/inherit.*[[:blank:]]+${eclass}([[:blank:]]+.*|$+)/{print
> FILENAME }" \{\} \;

Careful with that... You're better off searching on the INHERITED
metadata key.

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] clean deprecated eclasses(?) (was: missing quotes in eclasses)

[Chris Gianelloni]

On Thu, 2008-02-14 at 16:52 +0300, Peter Volkov wrote:
> The check was done with the following script:
> 
> find /usr/portage \( -name '*.ebuild' -o -name '*.eclass' \) \
> -exec awk "/inherit.*[[:blank:]]+${eclass}([[:blank:]]+.*|$+)/{print FILENAME }" \{\} \;
> 
> For inherit eclass I've searched manually.

There's also games-etmod games-ut2k4mod and games-q3mod which were all
replaced by games-mods quite some time ago.  There isn't anything in the
tree using these.

-- 
Chris Gianelloni
Release Engineering Strategic Lead
Games Developer
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] clean deprecated eclasses(?)

[Chris Gianelloni]

On Thu, 2008-02-14 at 16:03 +0200, Petteri Räty wrote:
> Peter Volkov kirjoitti:
> > 
> > May be we should punt them from the tree?
> > 
> 
> Eclasses can't be removed...

Well, this isn't really true anymore thanks to bug #46223 being
resolved.  I'd say that it only makes sense that we keep them around for
a long time from here on out, but they *can* be safe to move in the
future.

-- 
Chris Gianelloni
Release Engineering Strategic Lead
Games Developer
--
gentoo-dev@lists.gentoo.org mailing list