From: Kristian Fiskerstrand <k_f@gentoo.org>
To: gentoo-dev@lists.gentoo.org, Ulrich Mueller <ulm@gentoo.org>
Subject: eclass committ message verbosity (Was: Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.)
Date: Tue, 6 Feb 2018 15:40:51 +0100 [thread overview]
Message-ID: <11c10acb-9965-951a-a5e2-56c0189fbbf7@gentoo.org> (raw)
In-Reply-To: <23161.48517.148291.638434@a1i15.kph.uni-mainz.de>
[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]
On 02/06/2018 03:36 PM, Ulrich Mueller wrote:
>>>>>> On Tue, 6 Feb 2018, Kristian Fiskerstrand wrote:
>> More generally though, should we start requiring more verbose commit
>> messages for eclasses to make it easier to trace changes in our git
>> repo directly without reaching out to bugs? At least including
>> summaries of the respective bugs as a short description?
>
> In the concrete example, the bug's summary is "bzr.eclass might need
> to use bzr pull's --overwrite-tags flag" which is not much different
> from the git commit message.
Right, this specific commit likely has little more to gain given the
summary line. But could easily benefit from some text in body still :)
But I generally think we can benefit from some more verbosity in our
commit messages, in particular for eclasses.
--
Kristian Fiskerstrand
OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-02-06 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 13:57 [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command Ulrich Müller
2018-02-06 14:12 ` Kristian Fiskerstrand
2018-02-06 14:36 ` Ulrich Mueller
2018-02-06 14:40 ` Kristian Fiskerstrand [this message]
2018-02-06 17:07 ` Alec Warner
2018-02-06 20:07 ` Michał Górny
2018-02-06 23:24 ` [gentoo-dev] [PATCH] bzr.eclass: Drop bzr_bootstrap and bzr_src_prepare Ulrich Müller
2018-02-07 7:34 ` Michał Górny
2018-02-07 13:18 ` Ulrich Mueller
2018-02-07 13:26 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11c10acb-9965-951a-a5e2-56c0189fbbf7@gentoo.org \
--to=k_f@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox