public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild
       [not found] <E1Irh81-0006l9-H9@stork.gentoo.org>
@ 2007-11-12 22:09 ` Donnie Berkholz
  2007-11-12 23:03   ` Michael Hanselmann
  0 siblings, 1 reply; 4+ messages in thread
From: Donnie Berkholz @ 2007-11-12 22:09 UTC (permalink / raw
  To: gentoo-dev, hansmi

On 21:47 Mon 12 Nov     , Michael Hanselmann (hansmi) wrote:
> 1.1                  net-irc/inspircd/inspircd-1.1.14.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-irc/inspircd/inspircd-1.1.14.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-irc/inspircd/inspircd-1.1.14.ebuild?rev=1.1&content-type=text/plain

> pkg_postinst() {
> 	chown -R inspircd:inspircd "${ROOT}"/etc/${PN}
> 	chmod 700 "${ROOT}"/etc/${PN}
> 
> 	chown -R inspircd:inspircd "${ROOT}"/var/log/${PN}
> 	chmod 750 "${ROOT}"/var/log/${PN}
> 
> 	chown -R inspircd:inspircd "${ROOT}"/usr/$(get_libdir)/${PN}
> 	chmod -R 755 "${ROOT}"/usr/$(get_libdir)/${PN}
> 
> 	chmod -R 755 "${ROOT}"/usr/bin/inspircd
> }

Any particular reason this stuff doesn't run in src_install() on the 
files while they're in ${D}?

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild
  2007-11-12 22:09 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild Donnie Berkholz
@ 2007-11-12 23:03   ` Michael Hanselmann
  2007-11-13  2:20     ` Donnie Berkholz
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Hanselmann @ 2007-11-12 23:03 UTC (permalink / raw
  To: Donnie Berkholz; +Cc: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On Mon, Nov 12, 2007 at 02:09:33PM -0800, Donnie Berkholz wrote:
> On 21:47 Mon 12 Nov     , Michael Hanselmann (hansmi) wrote:
> > pkg_postinst() {
> > 	chown -R inspircd:inspircd "${ROOT}"/etc/${PN}
> > 	chmod 700 "${ROOT}"/etc/${PN}

> > 	chown -R inspircd:inspircd "${ROOT}"/var/log/${PN}
> > 	chmod 750 "${ROOT}"/var/log/${PN}

> > 	chown -R inspircd:inspircd "${ROOT}"/usr/$(get_libdir)/${PN}
> > 	chmod -R 755 "${ROOT}"/usr/$(get_libdir)/${PN}

> > 	chmod -R 755 "${ROOT}"/usr/bin/inspircd
> > }

> Any particular reason this stuff doesn't run in src_install() on the 
> files while they're in ${D}?

Honestly, I don't know. The ebuild was contributed quite some time ago.
Do you think it should be done in src_install instead?

Thanks,
Michael

-- 
http://hansmi.ch/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild
  2007-11-12 23:03   ` Michael Hanselmann
@ 2007-11-13  2:20     ` Donnie Berkholz
  2007-11-13  7:28       ` Peter Volkov
  0 siblings, 1 reply; 4+ messages in thread
From: Donnie Berkholz @ 2007-11-13  2:20 UTC (permalink / raw
  To: gentoo-dev

On 00:03 Tue 13 Nov     , Michael Hanselmann wrote:
> On Mon, Nov 12, 2007 at 02:09:33PM -0800, Donnie Berkholz wrote:
> > On 21:47 Mon 12 Nov     , Michael Hanselmann (hansmi) wrote:
> > > pkg_postinst() {
> > > 	chown -R inspircd:inspircd "${ROOT}"/etc/${PN}
> > > 	chmod 700 "${ROOT}"/etc/${PN}
> 
> > > 	chown -R inspircd:inspircd "${ROOT}"/var/log/${PN}
> > > 	chmod 750 "${ROOT}"/var/log/${PN}
> 
> > > 	chown -R inspircd:inspircd "${ROOT}"/usr/$(get_libdir)/${PN}
> > > 	chmod -R 755 "${ROOT}"/usr/$(get_libdir)/${PN}
> 
> > > 	chmod -R 755 "${ROOT}"/usr/bin/inspircd
> > > }
> 
> > Any particular reason this stuff doesn't run in src_install() on the 
> > files while they're in ${D}?
> 
> Honestly, I don't know. The ebuild was contributed quite some time ago.
> Do you think it should be done in src_install instead?

I find it cleaner to move it and use fowners()/fperms(), because doing 
it in pkg_* implies to me that it needs to get fixed on the live 
filesystem for some reason.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild
  2007-11-13  2:20     ` Donnie Berkholz
@ 2007-11-13  7:28       ` Peter Volkov
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Volkov @ 2007-11-13  7:28 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]


В Пнд, 12/11/2007 в 18:20 -0800, Donnie Berkholz пишет:
> On 00:03 Tue 13 Nov     , Michael Hanselmann wrote:
> > On Mon, Nov 12, 2007 at 02:09:33PM -0800, Donnie Berkholz wrote:
> > > On 21:47 Mon 12 Nov     , Michael Hanselmann (hansmi) wrote:
> > > > pkg_postinst() {
> > > > 	chown -R inspircd:inspircd "${ROOT}"/etc/${PN}
> > > > 	chmod 700 "${ROOT}"/etc/${PN}
> > 
> > > > 	chown -R inspircd:inspircd "${ROOT}"/var/log/${PN}
> > > > 	chmod 750 "${ROOT}"/var/log/${PN}
> > 
> > > > 	chown -R inspircd:inspircd "${ROOT}"/usr/$(get_libdir)/${PN}
> > > > 	chmod -R 755 "${ROOT}"/usr/$(get_libdir)/${PN}
> > 
> > > > 	chmod -R 755 "${ROOT}"/usr/bin/inspircd
> > > > }

> I find it cleaner to move it and use fowners()/fperms(), because doing 
> it in pkg_* implies to me that it needs to get fixed on the live 
> filesystem for some reason.

Some of them are directories, right? Then while bug
bugs.gentoo.org/141619 is not fixed, I'd kept the directories in
pkg_postinst and added some comment that this is workaround of bug
#141619.

-- 
Peter.

[-- Attachment #2: Эта часть сообщения подписана цифровой подписью --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-13  7:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Irh81-0006l9-H9@stork.gentoo.org>
2007-11-12 22:09 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild Donnie Berkholz
2007-11-12 23:03   ` Michael Hanselmann
2007-11-13  2:20     ` Donnie Berkholz
2007-11-13  7:28       ` Peter Volkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox