From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Ipmrf-0001AO-Jq for garchives@archives.gentoo.org; Wed, 07 Nov 2007 15:30:48 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.2/8.14.0) with SMTP id lA7FTCml002870; Wed, 7 Nov 2007 15:29:12 GMT Received: from ik-out-1112.google.com (ik-out-1112.google.com [66.249.90.180]) by robin.gentoo.org (8.14.2/8.14.0) with ESMTP id lA7FPeMU029014 for ; Wed, 7 Nov 2007 15:25:40 GMT Received: by ik-out-1112.google.com with SMTP id c29so1443029ika for ; Wed, 07 Nov 2007 07:25:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:sender; bh=ZWeoHsQjsYA1dx+MDWhw77LeiL1c54ZyWSp7SqQ8dvM=; b=KNtuVgM6ls49vKvysQJtxTGZnwAWeD9STmlLg5jpy7qZ31dNk37hmXt7h/Gi8l88027glxBFTxSS1buA54xBRsGvJO+/CSfakBH36nv09EqL7EDOsOuyZn3Xp21l5xc/mSN1Nj4loLBCb3E0fk5Yd17jbwAf++nfj2va0uLZ5fg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:sender; b=fCoqog8YDESYtFAnrmBi/D+K2uO5JRJ1SJI/GUoVbP0Ths+tVkG00aVSJsWl6qobuK6IGqp3pY6A2JO5HTeQSD4s5bQ3XJ/loRGz72jOOiyBKcSgIPjsUhcrsKm4tBeBU0JTH2yNSwx30o/APb/kcNxeQ76SQGSBXWereSaohtA= Received: by 10.150.182.17 with SMTP id e17mr627618ybf.1194449138636; Wed, 07 Nov 2007 07:25:38 -0800 (PST) Received: from ?195.209.218.137? ( [195.209.218.137]) by mx.google.com with ESMTPS id h6sm36821nfh.2007.11.07.07.25.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 07 Nov 2007 07:25:37 -0800 (PST) Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-firewall/ipset: ChangeLog metadata.xml ipset-2.3.0.20070828.ebuild From: Peter Volkov To: Donnie Berkholz Cc: gentoo-dev In-Reply-To: <20071105180321.GF25343@supernova> References: <20071105180321.GF25343@supernova> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-1NTQ2FeESp71NBoqDQaU" Date: Wed, 07 Nov 2007 12:06:13 +0300 Message-Id: <1194426373.13571.10.camel@localhost> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Sender: Peter Volkov X-Archives-Salt: 2cb44107-4074-4026-b988-6426b1f7b912 X-Archives-Hash: 7ea4c13d606cfe456d8ffc3c3bed331d --=-1NTQ2FeESp71NBoqDQaU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 05/11/2007 =D0=B2 10:03 -0800, Donnie Berkholz wrote:=20 > On 14:23 Mon 05 Nov , Peter Volkov (pva) wrote: > > 1.1 net-firewall/ipset/ipset-2.3.0.20070828.ebuild > >=20 > > src_defs() { > > # these are used in both of src_compile and src_install > > myconf=3D"${myconf} PREFIX=3D" > > myconf=3D"${myconf} LIBDIR=3D/lib" >=20 > Should this be get_libdir()? Yes. Fixed. > Also seems like instead of having a function to do this, you could just=20 > define the variables once in pkg_setup() or src_compile() as globals. Fixed too. > > pkg_config() {=20 > > tar -jxf "${DISTDIR}"/iptables-${IPTVERINS}.tar.bz2 || \ > > die "Unable to unpack iptables-${IPTVERINS}.tar.bz2" >=20 > Could you just call unpack() here? Ok. Done. BTW, is it possible to force portage to fetch sources if they do not exist in ${DISTDIR}? Also does there exist a better way to find iptables sources than find version without revision: IPTVERINS=3D`echo $(best_version net-firewall/iptables) | \ sed -n 's:^[^/]*/[[:alpha:]]*-\([0-9]\+\([.][0-9]\+\)*[a-z]\?\(_\(pre\|= p\|beta\|alpha\|rc\)[0-9]*\)*\)\(-r[0-9]\+\)\?$:\1:p' and construct package name (iptables-${IPTVERINS}}.tar.bz2)? > > einfo "Enter path to your kernel sources, relative to ${ROOT}" > > echo -n "[/usr/src/linux]: " > > read K_DIR > > [ "${ROOT}${K_DIR}" =3D=3D "/" ] && K_DIR=3D${ROOT}/usr/src/linux >=20 > /usr/src/linux should be what's used here, and if they want to change=20 > the kernel to affect, they should change where the symlink points=20 > instead of having a secondary config mechanism. Agree, and fixed too. Thank you, very much, for review. --=20 Peter. --=-1NTQ2FeESp71NBoqDQaU Content-Type: application/pgp-signature; name=signature.asc Content-Description: =?UTF-8?Q?=D0=AD=D1=82=D0=B0?= =?UTF-8?Q?_=D1=87=D0=B0=D1=81=D1=82=D1=8C?= =?UTF-8?Q?_=D1=81=D0=BE=D0=BE=D0=B1=D1=89=D0=B5=D0=BD=D0=B8=D1=8F?= =?UTF-8?Q?_=D0=BF=D0=BE=D0=B4=D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=B0?= =?UTF-8?Q?_=D1=86=D0=B8=D1=84=D1=80=D0=BE=D0=B2=D0=BE=D0=B9?= =?UTF-8?Q?_=D0=BF=D0=BE=D0=B4=D0=BF=D0=B8=D1=81=D1=8C=D1=8E?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQBHMX//z6tlgEWSarMRAgfDAJ9cv+mIwXO3y4RoNuC+WhzpKh/3kACgol4v b9v0nw8mG5faViadsvQ5jjs= =/5gI -----END PGP SIGNATURE----- --=-1NTQ2FeESp71NBoqDQaU-- -- gentoo-dev@gentoo.org mailing list