public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Peter Volkov <pva@gentoo.org>
To: Donnie Berkholz <dberkholz@gentoo.org>
Cc: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-firewall/ipset: ChangeLog metadata.xml ipset-2.3.0.20070828.ebuild
Date: Wed, 07 Nov 2007 12:06:13 +0300	[thread overview]
Message-ID: <1194426373.13571.10.camel@localhost> (raw)
In-Reply-To: <20071105180321.GF25343@supernova>

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

On Mon, 05/11/2007 в 10:03 -0800, Donnie Berkholz wrote: 
> On 14:23 Mon 05 Nov     , Peter Volkov (pva) wrote:
> > 1.1                  net-firewall/ipset/ipset-2.3.0.20070828.ebuild
> > 
> > src_defs() {
> > 	# these are used in both of src_compile and src_install
> > 	myconf="${myconf} PREFIX="
> > 	myconf="${myconf} LIBDIR=/lib"
> 
> Should this be get_libdir()?

Yes. Fixed.

> Also seems like instead of having a function to do this, you could just 
> define the variables once in pkg_setup() or src_compile() as globals.

Fixed too.

> > pkg_config() { 
> > 	tar -jxf "${DISTDIR}"/iptables-${IPTVERINS}.tar.bz2 || \
> > 				die "Unable to unpack iptables-${IPTVERINS}.tar.bz2"
> 
> Could you just call unpack() here?

Ok. Done.

BTW, is it possible to force portage to fetch sources if they do not
exist in ${DISTDIR}? Also does there exist a better way to find iptables
sources than find version without revision:

IPTVERINS=`echo $(best_version net-firewall/iptables) | \
    sed -n 's:^[^/]*/[[:alpha:]]*-\([0-9]\+\([.][0-9]\+\)*[a-z]\?\(_\(pre\|p\|beta\|alpha\|rc\)[0-9]*\)*\)\(-r[0-9]\+\)\?$:\1:p'

and construct package name (iptables-${IPTVERINS}}.tar.bz2)?

> > 	einfo "Enter path to your kernel sources, relative to ${ROOT}"
> > 	echo -n "[/usr/src/linux]: "
> > 	read K_DIR
> > 	[ "${ROOT}${K_DIR}" == "/" ] && K_DIR=${ROOT}/usr/src/linux
> 
> /usr/src/linux should be what's used here, and if they want to change 
> the kernel to affect, they should change where the symlink points 
> instead of having a secondary config mechanism.

Agree, and fixed too. Thank you, very much, for review.

-- 
Peter.

[-- Attachment #2: Эта часть сообщения подписана цифровой подписью --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-11-07 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Ip2rU-0003os-Bw@stork.gentoo.org>
2007-11-05 18:03 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-firewall/ipset: ChangeLog metadata.xml ipset-2.3.0.20070828.ebuild Donnie Berkholz
2007-11-07  9:06   ` Peter Volkov [this message]
2007-11-07 23:19     ` Donnie Berkholz
2007-11-08  2:04       ` Alec Warner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1194426373.13571.10.camel@localhost \
    --to=pva@gentoo.org \
    --cc=dberkholz@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox