[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/nagios-plugins: ChangeLog nagios-plugins-1.4.10-r1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/nagios-plugins: ChangeLog nagios-plugins-1.4.10-r1.ebuild

[Donnie Berkholz]

On 19:51 Mon 29 Oct     , Tobias Scherbaum (dertobi123) wrote:
> 1.1                  net-analyzer/nagios-plugins/nagios-plugins-1.4.10-r1.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/nagios-plugins/nagios-plugins-1.4.10-r1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/nagios-plugins/nagios-plugins-1.4.10-r1.ebuild?rev=1.1&content-type=text/plain

> src_install() {
> 	mv "${S}"/contrib/check_compaq_insight.pl "${S}"/contrib/check_compaq_insight.pl.msg
> 	chmod +x "${S}"/contrib/*.pl
> 
> 	sed -i -e '1s;#!.*;#!/usr/bin/perl -w;' "${S}"/contrib/*.pl || die "sed failed"
> 	sed -i -e '30s/use lib utils.pm;/use utils;/' \
> 		"${S}"/plugins-scripts/check_file_age.pl || die "sed failed"
> 
> 	dodoc ABOUT-NLS ACKNOWLEDGEMENTS AUTHORS BUGS CODING \
> 		ChangeLog FAQ NEWS README REQUIREMENTS SUPPORT THANKS
> 
> 	emake DESTDIR="${D}" install || die "make install failed"
> 
> 	if use mysql || use postgres; then
> 		dodir /usr/nagios/libexec
> 		exeinto /usr/nagios/libexec
> 		doexe "${S}"/contrib/check_nagios_db.pl
> 	fi
> 
> 	dodir /usr/nagios/libexec/
> 	mv "${S}"/contrib "${D}"/usr/nagios/libexec/contrib
> 
> 	chown root:nagios "${D}"/usr/nagios || die "Failed Chown of ${D}usr/nagios"
> 	chown -R root:nagios "${D}"/usr/nagios/libexec || die "Failed Chown of ${D}usr/nagios/libexec"
> 
> 	chmod -R o-rwx "${D}"/usr/nagios/libexec || die "Failed Chmod of ${D}usr/nagios/libexec"
> 
> 	chmod 04710 "${D}"/usr/nagios/libexec/check_icmp || die "Failed Chmod of ${D}usr/nagios/libexec/check_icmp"

This may not be worth changing, but if you're ever working on it, 
fperms/fowners could be nice to use instead of these. It lets you clean 
out all those references to $D.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/nagios-plugins: ChangeLog nagios-plugins-1.4.10-r1.ebuild

[Tobias Scherbaum]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Donnie Berkholz wrote:
> > 	chown root:nagios "${D}"/usr/nagios || die "Failed Chown of ${D}usr/nagios"
> > 	chown -R root:nagios "${D}"/usr/nagios/libexec || die "Failed Chown of ${D}usr/nagios/libexec"
> > 
> > 	chmod -R o-rwx "${D}"/usr/nagios/libexec || die "Failed Chmod of ${D}usr/nagios/libexec"
> > 
> > 	chmod 04710 "${D}"/usr/nagios/libexec/check_icmp || die "Failed Chmod of ${D}usr/nagios/libexec/check_icmp"
> 
> This may not be worth changing, but if you're ever working on it, 
> fperms/fowners could be nice to use instead of these. It lets you clean 
> out all those references to $D.

I'll take a look at it, thanks! :)

wkr,
  Tobias

-- 
Gentoo Linux - Die Metadistribution
http://www.mitp.de/1769

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 189 bytes --]