Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/note: ChangeLog note-1.3.3.ebuild

[Roy Marples <uberlord@gentoo.org>]

On Mon, 2007-10-15 at 09:56 +0200, Bo Ørsted Andresen wrote:
> On Monday 15 October 2007 09:42:50 Donnie Berkholz wrote:
> > On 07:40 Mon 15 Oct     , Christian Faulhammer (opfer) wrote:
> > > 1.1                  app-misc/note/note-1.3.3.ebuild
> > >
> > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/note/note-1.3.3.ebuild?rev=1.1&view=markup
> > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/note/note-1.3.3.ebuild?rev=1.1&content-type=text/plain
> > >
> > > 	for v in mysql text dbm general; do
> > > 		if ! use ${v}; then
> > > 			for u in `find "${D}" -type f -name *${v}.*pm`; do
> > > 				rm ${u}
> >
> > Looks like 'u' could have spaces in it, since it's based on D.
> 
> Written like this u certainly can't since the output of the find expression is
> subjected to word splitting before u gets set. Hence this will fail if ${D}
> contains spaces even if ${u} gets quoted. The best way to solve this is to use
> find ... -print0 | xargs -0 rm. Unfortunately that solution means using GNU
> extensions that I'm not sure are guaranteed to be available in the ebuild
> environment. If they aren't maybe they should be.
> 

find "${D}" -type f -name *${v}.*pm -delete

Thanks

Roy

-- 
gentoo-dev@gentoo.org mailing list