From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IcbOf-0006uW-4u for garchives@archives.gentoo.org; Tue, 02 Oct 2007 06:38:21 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l926SYrW022433; Tue, 2 Oct 2007 06:28:34 GMT Received: from mail.marples.name (rsm.demon.co.uk [80.177.111.50]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l926QfqS020152 for ; Tue, 2 Oct 2007 06:26:41 GMT Received: from [10.73.1.31] (uberlaptop.marples.name [10.73.1.31]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mail.marples.name (Postfix) with ESMTP id 9FE72190038 for ; Tue, 2 Oct 2007 07:26:40 +0100 (BST) Subject: Re: [gentoo-dev] RFC: sh versionator.eclass From: Roy Marples To: gentoo-dev@lists.gentoo.org In-Reply-To: <200710012022.21957.vapier@gentoo.org> References: <200710012259.40589.uberlord@gentoo.org> <20071001224136.GA9048@ferdyx.org> <200710012348.55548.uberlord@gentoo.org> <200710012022.21957.vapier@gentoo.org> Content-Type: text/plain Organization: Gentoo Date: Tue, 02 Oct 2007 07:26:39 +0100 Message-Id: <1191306400.63509.4.camel@uberlaptop.marples.name> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 Content-Transfer-Encoding: 7bit X-Archives-Salt: 5593e321-de09-4c9a-ac3c-9e01aebadb76 X-Archives-Hash: 21a84f70c1f232a895ada447c55e3266 On Mon, 2007-10-01 at 20:22 -0400, Mike Frysinger wrote: > "better readability" is a pretty subjective claim ... Many things are subjective - one mans good is another mans bad. /me shrugs > i'd say that changing > things from doing a case match against proper character classes to doing a > printf against arbitrary character ranges (which btw are not locale safe, so > i imagine you've introduced a regression there) is not "better". but i'm not > the maintainer of said eclass. That is why the case match is like so [0-9] Should be safe - every language should operate in base 10 -|.|_ Exact match * If it's not the above, treat it like a letter So there shouldn't be any regressions with version numbers here as I've cunningly avoided the locale trap. > > > but I find interesting that > > > you ripped Ciaran's copyright while leaving the "Prod ciaranm if you > > > find something it can't handle" comment. > > > > I copied and pasted the comments for the most part. Sorry for leaving that > > bit in. And I thought that the Gentoo Foundation had the copyright? > > it does. and if it doesnt, punt the file and rewrite it from scratch. Well, this should constitute a rewrite from scratch. Thanks Roy -- gentoo-dev@gentoo.org mailing list