[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/gnome-doc-utils: ChangeLog gnome-doc-utils-0.12.0.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/gnome-doc-utils: ChangeLog gnome-doc-utils-0.12.0.ebuild

[Donnie Berkholz]

On 02:42 Mon 01 Oct     , Mart Raudsepp (leio) wrote:
> 1.1                  app-text/gnome-doc-utils/gnome-doc-utils-0.12.0.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-text/gnome-doc-utils/gnome-doc-utils-0.12.0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-text/gnome-doc-utils/gnome-doc-utils-0.12.0.ebuild?rev=1.1&content-type=text/plain

> pkg_postinst() {
> 	python_mod_optimize ${ROOT}usr/share/xml2po
> 	gnome2_pkg_postinst
> }
> 
> pkg_postrm() {
> 	python_mod_cleanup ${ROOT}usr/share/xml2po
> 	gnome2_pkg_postrm
> }

Quote ROOT. Template-looking code like this also makes me wonder whether 
there should be some sort of gnome-python eclass.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/gnome-doc-utils: ChangeLog gnome-doc-utils-0.12.0.ebuild

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 1949 bytes --]

On P, 2007-09-30 at 22:33 -0700, Donnie Berkholz wrote:
> On 02:42 Mon 01 Oct     , Mart Raudsepp (leio) wrote:
> > 1.1                  app-text/gnome-doc-utils/gnome-doc-utils-0.12.0.ebuild
> > 
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-text/gnome-doc-utils/gnome-doc-utils-0.12.0.ebuild?rev=1.1&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-text/gnome-doc-utils/gnome-doc-utils-0.12.0.ebuild?rev=1.1&content-type=text/plain
> 
> > pkg_postinst() {
> > 	python_mod_optimize ${ROOT}usr/share/xml2po
> > 	gnome2_pkg_postinst
> > }
> > 
> > pkg_postrm() {
> > 	python_mod_cleanup ${ROOT}usr/share/xml2po
> > 	gnome2_pkg_postrm
> > }
> 
> Quote ROOT. Template-looking code like this also makes me wonder whether 
> there should be some sort of gnome-python eclass.

First off, that stuff ought to be in site-packages in the first place.
There's a bug on that.

I'm in a spree to finally get gnome 2.20 in, so I'm actually not fully
reading the ebuilds right now, but instead diffing all relevant build
files and diffing the ebuilds, quickly skimming through the ebuild for
the patch situation and such and that's it. I can take a look at this QA
kind of things later - the lack of quoting is no regression at the
moment at least, but a remaining QA bug. Noted in my TODO list, but it
needs solving of the above-mentioned bug anyway in the same area. In
case of more reviews with problems, feel free to note me or the list and
I'll add them to my list of things to check/fix.

As for gnome-python eclass - I just noticed some python shipping things
in gnome are now using a py-compile script that takes care of compiling
and optimizing on its own and portage without python.eclass plays along
great. Unfortunately not all of them are using this stuff.

-- 
Mart Raudsepp
Gentoo Developer
Mail: leio@gentoo.org
Weblog: http://planet.gentoo.org/developers/leio

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]