[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygobject: ChangeLog pygobject-2.14.0.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygobject: ChangeLog pygobject-2.14.0.ebuild

[Donnie Berkholz]

On 13:15 Wed 26 Sep     , Mart Raudsepp (leio) wrote:
> 1.1                  dev-python/pygobject/pygobject-2.14.0.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-python/pygobject/pygobject-2.14.0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-python/pygobject/pygobject-2.14.0.ebuild?rev=1.1&content-type=text/plain

> 	mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py \
> 		"${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py-2.0
> 	mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth \
> 		"${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth-2.0
> }
> 
> pkg_postinst() {
> 	python_version
> 	python_mod_optimize /usr/lib/python${PYVER}/site-packages/gtk-2.0
> 	alternatives_auto_makesym /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py pygtk.py-[0-9].[0-9]
> 	alternatives_auto_makesym /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth pygtk.pth-[0-9].[0-9]
> 	python_mod_compile ${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py

This is pretty weird, because it uses get_libdir() almost everywhere but 
skips it once. Wonder if we could add a repoman check that looks for 
whether an ebuild calls get_libdir(), then checks for any instances of 
'[^[:alnum:]]lib[^[:alnum:]]'.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygobject: ChangeLog pygobject-2.14.0.ebuild

[Ryan Hill]

Donnie Berkholz wrote:
> On 13:15 Wed 26 Sep     , Mart Raudsepp (leio) wrote:
>> 1.1                  dev-python/pygobject/pygobject-2.14.0.ebuild
>>
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-python/pygobject/pygobject-2.14.0.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-python/pygobject/pygobject-2.14.0.ebuild?rev=1.1&content-type=text/plain
> 
>> 	mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py \
>> 		"${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py-2.0
>> 	mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth \
>> 		"${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth-2.0
>> }
>>
>> pkg_postinst() {
>> 	python_version
>> 	python_mod_optimize /usr/lib/python${PYVER}/site-packages/gtk-2.0
>> 	alternatives_auto_makesym /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py pygtk.py-[0-9].[0-9]
>> 	alternatives_auto_makesym /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth pygtk.pth-[0-9].[0-9]
>> 	python_mod_compile ${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py
> 
> This is pretty weird, because it uses get_libdir() almost everywhere but 
> skips it once. Wonder if we could add a repoman check that looks for 
> whether an ebuild calls get_libdir(), then checks for any instances of 
> '[^[:alnum:]]lib[^[:alnum:]]'.

that would match foo-lib.txt foo-lib-defooifier /usr/share/lib-foo/ etc. and miss /usr/lib64/...
(though i don't see anyone doing that).

what about /\/lib[/|32|64]/ ?

-- 
                  fonts / wxWindows / gcc-porting / treecleaners
  9B81 6C9F E791 83BB 3AB3  5B2D E625 A073 8379 37E8 (0x837937E8)

-- 
gentoo-dev@gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygobject: ChangeLog pygobject-2.14.0.ebuild

[Steve Long]

Donnie Berkholz wrote:

> On 13:15 Wed 26 Sep     , Mart Raudsepp (leio) wrote:
>> mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py \
>> "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py-2.0
>> mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth \
>> "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth-2.0
>> }
>> 
>> pkg_postinst() {
>> python_version
>> python_mod_optimize /usr/lib/python${PYVER}/site-packages/gtk-2.0
>> alternatives_auto_makesym
>> /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py
>> pygtk.py-[0-9].[0-9] alternatives_auto_makesym
>> /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth
>> pygtk.pth-[0-9].[0-9] python_mod_compile
>> ${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py
> 
> This is pretty weird, because it uses get_libdir() almost everywhere but
> skips it once. Wonder if we could add a repoman check that looks for
> whether an ebuild calls get_libdir(), then checks for any instances of
> '[^[:alnum:]]lib[^[:alnum:]]'.
> 
It seems a bit inefficient to keep calling the function in an implicit
subshell. What's wrong with ldir="/usr/$(get_libdir)/" [or "${ROOT}usr.."]
once and then reusing the value?
(The single use of $ROOT in pkg_postinst() seems odd too, to this newb.)


-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/pygobject: ChangeLog pygobject-2.14.0.ebuild

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]

On N, 2007-09-27 at 17:08 +0100, Steve Long wrote:
> Donnie Berkholz wrote:
> 
> > On 13:15 Wed 26 Sep     , Mart Raudsepp (leio) wrote:
> >> mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py \
> >> "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py-2.0
> >> mv "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth \
> >> "${D}"/usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth-2.0
> >> }
> >> 
> >> pkg_postinst() {
> >> python_version
> >> python_mod_optimize /usr/lib/python${PYVER}/site-packages/gtk-2.0
> >> alternatives_auto_makesym
> >> /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py
> >> pygtk.py-[0-9].[0-9] alternatives_auto_makesym
> >> /usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.pth
> >> pygtk.pth-[0-9].[0-9] python_mod_compile
> >> ${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/pygtk.py
> > 
> > This is pretty weird, because it uses get_libdir() almost everywhere but
> > skips it once. Wonder if we could add a repoman check that looks for
> > whether an ebuild calls get_libdir(), then checks for any instances of
> > '[^[:alnum:]]lib[^[:alnum:]]'.
> > 
> It seems a bit inefficient to keep calling the function in an implicit
> subshell. What's wrong with ldir="/usr/$(get_libdir)/" [or "${ROOT}usr.."]
> once and then reusing the value?

Readability in my eyes. This function call can't cost more than all the
disk activity that is going to go on from the calls..

> (The single use of $ROOT in pkg_postinst() seems odd too, to this newb.)

That's what python.eclass gives you. Other functions takes care of
${ROOT} for you, but that doesn't.


As a side note, the python_mod_optimize lib was changed to a
$(get_libdir) yesterday based on Donnies initial post here.

-- 
Mart Raudsepp
Gentoo Developer
Mail: leio@gentoo.org
Weblog: http://planet.gentoo.org/developers/leio

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]