* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild [not found] <E1IZrhe-0008Hx-Hy@stork.gentoo.org> @ 2007-09-24 19:56 ` Donnie Berkholz 2007-09-24 20:28 ` Bo Ørsted Andresen 2007-09-25 5:29 ` [gentoo-dev] " Peter Volkov 0 siblings, 2 replies; 7+ messages in thread From: Donnie Berkholz @ 2007-09-24 19:56 UTC (permalink / raw To: gentoo-dev; +Cc: jurek On 17:26 Mon 24 Sep , Jurek Bartuszek (jurek) wrote: > jurek 07/09/24 17:26:38 > > Modified: ChangeLog > Added: libgdiplus-1.2.5-r1.ebuild > Log: > dev-dotnet/libgdiplus-1.2.5-r1: Fix linking against image libraries (bug #192068) > (Portage version: 2.1.3.9) > cd ${S} > > epatch ${FILESDIR}/${PN}-1.1.13-libungif-configure-fix.diff > epatch ${FILESDIR}/${P}-imglibs.patch Needs quotes for S and FILESDIR. > src_compile() { > if [[ "$(gcc-major-version)" -gt "3" ]] || \ > ( [[ "$(gcc-major-version)" -eq "3" ]] && [[ "$(gcc-minor-version)" -gt "3" ]] ) Code block { } might be good here instead of a subshell, or perhaps it could use logic that's less convoluted such as if..then. Also don't need the double quotes. > if use ppc ; then > sed -i -e 's:-Werror::g' src/Makefile > fi We should never leave -Werror in -- make this unconditional. It tends to cause large quantities of packages to break every time there's a compiler upgrade. Thanks, Donnie -- gentoo-dev@gentoo.org mailing list ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild 2007-09-24 19:56 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild Donnie Berkholz @ 2007-09-24 20:28 ` Bo Ørsted Andresen 2007-09-26 8:47 ` [gentoo-dev] " Steve Long 2007-09-25 5:29 ` [gentoo-dev] " Peter Volkov 1 sibling, 1 reply; 7+ messages in thread From: Bo Ørsted Andresen @ 2007-09-24 20:28 UTC (permalink / raw To: gentoo-dev [-- Attachment #1: Type: text/plain, Size: 603 bytes --] On Monday 24 September 2007 21:56:49 Donnie Berkholz wrote: > > if [[ "$(gcc-major-version)" -gt "3" ]] || \ > > ( [[ "$(gcc-major-version)" -eq "3" ]] && [[ "$(gcc-minor-version)" -gt "3" ]] ) > > Code block { } might be good here instead of a subshell, or perhaps it > could use logic that's less convoluted such as if..then. Also don't need > the double quotes. Or it could be as simple as: if [[ $(gcc-major-version) -gt 3 || \ ( $(gcc-major-version) -eq 3 && $(gcc-minor-version) -gt 3 ) ]] [[ allows grouping of conditions without spawning subshells. -- Bo Andresen [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild 2007-09-24 20:28 ` Bo Ørsted Andresen @ 2007-09-26 8:47 ` Steve Long 2007-09-26 10:12 ` Steve Long 0 siblings, 1 reply; 7+ messages in thread From: Steve Long @ 2007-09-26 8:47 UTC (permalink / raw To: gentoo-dev Bo Ørsted Andresen wrote: > On Monday 24 September 2007 21:56:49 Donnie Berkholz wrote: >> > if [[ "$(gcc-major-version)" -gt "3" ]] || \ >> > ( [[ "$(gcc-major-version)" -eq "3" ]] && [[ "$(gcc-minor-version)" -gt >> > "3" ]] ) >> >> Code block { } might be good here instead of a subshell, or perhaps it >> could use logic that's less convoluted such as if..then. Also don't need >> the double quotes. > > Or it could be as simple as: > > if [[ $(gcc-major-version) -gt 3 || \ > ( $(gcc-major-version) -eq 3 && $(gcc-minor-version) -gt 3 ) ]] > > [[ allows grouping of conditions without spawning subshells. > http://wooledge.org/mywiki/BashFAQ#faq31 explains the differences between [[ and [, although in this case I'd use: if ((gcc-major-version>3 || (gcc-major-version==3 && gcc-minor-version>3) )) "As a rule of thumb, [[ is used for strings and files. If you want to compare numbers, use an ArithmeticExpression." -- gentoo-dev@gentoo.org mailing list ^ permalink raw reply [flat|nested] 7+ messages in thread
* [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild 2007-09-26 8:47 ` [gentoo-dev] " Steve Long @ 2007-09-26 10:12 ` Steve Long 0 siblings, 0 replies; 7+ messages in thread From: Steve Long @ 2007-09-26 10:12 UTC (permalink / raw To: gentoo-dev Steve Long wrote: > Bo Ørsted Andresen wrote: > >> On Monday 24 September 2007 21:56:49 Donnie Berkholz wrote: >>> > if [[ "$(gcc-major-version)" -gt "3" ]] || \ >>> > ( [[ "$(gcc-major-version)" -eq "3" ]] && [[ "$(gcc-minor-version)" >>> > -gt "3" ]] ) >>> >>> Code block { } might be good here instead of a subshell, or perhaps it >>> could use logic that's less convoluted such as if..then. Also don't need >>> the double quotes. >> >> Or it could be as simple as: >> >> if [[ $(gcc-major-version) -gt 3 || \ >> ( $(gcc-major-version) -eq 3 && $(gcc-minor-version) -gt 3 ) ]] >> >> [[ allows grouping of conditions without spawning subshells. >> > http://wooledge.org/mywiki/BashFAQ#faq31 explains the differences between > [[ and [, although in this case I'd use: > if ((gcc-major-version>3 || (gcc-major-version==3 && gcc-minor-version>3) > )) > > "As a rule of thumb, [[ is used for strings and files. If you want to > compare numbers, use an ArithmeticExpression." > > Er missed that it's a function call (thanks zlin) but the general point applies (and tbh I wouldn't call the function twice in any case, so Donnie's point re logic might be more cogent.) -- gentoo-dev@gentoo.org mailing list ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild 2007-09-24 19:56 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild Donnie Berkholz 2007-09-24 20:28 ` Bo Ørsted Andresen @ 2007-09-25 5:29 ` Peter Volkov 2007-09-25 6:21 ` Mike Frysinger 2007-09-25 6:25 ` Rémi Cardona 1 sibling, 2 replies; 7+ messages in thread From: Peter Volkov @ 2007-09-25 5:29 UTC (permalink / raw To: gentoo-dev [-- Attachment #1: Type: text/plain, Size: 408 bytes --] В Пнд, 24/09/2007 в 12:56 -0700, Donnie Berkholz пишет: > > if use ppc ; then > > sed -i -e 's:-Werror::g' src/Makefile > > fi > > We should never leave -Werror in -- make this unconditional. "never" is too strong: for example, wireshark's upstream told me that they want code to be built with -Werror. If something breaks they are interested in report to fix that. -- Peter. [-- Attachment #2: Эта часть сообщения подписана цифровой подписью --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild 2007-09-25 5:29 ` [gentoo-dev] " Peter Volkov @ 2007-09-25 6:21 ` Mike Frysinger 2007-09-25 6:25 ` Rémi Cardona 1 sibling, 0 replies; 7+ messages in thread From: Mike Frysinger @ 2007-09-25 6:21 UTC (permalink / raw To: gentoo-dev [-- Attachment #1: Type: text/plain, Size: 1071 bytes --] On Tuesday 25 September 2007, Peter Volkov wrote: > В Пнд, 24/09/2007 в 12:56 -0700, Donnie Berkholz пишет: > > > if use ppc ; then > > > sed -i -e 's:-Werror::g' src/Makefile > > > fi > > > > We should never leave -Werror in -- make this unconditional. > > "never" is too strong: for example, wireshark's upstream told me that > they want code to be built with -Werror. If something breaks they are > interested in report to fix that. not really ... what builds today on $arch with $gcc_version is no guarantee it'll work on any other $arch or $gcc_version (and considering the change of warnings in gcc, this makes it likely) -Werror makes sense in development code, but not releases (ever) ... forcing -Werror just makes for annoyed users and that flag really should be an "opt-in" thing (aka, put it in your CFLAGS) this is exactly why the werror stuff in binutils has been disabled for pretty much ever then again, while i think it's pretty stupid, i'm not about to go around and force people to remove it ... -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 827 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild 2007-09-25 5:29 ` [gentoo-dev] " Peter Volkov 2007-09-25 6:21 ` Mike Frysinger @ 2007-09-25 6:25 ` Rémi Cardona 1 sibling, 0 replies; 7+ messages in thread From: Rémi Cardona @ 2007-09-25 6:25 UTC (permalink / raw To: gentoo-dev Peter Volkov wrote: > В Пнд, 24/09/2007 в 12:56 -0700, Donnie Berkholz пишет: >>> if use ppc ; then >>> sed -i -e 's:-Werror::g' src/Makefile >>> fi >> We should never leave -Werror in -- make this unconditional. > > "never" is too strong: for example, wireshark's upstream told me that > they want code to be built with -Werror. If something breaks they are > interested in report to fix that. Gstreamer devs also use this, but only when you check out code from CVS. They take it out for releases. Imho, it's the best of both worlds. If you want to see what kind of mess leaving stuff like -Werror can cause, check out this bug : https://bugs.gentoo.org/193369 Cheers :) Rémi -- gentoo-dev@gentoo.org mailing list ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-09-26 10:43 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <E1IZrhe-0008Hx-Hy@stork.gentoo.org> 2007-09-24 19:56 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild Donnie Berkholz 2007-09-24 20:28 ` Bo Ørsted Andresen 2007-09-26 8:47 ` [gentoo-dev] " Steve Long 2007-09-26 10:12 ` Steve Long 2007-09-25 5:29 ` [gentoo-dev] " Peter Volkov 2007-09-25 6:21 ` Mike Frysinger 2007-09-25 6:25 ` Rémi Cardona
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox