[gentoo-dev] eutils.class fix for make_desktop_entry

[gentoo-dev] eutils.class fix for make_desktop_entry

[Alfredo Tupone]

I need to add a desktop entry that call an executable with arguments.
Actually the entry Exec (that could contain the executable with
parameters) and the entry TryExec (used to test if the executable is
installed) are set to the same value.
I wonder if I can fix that with the following patch to the eutils eclass
@@ -900,7 +902,7 @@
 Type=Application
 Comment=${DESCRIPTION}
 Exec=${exec}
-TryExec=${exec}
+TryExec=${exec%% *}
 Path=${path}
 Icon=${icon}
 Categories=Application;${type};" > "${desktop}"

I meant: is there some ebuild that has space in the executable name, or
is there some way this change can break ebuilds. eutils is used by lot
of them, so I'm scared to break the whole tree.

Going to apply if I get no negative answer in, say, 10 days.

Alfredo

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] eutils.class fix for make_desktop_entry

[Chris Gianelloni]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

On Mon, 2006-06-05 at 00:13 +0200, Alfredo Tupone wrote:
> Going to apply if I get no negative answer in, say, 10 days.

Go ahead and do it now.  It really shouldn't break anything, as I can't
think of a single thing using make_desktop _entry with a space in the
executable name.

-- 
Chris Gianelloni
Release Engineering - Strategic Lead
x86 Architecture Team
Games - Developer
Gentoo Linux

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] eutils.class fix for make_desktop_entry

[Denis Dupeyron]

On 6/5/06, Chris Gianelloni <wolf31o2@gentoo.org> wrote:

> Go ahead and do it now.  It really shouldn't break anything, as I can't
> think of a single thing using make_desktop _entry with a space in the
> executable name.

What about games-board/gnubg-0.14.3 ?

Denis.
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] eutils.class fix for make_desktop_entry

[Chris Gianelloni]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Mon, 2006-06-05 at 17:24 +0000, Denis Dupeyron wrote:
> On 6/5/06, Chris Gianelloni <wolf31o2@gentoo.org> wrote:
> 
> > Go ahead and do it now.  It really shouldn't break anything, as I can't
> > think of a single thing using make_desktop _entry with a space in the
> > executable name.
> 
> What about games-board/gnubg-0.14.3 ?

There's no space in the executable name.

-- 
Chris Gianelloni
Release Engineering - Strategic Lead
x86 Architecture Team
Games - Developer
Gentoo Linux

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]