From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
	by nuthatch.gentoo.org with esmtp (Exim 4.54)
	id 1FE9GX-0006kc-Lc
	for garchives@archives.gentoo.org; Tue, 28 Feb 2006 18:08:06 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
	by robin.gentoo.org (8.13.5/8.13.5) with SMTP id k1SI5aPR030781;
	Tue, 28 Feb 2006 18:05:36 GMT
Received: from smtp.gentoo.org (smtp.gentoo.org [134.68.220.30])
	by robin.gentoo.org (8.13.5/8.13.5) with ESMTP id k1SHx0PL029605
	for <gentoo-dev@lists.gentoo.org>; Tue, 28 Feb 2006 17:59:00 GMT
Received: from dslb-084-063-015-092.pools.arcor-ip.net ([84.63.15.92] helo=[10.0.0.13])
	by smtp.gentoo.org with esmtpa (Exim 4.54)
	id 1FE98a-0001gk-Qg
	for gentoo-dev@lists.gentoo.org; Tue, 28 Feb 2006 17:59:53 +0000
Subject: Re: [gentoo-dev] [RFC] QA Team's role
From: Patrick Lauer <patrick@gentoo.org>
To: gentoo-dev@lists.gentoo.org
In-Reply-To: <20060228173810.3e209be2@snowdrop.home>
References: <20060226222217.GB17257@aerie.halcy0n.com>
	 <1140997703.12229.166.camel@demandred.gnqs.org>
	 <20060227003413.GE17257@aerie.halcy0n.com>
	 <b38c6f4c0602270100k73226152pd7050252c654da9@mail.gmail.com>
	 <20060227170834.075e9388@snowdrop.home>
	 <1141071970.804.19.camel@demandred.gnqs.org>
	 <20060227203709.2a7bff47@snowdrop.home>
	 <1159375278.20060227214923@gentoo.org>
	 <20060227213321.7ee405ec@snowdrop.home>
	 <394439379.20060228103817@gentoo.org>
	 <20060228145246.67dee076@snowdrop.home> <1141139552.2741.2.camel@localhost>
	 <7310506941.20060228162637@gentoo.org>
	 <20060228154246.3e34d340@snowdrop.home>
	 <1141143118.2741.18.camel@localhost>
	 <20060228163532.273200be@snowdrop.home>
	 <1232307950.20060228180003@gentoo.org>
	 <20060228170954.37396045@snowdrop.home>
	 <16410671399.20060228183024@gentoo.org>
	 <20060228173810.3e209be2@snowdrop.home>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-tStu9lBFj38qgpL53QKM"
Organization: Gentoo
Date: Tue, 28 Feb 2006 18:59:49 +0100
Message-Id: <1141149589.10641.12.camel@localhost>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
X-Mailer: Evolution 2.4.2.1 
X-Archives-Salt: 5348cc94-e1db-4d1d-93de-1d4552e90d0b
X-Archives-Hash: 16b23cd7a7bdaaab5fceecc079ce1d2d


--=-tStu9lBFj38qgpL53QKM
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 2006-02-28 at 17:38 +0000, Ciaran McCreesh wrote:
> Sheesh, you'll probably claim that this isn't broken next too:
>=20
>     if [ "${IS_UPGRADE}" =3D "1" ] ; then
>         einfo "Removing old version ${REMOVE_PKG}"
>=20
>         emerge -C "${REMOVE_PKG}"
>     fi
Ciaran,
(and this is valid for all emails to technical lists,)
please save us some time and many emails by stating what is wrong when
you show a QA violation.
Many among us don't think in assembler and don't know enough about the
code to decide if/why something is wrong. This in turn causes someone
(like me) to send an email asking what is wrong, causing another reply
by you etc. etc.

It's a bit like me stating:
"The bug is in line 14:
	i+=3D2
"
If you don't know the code you won't understand why.

Now if I said "line 14 increments by two, but then you won't ever get
out of the loop since the exit condition won't be met" everyone could
understand it and evaluate my statement.

If you show a wrong code snippet please explain _why_ it is wrong in the
same email.

Thanks,

Patrick

--=20
Stand still, and let the rest of the universe move

--=-tStu9lBFj38qgpL53QKM
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1-ecc0.1.6 (GNU/Linux)

iD8DBQBEBI+UqER3hOUoZM4RAjzxAJ9tvaSOY3625NaptPTj/yLxXrIXJACeITwy
43JQjZpI+HEckc6Mla3f9l0=
=so5q
-----END PGP SIGNATURE-----

--=-tStu9lBFj38qgpL53QKM--

-- 
gentoo-dev@gentoo.org mailing list