[gentoo-dev] death to underquoted M4 definitions

[gentoo-dev] death to underquoted M4 definitions

[Aaron Walker]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Fellow devs,

I'd like to propose a new function for eutils.eclass that fixes m4 files so
that aclocal doesn't produce those annoying underquoted definition warnings
when invoked.

fix_underquoted_m4defs() {
	local m4
	for m4 in $(find ${S} -name '*.m4*' -type f) ; do
		[[ ${m4} == *aclocal.m4 || ${m4} == *acinclude.m4 ]] && \
			continue
		sed -i \
	's|^\(.*AC_DEFUN(\)\([^[:punct:]][[:print:]]\+\),\(.*\)$|\1[\2],\3|g' \
		${m4}
	done
}

ebuilds that install m4's with underquoted defs (there's quite a few) can then
just call this in src_unpack (until fixed upstream of course).

Comments?
- --
"I'm a mean green mother from outer space"
 -- Audrey II, The Little Shop of Horrors

Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCiu/vC3poscuANHARAhQ+AJ9lDHZDIkWG/5GRZoZgbo1/HrwrawCg3z1E
5jXrjwzz4gdCX30bshuI1mo=
=TrEG
-----END PGP SIGNATURE-----

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Wednesday 18 May 2005 09:34, Aaron Walker wrote:
> Comments?
Hmm I'm not sure about adding a "band-aid function"... fixing the underquoted 
definitions is usually trivial and requires just a little little patch.
Adding a function surely will remove the need for a patch for package, and 
this is good, but I'm not sure about the sed expression.
You tried it with bsd sed anyway? :)

So the problem is: the patch will remove the need for all the patches? In this 
case, I think I'd love it :)

-- 
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)

http://dev.gentoo.org/~flameeyes/


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] death to underquoted M4 definitions

[Aaron Walker]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Diego 'Flameeyes' Pettenò wrote:

> You tried it with bsd sed anyway? :)

sed is still aliased to gsed, no?

- --
One good turn usually gets most of the blanket.

Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCi0ZBC3poscuANHARAnPWAJ99cld19pXKjq5w3ozPxTKhi8OyIACdEyrd
GeqnG/myFViA9JOaRD74uX0=
=QlfG
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

On Wednesday 18 May 2005 15:42, Aaron Walker wrote:
> sed is still aliased to gsed, no?
Yes but I don't trust sed calls which depends on specific behaviour of gnu 
tools.

-- 
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)

http://dev.gentoo.org/~flameeyes/


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] death to underquoted M4 definitions

[Stephen Bennett]

On Wed, 2005-05-18 at 09:42 -0400, Aaron Walker wrote:
> sed is still aliased to gsed, no?

Yes, but I want to kill that if possible.

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Daniel]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Wed, 18 May 2005 05:34 pm, Aaron Walker wrote:
> Fellow devs,
>
> I'd like to propose a new function for eutils.eclass that fixes m4 files so
> that aclocal doesn't produce those annoying underquoted definition warnings
> when invoked.
>
> fix_underquoted_m4defs() {
>
> Comments?

Sounds great! Good one Aaron.

>
> Aaron Walker <ka0ttic@gentoo.org>
> [ BSD | cron | forensics | shell-tools | commonbox | netmon | vim |
> web-apps ]

-- 
Daniel Black <dragonheart@gentoo.org>
Gentoo Crypto/PPC/dev-embedded/Forensics/NetMon

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] death to underquoted M4 definitions

[Mike Frysinger]

On Wednesday 18 May 2005 03:34 am, Aaron Walker wrote:
> I'd like to propose a new function for eutils.eclass that fixes m4 files so
> that aclocal doesn't produce those annoying underquoted definition warnings
> when invoked.

i'd have to agree with Diego ... i'd rather see people add patches that change 
1 line in .m4 files ... in fact, ive already patched a bunch of the more 
common ones, i just didnt rev bump them :p
-mike
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Aaron Walker]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mike Frysinger wrote:
> On Wednesday 18 May 2005 03:34 am, Aaron Walker wrote:
> 
>>I'd like to propose a new function for eutils.eclass that fixes m4 files so
>>that aclocal doesn't produce those annoying underquoted definition warnings
>>when invoked.
> 
> 
> i'd have to agree with Diego ... i'd rather see people add patches that change 
> 1 line in .m4 files ... in fact, ive already patched a bunch of the more 
> common ones, i just didnt rev bump them :p
> -mike

Ok that's fine.  A function just seemed saner than adding 1 lines patches to
dozens of packages.

- --
Well, I'm disenchanted too.  We're all disenchanted.
		-- James Thurber

Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCi0WkC3poscuANHARAnoPAJ94jLQr6NDnWlhuLF/99X1Aw4zHNgCghge4
ZS1y9lp9u37MIBjn64fxL6g=
=QeBL
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Donnie Berkholz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Walker wrote:
> Ok that's fine.  A function just seemed saner than adding 1 lines patches to
> dozens of packages.

It may be easier, but upstream would appreciate us sending a patch
instead of just fixing stuff locally.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCi1sIXVaO67S1rtsRAk7yAKCcYrqqV8qwPlVv0tBSiBN0rbFmtQCg3LrB
DhIYcAEuc4Qn1YJsXsTuF5A=
=xgVC
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Aaron Walker]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Donnie Berkholz wrote:
> Aaron Walker wrote:
> 
>>>Ok that's fine.  A function just seemed saner than adding 1 lines patches to
>>>dozens of packages.
> 
> 
> It may be easier, but upstream would appreciate us sending a patch
> instead of just fixing stuff locally.

That was never my intention.  Notice my original message said "until fixed
upstream".  I probably should have made this more clear.

- --
Since we have to speak well of the dead, let's knock them while they're alive.
		-- John Sloan

Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCi2wxC3poscuANHARApLiAKDNMtpp5VeYspfzsYNYETq9M85VdwCgsZic
uAIHgSA2hxdjW3tN0Iab26Q=
=Ewsr
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

On Wednesday 18 May 2005 17:11, Donnie Berkholz wrote:
> It may be easier, but upstream would appreciate us sending a patch
> instead of just fixing stuff locally.
Not sure about this, we have also some not-so-friendly upstreams sometimes :)

Well anyway I hope all those can be fixed soon, so ...

-- 
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)

http://dev.gentoo.org/~flameeyes/


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] death to underquoted M4 definitions

[Harald van Dijk]

Mike Frysinger wrote:
> i'd have to agree with Diego ... i'd rather see people add patches that change 
> 1 line in .m4 files ... in fact, ive already patched a bunch of the more 
> common ones, i just didnt rev bump them :p
> -mike

The patch for xdelta (and possibly others) uses the full location as the
filename. This causes sandbox errors, because patch tries to modify the
m4 file in / (but, only if it exists and isn't patched already), instead
of the one in the working directory. Want a bug?
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

[Mike Frysinger]

On Wednesday 18 May 2005 01:16 pm, Harald van Dijk wrote:
> Mike Frysinger wrote:
> > i'd have to agree with Diego ... i'd rather see people add patches that
> > change 1 line in .m4 files ... in fact, ive already patched a bunch of
> > the more common ones, i just didnt rev bump them :p
> > -mike
>
> The patch for xdelta (and possibly others) uses the full location as the
> filename. This causes sandbox errors, because patch tries to modify the
> m4 file in / (but, only if it exists and isn't patched already), instead
> of the one in the working directory. Want a bug?

i think xdelta is the only one i screwed up, i'll fix it
-mike

-- 
gentoo-dev@gentoo.org mailing list