From: "Volkmar W. Pogatzki" <gentoo@pogatzki.net>
To: "gentoo-dev@lists.gentoo.org" <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME
Date: Mon, 29 May 2023 09:13:16 +0200 (CEST) [thread overview]
Message-ID: <1093286864.697740.1685344396997@email.ionos.de> (raw)
In-Reply-To: <uwn0v4h36@gentoo.org>
> Ulrich Mueller <ulm@gentoo.org> hat am 26.05.2023 10:44 CEST geschrieben:
>
>
> >>>>> On Fri, 26 May 2023, Volkmar W Pogatzki wrote:
>
> > -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
> > +if [[ ${SLOT} = 0 ]]; then
> > + JAVA_LAUNCHER_FILENAME="${PN}"
> > +else
> > + JAVA_LAUNCHER_FILENAME="${PN}-${SLOT}"
> > +fi
>
> This will no longer allow overriding the variable in the ebuild
> (at least not pre-inherit). Is this intentional?
>
> Ulrich
It exactly does what it's supposed to do.
No clue about "not pre-inherit". How to sanitize?
--
Volkmar W. Pogatzki
next prev parent reply other threads:[~2023-05-29 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 8:16 [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME Volkmar W. Pogatzki
2023-05-26 8:44 ` Ulrich Mueller
2023-05-29 7:13 ` Volkmar W. Pogatzki [this message]
2023-05-29 9:51 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093286864.697740.1685344396997@email.ionos.de \
--to=gentoo@pogatzki.net \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox