[gentoo-dev] update `strip-flags` to allow flags that disable stuff

[gentoo-dev] update `strip-flags` to allow flags that disable stuff

[Mike Frysinger]

i was trying to debug xorg-x11 and the CFLAGS that were causing it to segfault 
on my box when i found the following CFLAGS got mangled because of 
`strip-flags`:
CFLAGS="-O2 -march=pentium4 -mno-mmx -mno-sse -mno-sse2 -pipe"
suddenly xorg-x11 was built with:
CFLAGS="-O2 -march=pentium4 -pipe"

now, considering `strip-flags` is intended to 'sanitize' CFLAGS of all the 
crazy crap people stick in it for the purpose of not *over* optimizing, it 
seems like when people want to *disable* a few optimizations, they should :)

so my proposal is that `strip-flags` will allow any flag that begins with 
'-mno-' or '-fno-' ... any objections ?
-mike

--
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] update `strip-flags` to allow flags that disable stuff

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

On Sat, 17 Jul 2004 22:11:30 -0400 Mike Frysinger <vapier@gentoo.org>
wrote:
| so my proposal is that `strip-flags` will allow any flag that begins
| with '-mno-' or '-fno-' ... any objections ?

Bad idea. Filtering -mno-app-regs if it's in use globally will kill
things. Possibly the same for -mno-stack-bias.

-- 
Ciaran McCreesh : Gentoo Developer (Sparc, MIPS, Vim, Fluxbox)
Mail            : ciaranm at gentoo.org
Web             : http://dev.gentoo.org/~ciaranm


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] update `strip-flags` to allow flags that disable stuff

[Mike Frysinger]

On Saturday 17 July 2004 11:05 pm, Ciaran McCreesh wrote:
> On Sat, 17 Jul 2004 22:11:30 -0400 Mike Frysinger <vapier@gentoo.org>
>
> wrote:
> | so my proposal is that `strip-flags` will allow any flag that begins
> | with '-mno-' or '-fno-' ... any objections ?
>
> Bad idea. Filtering -mno-app-regs if it's in use globally will kill
> things. Possibly the same for -mno-stack-bias.

i think you mis-read what i'm doing ... or maybe i mis-read you ...

you're saying that if a user builds their system with CFLAGS="-mno-app-regs" 
and then tries to build a package that filters out that flag, the new package 
will break ?

if so, that's what is happening right now ... my proposal was to *change* that 
so that users can use -fno-* and -mno-* flags and *not* have them be filtered
-mike

--
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] update `strip-flags` to allow flags that disable stuff

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On Sat, 17 Jul 2004 23:18:55 -0400 Mike Frysinger <vapier@gentoo.org>
wrote:
| > | so my proposal is that `strip-flags` will allow any flag that
| > | begins with '-mno-' or '-fno-' ... any objections ?
| >
| > Bad idea. Filtering -mno-app-regs if it's in use globally will kill
| > things. Possibly the same for -mno-stack-bias.
| 
| i think you mis-read what i'm doing ... or maybe i mis-read you ...

Uh, I think I need lots more caffeine. Never mind me...

-- 
Ciaran McCreesh : Gentoo Developer (Sparc, MIPS, Vim, Fluxbox)
Mail            : ciaranm at gentoo.org
Web             : http://dev.gentoo.org/~ciaranm


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] update `strip-flags` to allow flags that disable stuff

[Brandon Hale]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On Sat, 2004-07-17 at 22:11 -0400, Mike Frysinger wrote:

> so my proposal is that `strip-flags` will allow any flag that begins with 
> '-mno-' or '-fno-' ... any objections ?
> -mike

Sounds great, I just hit this problem trying to temporarily add -fno-
stack-protector, which
got stripped.

Brandon Hale

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]