From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on finch.gentoo.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DMARC_NONE,MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=4.0.0 Received: from email.fidnet.com (ecomm2.fidnet.com [216.229.64.81]) by chiba.3jane.net (Postfix) with SMTP id B60BE20F0D96 for ; Fri, 5 Apr 2002 16:31:43 -0600 (CST) Received: (qmail 20116 invoked from network); 5 Apr 2002 20:22:04 -0000 Received: from dialup-mo-104.rolla.fidnet.com (HELO silica.localmosci) (216.229.74.104) by email.fidnet.com with SMTP; 5 Apr 2002 20:22:03 -0000 Subject: Re: [gentoo-dev] xcircuit From: "Tod M. Neidt" To: gentoo-dev@gentoo.org In-Reply-To: <1018006508.23449.7.camel@calle.lan> References: <3CAD6DF3.1020805@optushome.com.au> <1018006508.23449.7.camel@calle.lan> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Evolution/1.0 (Preview Release) Date: 05 Apr 2002 14:24:54 -0600 Message-Id: <1018038295.3095.0.camel@silica.localmosci> Mime-Version: 1.0 Sender: gentoo-dev-admin@gentoo.org Errors-To: gentoo-dev-admin@gentoo.org X-BeenThere: gentoo-dev@gentoo.org X-Mailman-Version: 2.0.6 Precedence: bulk Reply-To: gentoo-dev@gentoo.org List-Help: List-Post: List-Subscribe: , List-Id: Gentoo Linux developer list List-Unsubscribe: , List-Archive: X-Archives-Salt: ef4be671-29f3-4a0a-9f4f-567c19c73778 X-Archives-Hash: 9b665cd8643f6382430285a219a4be3e On Fri, 2002-04-05 at 05:35, Carl-Christian Salvesen wrote: > On Fri, 2002-04-05 at 11:27, michael wrote: > > could someone make an ebuild for the latest version of xcircuit? > > :) > > Looks like gentoo.org is down. Can you confirm that my ebuild works? > http://struct.homeip.net/gentoo/beta/ > > Just unpack it in /usr/portage and emerge xcircuit.. Hi! Already made one for xcircuit-2.5.4 (the website implies this one is prefereable). I added it to app-misc ( arguable where it should go). Although an official stable one might be nice too :) What follows is offered as constructive criticism. If you clean up your ebuild in light of the following comments, I would be more than happy to commit it for you. 1. Remove all the unnecessary comments leftover from the skel.ebuild. 2. This application has dependencies. Add them to DEPENDS, not everyone who will emerge this will already have all the dependencies merged. Read the docs, website, and/or 'ldd xcircuit' to figure out the dependencies. 3. Although it doesn't hurt anything, this app has no info file so the --info= line in the configure can be removed. 4. xcircuit-2.5.4 had a non-fatal compile error related to parameter.c looking for menudep.h with a parallel compile (emake) and needed to be compiled with a ordinary make to avoid this. Did you confirm that xcircuit-2.3.3 compiled without error? Although the app runs, I imagine that the functionality is impaired. Your contributions to Gentoo Linux are appreciated. Tidy up your xcircuit-2.3.3.ebuild and mail it as an attachement to tod@gentoo.org and we'll get it committed into the portage tree. Thanks! tod P.S. You can also refer to app-misc/xcircuit/xcircuit-2.5.4.ebuild