From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on finch.gentoo.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DMARC_NONE,MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=4.0.0 Received: from email.fidnet.com (ecomm2.fidnet.com [216.229.64.81]) by chiba.3jane.net (Postfix) with SMTP id 576DD200B11A for ; Tue, 5 Feb 2002 10:07:00 -0600 (CST) Received: (qmail 5427 invoked from network); 5 Feb 2002 16:06:00 -0000 Received: from dialup-mo-34.rolla.fidnet.com (HELO silica.localmosci) (216.229.74.34) by email.fidnet.com with SMTP; 5 Feb 2002 16:06:00 -0000 Subject: Re: [gentoo-dev] Is it acceptable to use 'sed' in ebuild scripts? From: "Tod M. Neidt" To: gentoo-dev@gentoo.org In-Reply-To: <20020205071829.GA7427@shellak.helsinki.fi> References: <20020205074151.538ab331.bob@evil-core.com> <20020205071829.GA7427@shellak.helsinki.fi> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Evolution/1.0 (Preview Release) Date: 05 Feb 2002 10:05:43 -0600 Message-Id: <1012925144.20718.40.camel@silica.localmosci> Mime-Version: 1.0 Sender: gentoo-dev-admin@gentoo.org Errors-To: gentoo-dev-admin@gentoo.org X-BeenThere: gentoo-dev@gentoo.org X-Mailman-Version: 2.0.6 Precedence: bulk Reply-To: gentoo-dev@gentoo.org List-Help: List-Post: List-Subscribe: , List-Id: Gentoo Linux developer list List-Unsubscribe: , List-Archive: X-Archives-Salt: ef7f4540-a878-4d67-a0ee-580d58dec62f X-Archives-Hash: 67ccec36c402bf462bee5300bca065c8 On Tue, 2002-02-05 at 01:18, Einar Karttunen wrote: > On 05.02.02 07:41 -0500(+0000), Bob Phan wrote: > > Hello, I've just recently created an ebuild for nethack (put it in > > app-games/nethack), however, it's build does not use the standard GNU > > autoconf/automake system, but rather forces you to manually edit a config.h > > file. Currently, I have just made a patch for X support that is applied when > > you "use X". I would like to add Qt and GNOME optional support, but using > > patches, it is very difficult to have one without the other, or the context > > will not match (very messy). I was instead wondering if using 'sed' within > > ebuild scripts was accepted practice, or if I should stick a dependancy for > > sed at the top of the file. > > Yes, many ebuilds use sed > find /usr/portage/ -name '*ebuild' -exec grep -l 'sed -e' '{}' ';' 2>/dev/null|cut -d/ -f-5|uniq|wc -l > 300 > So I don't think it will be banned in the near future. > As Einar said, many ebuilds use 'sed'. A particularly good example that you might want to take a look at is dev-lang/python-2.2-r4. Hope that helps, tod