[gentoo-dev] All Developers!

[gentoo-dev] All Developers!

[Mikael Hallendal]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Hi!

A while back drobbins mailed about the issue that A= shouldn't be set by
the ebuild-editor. It's set automatically by Portage. He also said that
it should be removed. I'm surprised to see that some developers still
updates ebuilds and leaves 'A=' there.

Same thing about try->die. If you edit/update an ebuild, please fix this
kinds of issues before commiting it.

I'm currently fixing lots of ebuilds but it's hard work.

Regards,
  Mikael Hallendal

-- 

Mikael Hallendal
Gentoo Linux Developer, Desktop Team Leader
CodeFactory AB, Stockholm, Sweden


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] All Developers!

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Sat, 2001-11-10 at 13:34, Mikael Hallendal wrote:
> Hi!
> 
> A while back drobbins mailed about the issue that A= shouldn't be set by
> the ebuild-editor. It's set automatically by Portage. He also said that
> it should be removed. I'm surprised to see that some developers still
> updates ebuilds and leaves 'A=' there.
> 
> Same thing about try->die. If you edit/update an ebuild, please fix this
> kinds of issues before commiting it.
> 
> I'm currently fixing lots of ebuilds but it's hard work.
> 
> Regards,
>   Mikael Hallendal

also remember to convert to tabs!


-- 

Martin Schlemmer
Gentoo Linux Developer, Desktop Team Developer
Cape Town, South Africa


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

[gentoo-dev] Re: All Developers!

[Andreas Voegele]

Martin Schlemmer writes:

> On Sat, 2001-11-10 at 13:34, Mikael Hallendal wrote:
> 
> > I'm currently fixing lots of ebuilds but it's hard work.
>
> also remember to convert to tabs!

DEPEND="virtual/glibc
        >=sys-libs/db-3.2
^^^^^^^^

Do you put spaces or a single tab in front of dependencies?

I prefer 8 spaces since I've set the tabwidth to 4.  But if everbody
else uses a tab I'll use a tab too.

I don't like the combination of tabs and spaces in RDEPEND very much
though.  If the tabwidth is set to 4 the output looks like this:

DEPEND="virtual/glibc
    virtual/x11
RDEPEND="virtual/glibc
     virtual/x11

There are 4 "spaces" at the beginning of the second line and 5
"spaces" in the fourth line.

IMHO either a single tab should be used in both cases or 8 spaces
should be used in the first case and 9 spaces in the second case.

On the other hand, there are more important things than the number of
tabs and spaces in front of dependencies :-)

-- 
Andreas

Re: [gentoo-dev] Re: All Developers!

[Mikael Hallendal]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

lör 2001-11-10 klockan 13.58 skrev Andreas Voegele:
> Martin Schlemmer writes:
> 
> > On Sat, 2001-11-10 at 13:34, Mikael Hallendal wrote:
> > 
> > > I'm currently fixing lots of ebuilds but it's hard work.
> >
> > also remember to convert to tabs!

Hi!

I just thought of this. What we said was that it should be tabs and that
it doesn't matter what the width is for the tab. But I think that it
does and that everybody should use tabwidth 4, because that makes it
possible to structure the ebuild to look nice.

I've always used tabwidth:8 and structured my ebuilds to look good for
that. But they don't for someone with tabwidth:4.

Regards,
  Mikael Hallendal
 
> DEPEND="virtual/glibc
>         >=sys-libs/db-3.2
> ^^^^^^^^
> 
> Do you put spaces or a single tab in front of dependencies?
> 
> I prefer 8 spaces since I've set the tabwidth to 4.  But if everbody
> else uses a tab I'll use a tab too.
> 
> I don't like the combination of tabs and spaces in RDEPEND very much
> though.  If the tabwidth is set to 4 the output looks like this:
> 
> DEPEND="virtual/glibc
>     virtual/x11
> RDEPEND="virtual/glibc
>      virtual/x11
> 
> There are 4 "spaces" at the beginning of the second line and 5
> "spaces" in the fourth line.
> 
> IMHO either a single tab should be used in both cases or 8 spaces
> should be used in the first case and 9 spaces in the second case.
> 
> On the other hand, there are more important things than the number of
> tabs and spaces in front of dependencies :-)
> 
> -- 
> Andreas
> 
> _______________________________________________
> gentoo-dev mailing list
> gentoo-dev@cvs.gentoo.org
> http://cvs.gentoo.org/mailman/listinfo/gentoo-dev
> 
-- 

Mikael Hallendal
Gentoo Linux Developer, Desktop Team Leader
CodeFactory AB, Stockholm, Sweden


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] Re: All Developers!

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]

On Sat, 2001-11-10 at 14:58, Andreas Voegele wrote:
> Martin Schlemmer writes:
> 
Hi

> > On Sat, 2001-11-10 at 13:34, Mikael Hallendal wrote:
> > 
> > > I'm currently fixing lots of ebuilds but it's hard work.
> >
> > also remember to convert to tabs!
> 
> DEPEND="virtual/glibc
>         >=sys-libs/db-3.2
> ^^^^^^^^
> 
> Do you put spaces or a single tab in front of dependencies?
> 
a single tab.

> I prefer 8 spaces since I've set the tabwidth to 4.  But if everbody
> else uses a tab I'll use a tab too.
> 
then i guess you will have to start using a tabwidth of 4, or live with
it, as it is the wish of drobbins :)

> I don't like the combination of tabs and spaces in RDEPEND very much
> though.  If the tabwidth is set to 4 the output looks like this:
> 
> DEPEND="virtual/glibc
>     virtual/x11
> RDEPEND="virtual/glibc
>      virtual/x11
> 
> There are 4 "spaces" at the beginning of the second line and 5
> "spaces" in the fourth line.
> 
> IMHO either a single tab should be used in both cases or 8 spaces
> should be used in the first case and 9 spaces in the second case.
> 
> On the other hand, there are more important things than the number of
> tabs and spaces in front of dependencies :-)
> 
true, but we need consistancy.

> -- 
> Andreas

-- 

Martin Schlemmer
Gentoo Linux Developer, Desktop Team Developer
Cape Town, South Africa


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] All Developers!

[Karl Trygve Kalleberg]

On 10 Nov 2001 12:34:15 +0100
Mikael Hallendal <hallski@gentoo.org> wrote:

> Hi!
> 
> A while back drobbins mailed about the issue that A= shouldn't be set by
> the ebuild-editor. It's set automatically by Portage. He also said that
> it should be removed. I'm surprised to see that some developers still
> updates ebuilds and leaves 'A=' there.
> 
> Same thing about try->die. If you edit/update an ebuild, please fix this
> kinds of issues before commiting it.
> 
> I'm currently fixing lots of ebuilds but it's hard work.

The ebuildchecker posted earlier will tell you which ebuilds are affected
by tab bugs, A= settings and the use of try, among other things.

I have been thinking of writing a cleanup script that fixes most of these
things automatically. It would mean that we developers would only have to
look over the ebuilds instead of actually doing the rewrites. However, it
might turn out to be a complete mess, so unless we think this is a Big
Issue, I'd rather spend my time elsewhere.

Karl T

Re: [gentoo-dev] All Developers!

[Mikael Hallendal]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

lör 2001-11-10 klockan 16.56 skrev Karl Trygve Kalleberg:
> On 10 Nov 2001 12:34:15 +0100
> Mikael Hallendal <hallski@gentoo.org> wrote:
> 
> > Hi!
> > 
> > A while back drobbins mailed about the issue that A= shouldn't be set by
> > the ebuild-editor. It's set automatically by Portage. He also said that
> > it should be removed. I'm surprised to see that some developers still
> > updates ebuilds and leaves 'A=' there.
> > 
> > Same thing about try->die. If you edit/update an ebuild, please fix this
> > kinds of issues before commiting it.
> > 
> > I'm currently fixing lots of ebuilds but it's hard work.
> 
> The ebuildchecker posted earlier will tell you which ebuilds are affected
> by tab bugs, A= settings and the use of try, among other things.
> 
> I have been thinking of writing a cleanup script that fixes most of these
> things automatically. It would mean that we developers would only have to
> look over the ebuilds instead of actually doing the rewrites. However, it
> might turn out to be a complete mess, so unless we think this is a Big
> Issue, I'd rather spend my time elsewhere.

The A=-issue is pretty straight forward, just grep for A= (same for
try).

I think the time you have to spend on writing some script that would do
this automatic would be to great to be meaningful. Also, when going
through all ebuilds developers can fix other things, such as style-fixes
and such.

We should write some spec. on how ebuilds should look like (guidelines
for style) and then make a emacs and a vi mode for editing ebuilds that
controls the style.

Currently ebuilds looks very different from each other confusing people.

Regards,
  Mikael Hallendal

-- 

Mikael Hallendal
Gentoo Linux Developer, Desktop Team Leader
CodeFactory AB, Stockholm, Sweden


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

[gentoo-dev] Re: All Developers!

[Andreas Voegele]

Mikael Hallendal writes:

> We should write some spec. on how ebuilds should look like
> (guidelines for style) and then make a emacs and a vi mode for
> editing ebuilds that controls the style.

If only tabs and *no* spaces were allowed at the beginning of lines it
would be very easy to check ebuild scripts for wrong spaces.

We could rip the required code from the Emacs Makefile mode, which
checks for suspicious tabs and highlights these areas when a user
tries to save the Makefile.

BTW, if a single tab was used in front of dependencies the output
would look like this:

tabwidth 4:

DEPEND="virtual/glibc
    virtual/x11
RDEPEND="virtual/glibc
    virtual/x11

tabwidth 8:

DEPEND="virtual/glibc
        virtual/x11
RDEPEND="virtual/glibc
        virtual/x11

IMHO both outputs look good, and with this solution developers could
still set the tabwidth to 4 or 8.

-- 
Andreas

Re: [gentoo-dev] Re: All Developers!

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

On Sat, 2001-11-10 at 18:03, Andreas Voegele wrote:
> Mikael Hallendal writes:
> 
> > We should write some spec. on how ebuilds should look like
> > (guidelines for style) and then make a emacs and a vi mode for
> > editing ebuilds that controls the style.
> 
> If only tabs and *no* spaces were allowed at the beginning of lines it
> would be very easy to check ebuild scripts for wrong spaces.
> 
> We could rip the required code from the Emacs Makefile mode, which
> checks for suspicious tabs and highlights these areas when a user
> tries to save the Makefile.
> 
> BTW, if a single tab was used in front of dependencies the output
> would look like this:
> 
> tabwidth 4:
> 
> DEPEND="virtual/glibc
>     virtual/x11
> RDEPEND="virtual/glibc
>     virtual/x11
> 
> tabwidth 8:
> 
> DEPEND="virtual/glibc
>         virtual/x11
> RDEPEND="virtual/glibc
>         virtual/x11
> 
> IMHO both outputs look good, and with this solution developers could
> still set the tabwidth to 4 or 8.
> 
> -- 
> Andreas

true, but that is not a problem, take for instance:

        make prefix=${D}/usr                        \
             sysconfdir=${D}/etc                    \
             localstatedir=${D}/var/lib             \
             install || die

this is how Hallski and I do things (with a tabwidth of 8)

Now take the same piece with a tabwidht of 4:
    make prefix=${D}/usr                        \
         sysconfdir=${D}/etc                    \
         localstatedir=${D}/var/lib                 \
         install || die 

The '\' is not aligned anymore. this is however a simple example, as
other ebuilds gets ripped out of form more.


Greetings,
-- 

Martin Schlemmer
Gentoo Linux Developer, Desktop Team Developer
Cape Town, South Africa


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] Re: All Developers!

[Chad Huneycutt]

Andreas Voegele wrote:

BTW, if a single tab was used in front of dependencies the output
> would look like this:
> 
> tabwidth 4:
> 
> DEPEND="virtual/glibc
>     virtual/x11
> RDEPEND="virtual/glibc
>     virtual/x11
> 
> tabwidth 8:
> 
> DEPEND="virtual/glibc
>         virtual/x11
> RDEPEND="virtual/glibc
>         virtual/x11
> 
> IMHO both outputs look good, and with this solution developers could
> still set the tabwidth to 4 or 8.

The problem with tabs comes in when you do stuff like:

local t
local u
t = "some string like this"        # comment here
u = "some other longer string"     # another comment

The comments will not necessarily line up when tabwidths are different.

Chad

Re: [gentoo-dev] Re: All Developers!

[Daniel Robbins]

On Sat, Nov 10, 2001 at 11:36:58AM -0500, Chad Huneycutt wrote:

> The problem with tabs comes in when you do stuff like:
> 
> local t
> local u
> t = "some string like this"        # comment here
> u = "some other longer string"     # another comment
> 
> The comments will not necessarily line up when tabwidths are different.

OK, if people need rules, I can provide them:

1) Use one tab per indent

2) Put comments on separate lines

3) Avoid using "/" line continuation characters and use long lines instead.

Best Regards,

-- 
Daniel Robbins					<drobbins@gentoo.org>
Chief Architect/President			http://www.gentoo.org 
Gentoo Technologies, Inc.			

Re: [gentoo-dev] Re: All Developers!

[Chris Houser]

Daniel Robbins wrote:                 [Sat Nov 10 2001,  1:24:42PM EST]         
> OK, if people need rules, I can provide them:
> 
> 1) Use one tab per indent
> 
> 2) Put comments on separate lines
> 
> 3) Avoid using "/" line continuation characters and use long lines instead.

Oh, please not 3) ... I realy dislike long lines.  I don't think it's
too big a deal if the line continuations don't line up for everybody.

--Chouser

Re: [gentoo-dev] Re: All Developers!

[Daniel Robbins]

On Sat, Nov 10, 2001 at 03:39:13PM -0500, Chris Houser wrote:
> Daniel Robbins wrote:                 [Sat Nov 10 2001,  1:24:42PM EST]         
> > OK, if people need rules, I can provide them:
> > 
> > 1) Use one tab per indent
> > 
> > 2) Put comments on separate lines
> > 
> > 3) Avoid using "/" line continuation characters and use long lines instead.
> 
> Oh, please not 3) ... I realy dislike long lines.  I don't think it's
> too big a deal if the line continuations don't line up for everybody.

OK, I'll amend 3.  Either you can use long lines, or you can use "/" line
continuation characters.  If you *do* use line continuation characters, you
should *not* try to tab align them so that they're "pretty".  Instead, follow
the line with a single space, then a "/", and then a newline.

:)

-- 
Daniel Robbins					<drobbins@gentoo.org>
Chief Architect/President			http://www.gentoo.org 
Gentoo Technologies, Inc.			

Re: [gentoo-dev] Re: All Developers!

[Aron Griffis]

Daniel Robbins wrote:	[Sat Nov 10 2001, 04:04:46PM EST]
> OK, I'll amend 3.  Either you can use long lines, or you can use "/" line
> continuation characters.  If you *do* use line continuation characters, you
> should *not* try to tab align them so that they're "pretty".  Instead, follow
> the line with a single space, then a "/", and then a newline.
> 
> :)

Thanks.  :-)

Aron

Re: [gentoo-dev] Re: All Developers!

[Mikael Hallendal]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

lör 2001-11-10 klockan 22.04 skrev Daniel Robbins:
> On Sat, Nov 10, 2001 at 03:39:13PM -0500, Chris Houser wrote:
> > Daniel Robbins wrote:                 [Sat Nov 10 2001,  1:24:42PM EST]         
> > > OK, if people need rules, I can provide them:
> > > 
> > > 1) Use one tab per indent
> > > 
> > > 2) Put comments on separate lines
> > > 
> > > 3) Avoid using "/" line continuation characters and use long lines instead.
> > 
> > Oh, please not 3) ... I realy dislike long lines.  I don't think it's
> > too big a deal if the line continuations don't line up for everybody.
> 
> OK, I'll amend 3.  Either you can use long lines, or you can use "/" line
> continuation characters.  If you *do* use line continuation characters, you
> should *not* try to tab align them so that they're "pretty".  Instead, follow
> the line with a single space, then a "/", and then a newline.

Hmm .. imho it's much easier to read with the \ aligned.
I think we can do this by supplying a emacs/vi-mode for editing ebuilds.
Those modes should be strict and force the developer to do it right.

Regards,
  Mikael Hallendal

-- 

Mikael Hallendal
Gentoo Linux Developer, Desktop Team Leader
CodeFactory AB, Stockholm, Sweden


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] Re: All Developers!

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

On Sun, 2001-11-11 at 14:27, Mikael Hallendal wrote:
> lör 2001-11-10 klockan 22.04 skrev Daniel Robbins:
> > On Sat, Nov 10, 2001 at 03:39:13PM -0500, Chris Houser wrote:
> > > Daniel Robbins wrote:                 [Sat Nov 10 2001,  1:24:42PM EST]         
> > > > OK, if people need rules, I can provide them:
> > > > 
> > > > 1) Use one tab per indent
> > > > 
> > > > 2) Put comments on separate lines
> > > > 
> > > > 3) Avoid using "/" line continuation characters and use long lines instead.
> > > 
> > > Oh, please not 3) ... I realy dislike long lines.  I don't think it's
> > > too big a deal if the line continuations don't line up for everybody.
> > 
> > OK, I'll amend 3.  Either you can use long lines, or you can use "/" line
> > continuation characters.  If you *do* use line continuation characters, you
> > should *not* try to tab align them so that they're "pretty".  Instead, follow
> > the line with a single space, then a "/", and then a newline.
> 
> Hmm .. imho it's much easier to read with the \ aligned.
> I think we can do this by supplying a emacs/vi-mode for editing ebuilds.
> Those modes should be strict and force the developer to do it right.
> 

Sure, but the problem just is: they do not align for different
tabwidth's, so the emacs/vi-mode is not going to help much in
that respect.  We either have to do it with only a space
before the \, or all use a tabwidth of 4 as recommended by
drobbins.

Ill rather go for the space before the \ then, no offence to
the 4 tabwidth guys ;)

> Regards,
>   Mikael Hallendal
> 
> -- 
> 
> Mikael Hallendal
> Gentoo Linux Developer, Desktop Team Leader
> CodeFactory AB, Stockholm, Sweden
> 
-- 

Martin Schlemmer
Gentoo Linux Developer, Desktop Team Developer
Cape Town, South Africa


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] Re: All Developers!

[Mikael Hallendal]

[-- Attachment #1: Type: text/plain, Size: 2333 bytes --]

sön 2001-11-11 klockan 13.39 skrev Martin Schlemmer:
> On Sun, 2001-11-11 at 14:27, Mikael Hallendal wrote:
> > lör 2001-11-10 klockan 22.04 skrev Daniel Robbins:
> > > On Sat, Nov 10, 2001 at 03:39:13PM -0500, Chris Houser wrote:
> > > > Daniel Robbins wrote:                 [Sat Nov 10 2001,  1:24:42PM EST]         
> > > > > OK, if people need rules, I can provide them:
> > > > > 
> > > > > 1) Use one tab per indent
> > > > > 
> > > > > 2) Put comments on separate lines
> > > > > 
> > > > > 3) Avoid using "/" line continuation characters and use long lines instead.
> > > > 
> > > > Oh, please not 3) ... I realy dislike long lines.  I don't think it's
> > > > too big a deal if the line continuations don't line up for everybody.
> > > 
> > > OK, I'll amend 3.  Either you can use long lines, or you can use "/" line
> > > continuation characters.  If you *do* use line continuation characters, you
> > > should *not* try to tab align them so that they're "pretty".  Instead, follow
> > > the line with a single space, then a "/", and then a newline.
> > 
> > Hmm .. imho it's much easier to read with the \ aligned.
> > I think we can do this by supplying a emacs/vi-mode for editing ebuilds.
> > Those modes should be strict and force the developer to do it right.
> > 
> 
> Sure, but the problem just is: they do not align for different
> tabwidth's, so the emacs/vi-mode is not going to help much in
> that respect.  We either have to do it with only a space
> before the \, or all use a tabwidth of 4 as recommended by
> drobbins.
> 
> Ill rather go for the space before the \ then, no offence to
> the 4 tabwidth guys ;)

I don't think there will be any problem making the emacs/vi-mode that
aligns the '\' with just one tab. Of course it won't look very good with
a non-emacs/vi editor but then it will look like 'foo \' will.

We should look on the ebuilds as source and not text-files. Just take a
look at emacs C-mode for example. When you hit TAB it aligns it
correctly, not 4 or 8 spaces. You set the indentwidth and so should we.

Ok, I'm a bit tired now so the above might be kinda hard to read but you
get the picture? :)

Regards,
  Mikael Hallendal

-- 

Mikael Hallendal
Gentoo Linux Developer, Desktop Team Leader
CodeFactory AB, Stockholm, Sweden


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] Re: All Developers!

[Damon M. Conway]

<lots of snippage>

REQUEST: Please trim your emails.

>Sure, but the problem just is: they do not align for different
>tabwidth's, so the emacs/vi-mode is not going to help much in
>that respect.  We either have to do it with only a space
>before the \, or all use a tabwidth of 4 as recommended by
>drobbins.
>
>Ill rather go for the space before the \ then, no offence to
>the 4 tabwidth guys ;)

As a 4 tabwidth guy, I don't care which one.  The space+\ method works for
both camps, so I prefer it as a standard.

kabau

--
"UNIX was not designed to stop you from doing stupid things, because that
 would also stop you from doing clever things."  --Doug Gwyn

Re: [gentoo-dev] Re: All Developers!

[Daniel Robbins]

On Wed, Nov 21, 2001 at 01:16:02PM -0600, Damon M. Conway wrote:
> 
> As a 4 tabwidth guy, I don't care which one.  The space+\ method works for
> both camps, so I prefer it as a standard.

In my neverending attempt to make things easy for everyone, there is now a standard.
Use a single space, then a \.  Happy Thanksgiving everyone!

Best Regards.

-- 
Daniel Robbins                                  <drobbins@gentoo.org>
Chief Architect/President                       http://www.gentoo.org 
Gentoo Technologies, Inc.

[gentoo-dev] Re: All Developers!

[Andreas Voegele]

Mikael Hallendal writes:

> Hmm .. imho it's much easier to read with the \ aligned.

I disagree.  I don't like aligned / (or, for example, aligned
variables in C programs) very much.  If you insert a new line that is
longer than the existing lines you might have to reformat the other
lines too.  If you commit your changes to the CVS and look at the
changes with "cvs diff" not only the newly inserted line but also all
the reformatted lines are displayed which is really annoying.

For example, if you have these lines:

./configure --host=${CHOST}          \
            --prefix=/usr            \
            --mandir=/usr/share/man

Now you add two new, very long options:

./configure --host=${CHOST}                             \
            --prefix=/usr                               \
            --mandir=/usr/share/man                     \
            --with-openssl-include=/usr/include/openssl \
            --with-openssl-libraries=/usr/lib/openssl

Because of the alignment more lines than really necessary have to be
changed, which clutters the output of "cvs diff".

> I think we can do this by supplying a emacs/vi-mode for editing
> ebuilds.  Those modes should be strict and force the developer to do
> it right.

Hm, it's easier to base the ebuild mode on Emacsen's sh-mode than to
write a new mode from scratch.  But sh-mode doesn't allow tabs at the
end of lines; and I don't know if it is possible to change the mode's
behaviour easily.

After looking at Emacsen's sh-mode, I think that the following style,
that uses tabs at the beginning of lines and neither tabs nor spaces
at the end of lines, would be the easiest style to implement:

./configure --host=${CHOST} \
    --prefix=/usr \
    --mandir=/usr/share/man

Re: [gentoo-dev] Re: All Developers!

[jano]

Hi,

drobbins gave the rule.  Please STOP cluttering my mailbox with this!

jano


> Mikael Hallendal writes:
>
>> Hmm .. imho it's much easier to read with the \ aligned.
>
> I disagree.  I don't like aligned / (or, for example, aligned
> variables in C programs) very much.  If you insert a new line that is
> longer than the existing lines you might have to reformat the other
> lines too.  If you commit your changes to the CVS and look at the
> changes with "cvs diff" not only the newly inserted line but also all
> the reformatted lines are displayed which is really annoying.
>
> For example, if you have these lines:
>
> ./configure --host=${CHOST}          \
>            --prefix=/usr            \
>            --mandir=/usr/share/man
>
> Now you add two new, very long options:
>
> ./configure --host=${CHOST}                             \
>            --prefix=/usr                               \
>            --mandir=/usr/share/man                     \
>            --with-openssl-include=/usr/include/openssl \
>            --with-openssl-libraries=/usr/lib/openssl
>
> Because of the alignment more lines than really necessary have to be
> changed, which clutters the output of "cvs diff".
>
>> I think we can do this by supplying a emacs/vi-mode for editing
>> ebuilds.  Those modes should be strict and force the developer to do
>> it right.
>
> Hm, it's easier to base the ebuild mode on Emacsen's sh-mode than to
> write a new mode from scratch.  But sh-mode doesn't allow tabs at the
> end of lines; and I don't know if it is possible to change the mode's
> behaviour easily.
>
> After looking at Emacsen's sh-mode, I think that the following style,
> that uses tabs at the beginning of lines and neither tabs nor spaces at
> the end of lines, would be the easiest style to implement:
>
> ./configure --host=${CHOST} \
>    --prefix=/usr \
>    --mandir=/usr/share/man
>
> _______________________________________________
> gentoo-dev mailing list
> gentoo-dev@cvs.gentoo.org
> http://cvs.gentoo.org/mailman/listinfo/gentoo-dev

Re: [gentoo-dev] Re: All Developers!

[Mikael Hallendal]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

sön 2001-11-11 klockan 19.12 skrev jano:
> 
> Hi,
> 
> drobbins gave the rule.  Please STOP cluttering my mailbox with this!

We are having a discussion about an issue that we obviously think is
important. If you don't agree just delete the mails. This is a
developers mailinglist for discussions about descisions. It is also a
community project so people are free to disagree with drobbins about
various issues.

If you are not interested in developers discussions there now are a
gentoo-user mailinglist.


> > ./configure --host=${CHOST}                             \
> >            --prefix=/usr                               \
> >            --mandir=/usr/share/man                     \
> >            --with-openssl-include=/usr/include/openssl \
> >            --with-openssl-libraries=/usr/lib/openssl
> >
> > Because of the alignment more lines than really necessary have to be
> > changed, which clutters the output of "cvs diff".

This is not a problem if you like me always puts the \ at the very end.

> > ./configure --host=${CHOST} \
> >    --prefix=/usr \
> >    --mandir=/usr/share/man

Imho, this is much harder to read and is it possible to align on -- for
the configure-lines (so that all flags get alligned with just hitting
TAB once?)

Regards,
  Mikael Hallendal

-- 

Mikael Hallendal
Gentoo Linux Developer, Desktop Team Leader
CodeFactory AB, Stockholm, Sweden


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [gentoo-dev] Re: All Developers!

[Tom von Schwerdtner]

>> I think we can do this by supplying a emacs/vi-mode for editing
>> ebuilds.  Those modes should be strict and force the developer to do
>> it right.
> 
> Hm, it's easier to base the ebuild mode on Emacsen's sh-mode than to
> write a new mode from scratch.  But sh-mode doesn't allow tabs at the
> end of lines; and I don't know if it is possible to change the mode's
> behaviour easily.

Just to chime in here, I know vim supports modelines that determine the 
behavior for a specific file (eg, "vim: tw=78:" or soemthing like that to 
set the text width of that file to 78), and IIRC Emacs supports similar 
modelines.....is this an option at all?  You would have to provide a 
template file for people to use for contributed ebuilds....or you could 
have a lil script that would add the lines when they were not 
present....but, I thought I'd mention it in case nobody considered it.

-Tom

Re: [gentoo-dev] Re: All Developers!

[Aron Griffis]

Daniel Robbins wrote:	[Sat Nov 10 2001, 01:24:42PM EST]
> 1) Use one tab per indent
> 
> 2) Put comments on separate lines
> 
> 3) Avoid using "/" line continuation characters and use long lines instead.

I don't care about 1 and 2, but I agree with Chouser about long lines.
I don't mind terribly when I have to edit an existing ebuild with long
lines, but *please* don't ask me to write them like that.

Continuations can make the code more understandable when used
appropriately.  And it's easy to write continuations that don't have any
problem with developers' tabbing preferences:

	./configure \
		--prefix=/usr \
		--mandir=/usr/share/man \
		--infodir=/usr/share/info

This might be considered overuse of line continuations, but it makes my
point; the code is readable, fits in a standard terminal, and has no
issues with tabs.

Aron

Re: [gentoo-dev] Re: All Developers!

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

On Sat, 2001-11-10 at 23:14, Aron Griffis wrote:
> Daniel Robbins wrote:	[Sat Nov 10 2001, 01:24:42PM EST]
> > 1) Use one tab per indent
> > 
> > 2) Put comments on separate lines
> > 
> > 3) Avoid using "/" line continuation characters and use long lines instead.
> 
> I don't care about 1 and 2, but I agree with Chouser about long lines.
> I don't mind terribly when I have to edit an existing ebuild with long
> lines, but *please* don't ask me to write them like that.
> 
> Continuations can make the code more understandable when used
> appropriately.  And it's easy to write continuations that don't have any
> problem with developers' tabbing preferences:
> 
> 	./configure \
> 		--prefix=/usr \
> 		--mandir=/usr/share/man \
> 		--infodir=/usr/share/info
> 
> This might be considered overuse of line continuations, but it makes my
> point; the code is readable, fits in a standard terminal, and has no
> issues with tabs.
> 
> Aron
> 

im ok with this, much better than one line, and solve the align problem
(although not as pretty ;-)


-- 

Martin Schlemmer
Gentoo Linux Developer, Desktop Team Developer
Cape Town, South Africa


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]