From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7EE57159C96 for ; Wed, 24 Jul 2024 22:14:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F05C0E2A65; Wed, 24 Jul 2024 22:14:50 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 95688E2A0E for ; Wed, 24 Jul 2024 22:14:50 +0000 (UTC) Message-ID: <0f37e9b8-4005-40ed-97db-ea3f2dc43585@gentoo.org> Date: Wed, 24 Jul 2024 18:14:46 -0400 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] [PATCH 1/3] cargo.eclass: Add cargo_env helper and use it in compile, test, install To: gentoo-dev@lists.gentoo.org References: <20240724220800.16994-1-chewi@gentoo.org> Content-Language: en-US From: Eli Schwartz Autocrypt: addr=eschwartz@gentoo.org; keydata= xjMEZmeRNBYJKwYBBAHaRw8BAQdAYNZ7pUDWhx1i2f3p6L2ZLu4FcY18UoeGC04Gq/khqwfN I0VsaSBTY2h3YXJ0eiA8ZXNjaHdhcnR6QGdlbnRvby5vcmc+wpYEExYKAD4WIQTvUdMIsc4j CIi+DYTqQj6ToWND8QUCZoRL+gIbAwUJBKKGAAULCQgHAwUVCgkICwUWAgMBAAIeBQIXgAAK CRDqQj6ToWND8aB5AP9r4kB691nNtNwKkdRiOdl7/k6WYzokvHvDamXxRJ0I+gEAjZqR5V8y mfR3fy2Z+r2Joeqdt3CIv5IwPs64spBvigLOOARmZ5E0EgorBgEEAZdVAQUBAQdATT46Z06b 1X9xjXFCYFxmq/Tj3tSEKZInDWTpoHQp4l8DAQgHwn4EGBYKACYWIQTvUdMIsc4jCIi+DYTq Qj6ToWND8QUCZmeRNAIbDAUJBKKGAAAKCRDqQj6ToWND8a2RAP40KPfbfoiZAJW5boFmFJ3G TUBDJRh9CWHyaPqq2PN+0wD/R07oLzfnJUN209mzi9TuTuHjeZybysyqXSw4MAxkMAY= In-Reply-To: <20240724220800.16994-1-chewi@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------tvvE1EjMGX64ynMVbKr889D4" X-Archives-Salt: fddd9c56-03d9-4093-ba0b-4fa6d0d01c22 X-Archives-Hash: 4592b2f9f17e8ad6176b24f351fd24dc This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------tvvE1EjMGX64ynMVbKr889D4 Content-Type: multipart/mixed; boundary="------------WhEbMflQ07JMmJkqU9RNgGEU"; protected-headers="v1" From: Eli Schwartz To: gentoo-dev@lists.gentoo.org Message-ID: <0f37e9b8-4005-40ed-97db-ea3f2dc43585@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/3] cargo.eclass: Add cargo_env helper and use it in compile, test, install References: <20240724220800.16994-1-chewi@gentoo.org> In-Reply-To: <20240724220800.16994-1-chewi@gentoo.org> --------------WhEbMflQ07JMmJkqU9RNgGEU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 7/24/24 6:07 PM, James Le Cuirot wrote: > Rust packages have a tendency to rebuild parts during test and install.= > It is not clear whether this can be addressed. We were therefore relyin= g > on some environment variables set during the compile phase for > cross-compiling to work in the later phases. This is not ideal, > especially if you need to build for multiple targets. Oof, yeah, as I mentioned on Monday in -dev, I have a package that actually produces meaningfully different programs if you rebuild it during test. dev-util/ruff will, when built with FEATURES=3Dtest, not show color when you run it. Don't know why, feel a bit too freaked out about rebuilding for tests *at all* to even think about fixing this in a "src_test compatible way". So I wonder if maybe we can somehow switch to e.g. doing the test phase in a different directory such that it doesn't modify the artifacts we actually want to install. --=20 Eli Schwartz --------------WhEbMflQ07JMmJkqU9RNgGEU-- --------------tvvE1EjMGX64ynMVbKr889D4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTnFNnmK0TPZHnXm3qEp9ErcA0vVwUCZqF81gUDAAAAAAAKCRCEp9ErcA0vV12Y AP0aH4KDKlnDPlvybijBCZtOVYXtav+KywN4U88sNworBQD9EsVCRNPKIhGbyAE2n5urQxW1ZTZK oG1u8+75Gf5u7w8= =nQGK -----END PGP SIGNATURE----- --------------tvvE1EjMGX64ynMVbKr889D4--