From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-86699-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id 6006F138334
for <garchives@archives.gentoo.org>; Sat, 2 Mar 2019 22:10:42 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 4E5BFE08D6;
Sat, 2 Mar 2019 22:10:39 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id F3CE0E08D1
for <gentoo-dev@lists.gentoo.org>; Sat, 2 Mar 2019 22:10:38 +0000 (UTC)
Received: from pomiot (d202-252.icpnet.pl [109.173.202.252])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
(Authenticated sender: mgorny)
by smtp.gentoo.org (Postfix) with ESMTPSA id 48C21335D04;
Sat, 2 Mar 2019 22:10:37 +0000 (UTC)
Message-ID: <0e94e8b545928b64c6a9ef3eb398ca142fd7b862.camel@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of
prune_libtool_files
From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Date: Sat, 02 Mar 2019 23:10:33 +0100
In-Reply-To: <CAJ0EP40KG+fddnWX6Ly3YzTzfntfwvwzGTfmmat_SKucTy71og@mail.gmail.com>
References: <20190220044541.30272-1-mattst88@gentoo.org>
<20190220044541.30272-2-mattst88@gentoo.org>
<w6gmumrgevc.fsf@kph.uni-mainz.de> <1550648203.1036.5.camel@gentoo.org>
<w6gmumkfk5a.fsf@kph.uni-mainz.de>
<CAJ0EP40KG+fddnWX6Ly3YzTzfntfwvwzGTfmmat_SKucTy71og@mail.gmail.com>
Organization: Gentoo
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-rNiuiCXQwo3uQtY/wnWF"
User-Agent: Evolution 3.30.5
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
X-Archives-Salt: 2df96abf-abf2-46ef-b22d-023dadf37cd8
X-Archives-Hash: ef0985af36f9702d85a6cbac61f1e15b
--=-rNiuiCXQwo3uQtY/wnWF
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Sat, 2019-03-02 at 16:59 -0500, Mike Gilbert wrote:
> On Mon, Feb 25, 2019 at 1:37 AM Ulrich Mueller <ulm@gentoo.org> wrote:
> > > > > > > On Wed, 20 Feb 2019, Micha=C5=82 G=C3=B3rny wrote:
> > > On Wed, 2019-02-20 at 07:20 +0100, Ulrich Mueller wrote:
> > > > > > > > > On Wed, 20 Feb 2019, Matt Turner wrote:
> > > > > # Don't install libtool archives (even for modules)
> > > > > - prune_libtool_files --all
> > > > > + find "${D}" -name '*.la' -delete || die
> > > >=20
> > > > Maybe restrict removal to regular files, i.e. add "-type f"?
> > > I suppose you should have spoken up when people started adopting that
> > > 'find' line all over the place. Though I honestly doubt we're going
> > > to see many packages installing '*.la' non-files.
> >=20
> > I have updated the example in ltprune.eclass now.
> >=20
> > That still won't catch regular non-libtool files, but people needing
> > additional sanity checks can still use the eclass.
>=20
> Perhaps we should un-ban the ltprune eclass for EAPI 7?
>=20
> It seems like it would still be useful to have a way of detecting
> libtool-archives instead of removing any file that ends with ".la".
>=20
How many valid cases for this are there? For comparison, how many
useless complexity will be added to ebuilds by thoughtless maintainers
using the first thing that seems to work without actually verifying
whether it is necessary?
Because as far as I can see, we're talking about maybe-one-package-
every-decade vs 90%+ ebuilds removing .la files.
--=20
Best regards,
Micha=C5=82 G=C3=B3rny
--=-rNiuiCXQwo3uQtY/wnWF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAlx6/1lfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF
QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI
EQp+/RAAoFlE3Y49NK3dJDhrC6syz6Fx60cxiyUFMgVo8AUJtdW0EXvBFNz+NXAn
oYzOEyzc9V4046YZp+9SC8W3BI/w0dfkxdbpBLpL3G9fiAe91PnYBtzhVMgaO1OH
y2z/5PAa6EQOx4Z1u5rR1Z9tzAZNWoXwPdOSd2Jfo/RyLBUP+wuDTNebgAiW+B6j
tAqUQ2iVH+FEHr3F9d1qqqDnCmktUhSGEAZ3C8c5hf6OvL/62+yjMvq6ZjS05rol
7z0YDgLFt98A/HJaMA3dPNak38a1MldrMMcPvG5MahEPBDOkMCMK0WKSiqMDHVSO
IyoPAJcxSrP5Wwi/l4+ilhDNL0A7Ud5lcygHleqiN8keXn5J4j8qkycygENJrRHN
AbbtyGfwefG/NzF0bXMOMN3p/sB8MBOOl2BtfrjE3A0Z9QgJi0Cds5uEVtA6fq7Y
Ntc1O32ErDbMmqnV+qmUBE286F61GhhVxJruKcSXnp+/p1rJfsFDeIGoArpl3tJJ
jV4HiosAG4c4a7VrolX3bxuJPFiD/DpfBT4/zDtWeri8uKki6haPz4piULRfDcYQ
F/IYX/3LI1rXD1sL+zPHgSaiys3VLB+SpPguK8tc33J4DijRXtNIziWFa8RAXI8W
67KNkfir+c3o8/L/n9spP5Oq2RlegE7D48VI8TFqrfMOU2+vZCs=
=eFlA
-----END PGP SIGNATURE-----
--=-rNiuiCXQwo3uQtY/wnWF--