From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id AE3B113825A for ; Sun, 15 May 2016 11:05:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5E7FF14313; Sun, 15 May 2016 11:05:01 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4153921C012 for ; Sun, 15 May 2016 11:05:00 +0000 (UTC) Received: from [192.168.1.2] (c-73-53-75-119.hsd1.wa.comcast.net [73.53.75.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zlg) by smtp.gentoo.org (Postfix) with ESMTPSA id 1DB68340C23 for ; Sun, 15 May 2016 11:04:59 +0000 (UTC) Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ To: gentoo-dev@lists.gentoo.org References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <1537862.pH6huOSrz0@localhost> <2471981.YXCVhQinPE@localhost> <20160515035327.37fcb81c@tundra.gateway.pace.com> From: Daniel Campbell Message-ID: <0c9bfc1f-eae9-b193-62ac-f10995efffff@gentoo.org> Date: Sun, 15 May 2016 04:04:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160515035327.37fcb81c@tundra.gateway.pace.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hm37NamUOFUPtvLbeL2MbhEPJ8rLJFv1b" X-Archives-Salt: edc8ad84-176c-4d47-a6d5-5fc8a036980e X-Archives-Hash: 656ec848f315c00a730dce95fa716e1f This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hm37NamUOFUPtvLbeL2MbhEPJ8rLJFv1b Content-Type: multipart/mixed; boundary="LjCwi4EUoBeOtEMuwbGPvD3Gl3UfUaLOW" From: Daniel Campbell To: gentoo-dev@lists.gentoo.org Message-ID: <0c9bfc1f-eae9-b193-62ac-f10995efffff@gentoo.org> Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <1537862.pH6huOSrz0@localhost> <2471981.YXCVhQinPE@localhost> <20160515035327.37fcb81c@tundra.gateway.pace.com> In-Reply-To: <20160515035327.37fcb81c@tundra.gateway.pace.com> --LjCwi4EUoBeOtEMuwbGPvD3Gl3UfUaLOW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/15/2016 02:53 AM, Ryan Hill wrote: > On Sun, 15 May 2016 08:40:39 +0900 > Aaron Bauman wrote: >=20 >> On Saturday, May 14, 2016 9:54:11 AM JST Rich Freeman wrote: >>> On Sat, May 14, 2016 at 7:55 AM, Aaron Bauman wrote= : =20 >>>> On Friday, May 13, 2016 4:52:09 PM JST Ian Delaney wrote: =20 >>>>> On Sat, 7 May 2016 23:25:58 +0200 >>>>> >>>>> Micha=C5=82 G=C3=B3rny wrote: =20 >>>>>> Do you seriously expect this code to work? How about testing? Or >>>>>> reading diffs before committing? =20 >>>> >>>> Absolutely nothing wrong was said here. Obviously the code was not = tested >>>> and Michal pointed that out very plainly. =20 >>> >>> It is actually possible to communicate both plainly and politely at >>> the same time. This does not require sacrificing any commitment to >>> quality at all. Really the only downside is having more of an >>> appearance of professionalism. =20 >> >> Please enlighten me as to what was impolite here? The strong language= of=20 >> "seriously" or definitively stating that the individual did not perfor= m the=20 >> necessary QA actions before committing? Both of which are completely = called=20 >> for and appropriate. No vulgarity, insults, or demeaning words were u= sed. =20 >> How would you have responded professionally? >=20 > I thought his response was pretty tame actually. If you break the tree= > because you couldn't be bothered to do the barest minimum of testing yo= u > absolutely deserve to be called out on it. >=20 > But if you guys just want to hug it out that's cool too. >=20 I think that depends on history. If the dev in question hasn't done that before, then it's entirely possible they *thought* they tested, or tested it *before* making some other edit and absent-mindedly committed. That's a screw-up, and devs should be notified. Ideally, they should be told *what* they screwed up and *how* to ensure it doesn't happen again. Admonishing them as if they were a child is not going to engender motivation to continue participation. We're all devs because we want to make Gentoo better (I hope, anyway), and part of that means we'll have to help each other out sometimes. There's more to it than coddling vs tearing someone down. --=20 Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 --LjCwi4EUoBeOtEMuwbGPvD3Gl3UfUaLOW-- --hm37NamUOFUPtvLbeL2MbhEPJ8rLJFv1b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXOFfZAAoJEAEkDpRQOeFwk4MP/ibc3nUx5Sco4qCZfZnYH+Pt ra4XWUJorjPT3jeYfhKPwvSpbbBijQyRSvEnUTYShM/SVv85b4fX3uGrMs5z+I3o 8LDIEdLpddvsnJpGyOmrsw1HbumVlprMkKUVNNcGllYvfsZ8ITNQNdCwesLkjdCJ lml8446Qkf4ld4dYQ6KInfDWRe81TkQw+g8Yr3AN9xAmJX4wmrRVuFxvPa5if4F/ AKbJi13pwyyS3Q+GHdKPnk/EpTiLFesIMWKEZL4eLjeegsuHCO9Yk1fSJZKoY78L 4MhL+NnlHlzPDwugGvOEsOa4D/UFeTZXYk0HjIP8koah/ALkRb9+fp8YS/7MpUox G1V/1mdhzKkS1bQxhIuwcPM7tiV/Rda0HvauvFfHQN61aibB2ZpWeypbE8Lz/EeB 1m2dZhQ/siLvT+ljTK1gl1pILVaLc8PkcR/hwf7w2tfdNW39O8sLa6aXhZASSKBQ PUUAvPoUwYVzNplhEdUEnU8hXQbG3AHHCjxeHQkVY6M1Dw2G42ySrRuNVxII4jcj 1v/JtXXi5kQj7KcOoIjpc5sP+HEK9MYl59qJKI7Mp36lzpV6dZxtYZ4CFVPl0TD3 5dK/gHQSYyA2nZ8QGTPtdbQ54LW33LekEM6XyyU5OcSK3wM19xxTnCDRyhIcpHeZ PDSHO5BfXRjC7IHPwPgm =TufI -----END PGP SIGNATURE----- --hm37NamUOFUPtvLbeL2MbhEPJ8rLJFv1b--