On 05/15/2016 02:53 AM, Ryan Hill wrote: > On Sun, 15 May 2016 08:40:39 +0900 > Aaron Bauman wrote: > >> On Saturday, May 14, 2016 9:54:11 AM JST Rich Freeman wrote: >>> On Sat, May 14, 2016 at 7:55 AM, Aaron Bauman wrote: >>>> On Friday, May 13, 2016 4:52:09 PM JST Ian Delaney wrote: >>>>> On Sat, 7 May 2016 23:25:58 +0200 >>>>> >>>>> Michał Górny wrote: >>>>>> Do you seriously expect this code to work? How about testing? Or >>>>>> reading diffs before committing? >>>> >>>> Absolutely nothing wrong was said here. Obviously the code was not tested >>>> and Michal pointed that out very plainly. >>> >>> It is actually possible to communicate both plainly and politely at >>> the same time. This does not require sacrificing any commitment to >>> quality at all. Really the only downside is having more of an >>> appearance of professionalism. >> >> Please enlighten me as to what was impolite here? The strong language of >> "seriously" or definitively stating that the individual did not perform the >> necessary QA actions before committing? Both of which are completely called >> for and appropriate. No vulgarity, insults, or demeaning words were used. >> How would you have responded professionally? > > I thought his response was pretty tame actually. If you break the tree > because you couldn't be bothered to do the barest minimum of testing you > absolutely deserve to be called out on it. > > But if you guys just want to hug it out that's cool too. > I think that depends on history. If the dev in question hasn't done that before, then it's entirely possible they *thought* they tested, or tested it *before* making some other edit and absent-mindedly committed. That's a screw-up, and devs should be notified. Ideally, they should be told *what* they screwed up and *how* to ensure it doesn't happen again. Admonishing them as if they were a child is not going to engender motivation to continue participation. We're all devs because we want to make Gentoo better (I hope, anyway), and part of that means we'll have to help each other out sometimes. There's more to it than coddling vs tearing someone down. -- Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6