From: David Seifert <soap@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Ulrich Müller" <ulm@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] rpm.eclass: Drop support for EAPI 6
Date: Fri, 12 Apr 2024 22:17:32 +0200 [thread overview]
Message-ID: <0b079f3c28273868e69bf32f196edb3206b12407.camel@gentoo.org> (raw)
In-Reply-To: <20240412155302.18701-1-ulm@gentoo.org>
On Fri, 2024-04-12 at 17:52 +0200, Ulrich Müller wrote:
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
> eclass/rpm.eclass | 63 +++-------------------------------------------
> -
> 1 file changed, 3 insertions(+), 60 deletions(-)
>
> diff --git a/eclass/rpm.eclass b/eclass/rpm.eclass
> index b9187167eb8f..c9c21aa6ebbd 100644
> --- a/eclass/rpm.eclass
> +++ b/eclass/rpm.eclass
> @@ -1,14 +1,13 @@
> -# Copyright 1999-2023 Gentoo Authors
> +# Copyright 1999-2024 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: rpm.eclass
> # @MAINTAINER:
> # base-system@gentoo.org
> -# @SUPPORTED_EAPIS: 6 7 8
> +# @SUPPORTED_EAPIS: 7 8
> # @BLURB: convenience class for extracting RPMs
>
> case ${EAPI} in
> - 6) inherit epatch eqawarn ;;
> 7|8) ;;
> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> esac
> @@ -18,10 +17,7 @@ _RPM_ECLASS=1
>
> inherit estack
>
> -case ${EAPI} in
> - 6) DEPEND="app-arch/rpm2targz" ;;
> - *) BDEPEND="app-arch/rpm2targz" ;;
> -esac
> +BDEPEND="app-arch/rpm2targz"
>
> # @FUNCTION: rpm_unpack
> # @USAGE: <rpms>
> @@ -88,59 +84,6 @@ rpm_src_unpack() {
> done
> }
>
> -# @FUNCTION: rpm_spec_epatch
> -# @USAGE: [spec]
> -# @DEPRECATED: none
> -# @DESCRIPTION:
> -# Read the specified spec (defaults to ${PN}.spec) and attempt to
> apply
> -# all the patches listed in it. If the spec does funky things like
> moving
> -# files around, well this won't handle that.
> -rpm_spec_epatch() {
> - # no epatch in EAPI 7 and later
> - [[ ${EAPI} == 6 ]] || die "${FUNCNAME} is banned in EAPI
> ${EAPI}"
> -
> - local p spec=$1
> - local dir
> -
> - if [[ -z ${spec} ]] ; then
> - # search likely places for the spec file
> - for spec in "${PWD}" "${S}" "${WORKDIR}" ; do
> - spec+="/${PN}.spec"
> - [[ -e ${spec} ]] && break
> - done
> - fi
> - [[ ${spec} == */* ]] \
> - && dir=${spec%/*} \
> - || dir=
> -
> - ebegin "Applying patches from ${spec}"
> -
> - grep '^%patch' "${spec}" | \
> - while read line ; do
> - # expand the %patch line
> - set -- ${line}
> - p=$1
> - shift
> -
> - # process the %patch arguments
> - local arg
> - EPATCH_OPTS=
> - for arg in "$@" ; do
> - case ${arg} in
> - -b) EPATCH_OPTS+=" --suffix" ;;
> - *) EPATCH_OPTS+=" ${arg}" ;;
> - esac
> - done
> -
> - # extract the patch name from the Patch# line
> - set -- $(grep "^P${p#%p}: " "${spec}")
> - shift
> - epatch "${dir:+${dir}/}$*"
> - done
> -
> - eend
> -}
> -
> fi
>
> EXPORT_FUNCTIONS src_unpack
LGTM
prev parent reply other threads:[~2024-04-12 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 15:52 [gentoo-dev] [PATCH] rpm.eclass: Drop support for EAPI 6 Ulrich Müller
2024-04-12 20:17 ` David Seifert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b079f3c28273868e69bf32f196edb3206b12407.camel@gentoo.org \
--to=soap@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox