From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 43FB1138359 for ; Tue, 6 Oct 2020 11:47:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0DDDFE0AC9; Tue, 6 Oct 2020 11:47:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BEAB2E0AB8 for ; Tue, 6 Oct 2020 11:47:21 +0000 (UTC) Message-ID: <0a79413e1a70d6804f087cf41005e98cb4430dcd.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 5/5] dev-python/miniupnpc: Use verify-sig.eclass From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Tue, 06 Oct 2020 13:47:16 +0200 In-Reply-To: References: <20201006095814.101719-1-mgorny@gentoo.org> <20201006095814.101719-5-mgorny@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-y2lMTLbBcR719YzsdM4c" User-Agent: Evolution 3.36.5 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 27326e95-e361-4d4b-bbdf-be09065db77b X-Archives-Hash: c80254ec63b1c8328718b6a9f8724215 --=-y2lMTLbBcR719YzsdM4c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2020-10-06 at 11:24 +0100, Alexey Sokolov wrote: > =D0=B2=D1=82, 6 =D0=BE=D0=BA=D1=82. 2020 =D0=B3. =D0=B2 10:59, Micha=C5= =82 G=C3=B3rny : > > Signed-off-by: Micha=C5=82 G=C3=B3rny > > --- > > dev-python/miniupnpc/Manifest | 1 + > > dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild | 11 +++++++---- > > 2 files changed, 8 insertions(+), 4 deletions(-) > >=20 > > diff --git a/dev-python/miniupnpc/Manifest b/dev-python/miniupnpc/Manif= est > > index 955881a8af5a..5341c95b6ff0 100644 > > --- a/dev-python/miniupnpc/Manifest > > +++ b/dev-python/miniupnpc/Manifest > > @@ -1 +1,2 @@ > > DIST miniupnpc-2.1.20191224.tar.gz 94740 BLAKE2B 85c0b3eb678685bc7192d= bee9440ec5f5be80cbac4d6a4e0a6473662c66f05ef512322cd535a142ffe16d3099a86f78e= a70645a7eb2979c373e7a486aeab0cd5 SHA512 d362f914ce9177c1bc46f1f3ae59069c61c= 0c9c1b6ea7e78003d6b46445d3550835ffc541c2649b5fbc997d035357b461148edb3648135= f33d0ce98b54961917 > > +DIST miniupnpc-2.1.20191224.tar.gz.sig 543 BLAKE2B ddbde04faa7bce62fdb= b5b555bda9dc9ff69f09cc97442049adc787a03ec91824f14cdddaef6e577cf8d08fa96202f= c792333b8dab7e6e8c30847fa9302a35d0 SHA512 b8885d2002259c95ede7ab57aaf82db83= c2bd7ace3d0986179efac4245ffd42161049e0167a9ac1ff18de6c8df4d39356f0fb6aa6dad= a7523a238b4db4838887 > > diff --git a/dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild b/dev-p= ython/miniupnpc/miniupnpc-2.1.20191224.ebuild > > index 5e1d489b2e1e..e42aadd90e0d 100644 > > --- a/dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild > > +++ b/dev-python/miniupnpc/miniupnpc-2.1.20191224.ebuild > > @@ -5,11 +5,12 @@ EAPI=3D7 > >=20 > > PYTHON_COMPAT=3D( python3_{6,7,8} pypy3 ) > >=20 > > -inherit distutils-r1 > > +inherit distutils-r1 verify-sig > >=20 > > DESCRIPTION=3D"Python bindings for UPnP client library" > > HOMEPAGE=3D"http://miniupnp.free.fr/" > > -SRC_URI=3D"http://miniupnp.free.fr/files/${P}.tar.gz" > > +SRC_URI=3D"http://miniupnp.free.fr/files/${P}.tar.gz > > + verify-sig? ( http://miniupnp.free.fr/files/${P}.tar.gz.sig )" > >=20 > > LICENSE=3D"BSD" > > SLOT=3D"0" > > @@ -17,8 +18,10 @@ KEYWORDS=3D"amd64 ppc ppc64 x86" > > IUSE=3D"" > >=20 > > RDEPEND=3D">=3Dnet-libs/miniupnpc-${PV}:0=3D" > > -DEPEND=3D"${RDEPEND} > > - dev-python/setuptools[${PYTHON_USEDEP}]" > > +DEPEND=3D"${RDEPEND}" > > +BDEPEND=3D"verify-sig? ( app-crypt/openpgp-keys-miniupnp )" > > + > > +VERIFY_SIG_OPENPGP_KEY_PATH=3D/usr/share/openpgp-keys/miniupnp.asc >=20 > Shouldn't this be prefixed with ${BROOT}? (preferably, in the eclass) >=20 You are correct indeed. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-y2lMTLbBcR719YzsdM4c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl98WURfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA5xLAgAqS2iz8IKJJ16RslnwO+cDc1YALgZvKo0IVIRgS9AwqEU9XTlsxd4oHqh PJh9EVujHZQzhzpTBA1USUP6HvkkiHx4AsSIrJNE9kN8s7hz6Lys60ceWccJQUR0 EZTL1fevclRTJjjA70ravcyXiVqkpz6xINcmw36R6YhbMMWqSLRu9IPwS26HmvFz rsnj9YKP5G9ExloAMjtOtycL09aNi26uUpnj84JwcIBw5G/PiyiopUGdOnXGVeMB UzC1FJwOHi8wLvoA/UtUFLHar9E0zIf8vW+ztNJxoZgjWkAKQG2L9N0N2reAmAzI M814JvOG4SGDHS7K9LzWR6BQ4Cixyw== =vvWM -----END PGP SIGNATURE----- --=-y2lMTLbBcR719YzsdM4c--