public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org,Ulrich Mueller <ulm@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET
Date: Mon, 01 May 2017 13:20:01 +0200	[thread overview]
Message-ID: <08F1FCC1-CDCE-4B2B-90BC-3EFC573FFC6E@gentoo.org> (raw)
In-Reply-To: <22790.58520.405717.851810@a1i15.kph.uni-mainz.de>

Dnia 1 maja 2017 09:32:40 CEST, Ulrich Mueller <ulm@gentoo.org> napisał(a):
>>>>>> On Sun, 30 Apr 2017, Michał Górny wrote:
>
>> From now on I'm not going to listen to any suggestions that do not
>> come with a patch.
>
>You have posted a patch for review. So IMHO, asking others to do the
>work when you receive criticism isn't a reasonable request. All the
>more since the suggested changes are trivial.

You are confusing constructive criticism with meaningless style bikeshed which serves no purpose except creating more work on everyone. If you want to force a change, volunteer to do the work.

While at it, I would really appreciate if you fixed the issue causing underscores to be invisible in some applications, e.g. Quassel.

>
>Ulrich


-- 
Best regards,
Michał Górny (by phone)


  reply	other threads:[~2017-05-01 11:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 14:39 [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET Michał Górny
2017-04-29  3:41 ` Ulrich Mueller
2017-04-29  5:57   ` Michał Górny
2017-04-29 17:23     ` Davide Pesavento
2017-04-29 17:40       ` Michał Górny
2017-04-29 18:05         ` Davide Pesavento
2017-04-30 21:01           ` Michał Górny
2017-04-29 18:03 ` Kent Fredric
2017-04-30 20:56   ` Michał Górny
2017-05-01  7:32     ` Ulrich Mueller
2017-05-01 11:20       ` Michał Górny [this message]
2017-05-01 13:12         ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08F1FCC1-CDCE-4B2B-90BC-3EFC573FFC6E@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox